Resolve #3311480 "add set_attribute and add_class filters"

Closes #3311480

assigned to @florenttorregrosa

mentioned in merge request !26 (closed)

added 1 commit

• 8bfab0e0 - Issue #3311480: add set_attribute and add_class filters, add new test, code linting

Compare with previous version

added 1 commit

• da28ab0d - Issue #3311480: remove useless test class

Compare with previous version

resolved all threads

added 5 commits

• 8e38f1d4 - 1 commit from branch project:8.x-1.x
• 72fdb88f - Issue #3311480: add set_attribute and add_class, as they are proposed in #3301853
• f19c3e2c - Issue #3311480: add set_attribute and add_class filters, moved to a trait, slots friendly
• 85ebb551 - Issue #3311480: add set_attribute and add_class filters, add new test, code linting
• 9d7344b3 - Issue #3311480: remove useless test class

Compare with previous version

Here is my feedback. I don't see major blocking issues but you might want to have a look before committing.

Curious about the formatting of my comments? Check the Conventional Comments documentation.

Thanks I didn't know about Conventional Comments!

added 1 commit

• 181d6add - Issue #3311480: remove string casting and add doc

Compare with previous version

resolved all threads