diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 50e4d030c3bc564d2d6c74d2b0cce3dc903fd46c..ff039ba5f4d342a0c639dc52307297a698a79cc6 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -55,6 +55,8 @@ phpstan: allow_failure: false phpunit: allow_failure: false + variables: + _PHPUNIT_EXTRA: '' diff --git a/modules/ui_patterns_devel/src/Plugin/TwigValidatorRule/TwigValidatorRuleTest.php b/modules/ui_patterns_devel/src/Plugin/TwigValidatorRule/TwigValidatorRuleTestExpr.php similarity index 98% rename from modules/ui_patterns_devel/src/Plugin/TwigValidatorRule/TwigValidatorRuleTest.php rename to modules/ui_patterns_devel/src/Plugin/TwigValidatorRule/TwigValidatorRuleTestExpr.php index 3372a35ad5c776f3439bcec624b12e5deabc0b9d..cb652ab47c79ef28a4e96877c4bef18f721d252b 100644 --- a/modules/ui_patterns_devel/src/Plugin/TwigValidatorRule/TwigValidatorRuleTest.php +++ b/modules/ui_patterns_devel/src/Plugin/TwigValidatorRule/TwigValidatorRuleTestExpr.php @@ -22,7 +22,7 @@ use Twig\Node\Node; label: new TranslatableMarkup('Tests rules'), description: new TranslatableMarkup('Rules around Twig tests.'), )] -final class TwigValidatorRuleTest extends TwigValidatorRulePluginBase { +final class TwigValidatorRuleTestExpr extends TwigValidatorRulePluginBase { /** * Process Twig\Node\Expression\Test\NullTest. diff --git a/modules/ui_patterns_devel/tests/src/Kernel/TwigValidatorRule/TwigValidatorRuleTestTest.php b/modules/ui_patterns_devel/tests/src/Kernel/TwigValidatorRule/TwigValidatorRuleTestExprTest.php similarity index 93% rename from modules/ui_patterns_devel/tests/src/Kernel/TwigValidatorRule/TwigValidatorRuleTestTest.php rename to modules/ui_patterns_devel/tests/src/Kernel/TwigValidatorRule/TwigValidatorRuleTestExprTest.php index c0627e438c3adef10e03d1215ed0eedbfa222077..be3376427d4719c36c7214799dedc540b1905af5 100644 --- a/modules/ui_patterns_devel/tests/src/Kernel/TwigValidatorRule/TwigValidatorRuleTestTest.php +++ b/modules/ui_patterns_devel/tests/src/Kernel/TwigValidatorRule/TwigValidatorRuleTestExprTest.php @@ -8,14 +8,14 @@ use Drupal\Core\Logger\RfcLogLevel; use Drupal\Tests\ui_patterns_devel\Kernel\TwigValidatorTestBase; /** - * @coversDefaultClass \Drupal\ui_patterns_devel\Plugin\TwigValidatorRule\TwigValidatorRuleTest + * @coversDefaultClass \Drupal\ui_patterns_devel\Plugin\TwigValidatorRule\TwigValidatorRuleTestExpr * * @group ui_patterns_devel * @internal * * cSpell:disable */ -final class TwigValidatorRuleTestTest extends TwigValidatorTestBase { +final class TwigValidatorRuleTestExprTest extends TwigValidatorTestBase { /** * Provides tests data for testTwigValidatorTest. diff --git a/modules/ui_patterns_field_formatters/tests/fixtures/tests.formatter.yml b/modules/ui_patterns_field_formatters/tests/fixtures/tests.formatter.yml index aeaec42b3fbd4730a4229a16179508552a72a9d6..b9d31f8f7f97b3f6df1a4a2bde9c022d100b26b1 100644 --- a/modules/ui_patterns_field_formatters/tests/fixtures/tests.formatter.yml +++ b/modules/ui_patterns_field_formatters/tests/fixtures/tests.formatter.yml @@ -65,7 +65,6 @@ nesting_4: elementExists: - [ 'css', '.ui-patterns-test-component' ] elementNotExists: - - [ 'xpath', "//div[contains(@class, 'ui-patterns-test-component')]//div[contains(@class, 'ui-patterns-slots-wrapper') and contains(text(), '1')]" ] - [ 'xpath', "//div[contains(@class, 'ui-patterns-test-component')]//div[contains(@class, 'ui-patterns-slots-wrapper') and contains(text(), '2')]" ] - [ 'xpath', "//div[contains(@class, 'ui-patterns-test-component')]//div[contains(@class, 'ui-patterns-slots-wrapper') and contains(text(), '3')]" ] elementsCount: @@ -88,7 +87,6 @@ invalid_situation: field_name: 'field_text_with_summary' assertSession: elementNotExists: - - [ 'xpath', "//div[contains(@class, 'ui-patterns-test-component')]//div[contains(@class, 'ui-patterns-props-string') and contains(text(), 'this is first body3')]"] - [ 'xpath', "//div[contains(@class, 'ui-patterns-test-component')]//div[contains(@class, 'ui-patterns-props-string') and contains(text(), 'this is second body3')]"] elementsCount: - [ 'xpath', "//div[@class='ui-patterns-props-string']", 1 ] diff --git a/src/Element/ComponentElementBuilder.php b/src/Element/ComponentElementBuilder.php index a7cfe72d51f82e7c0ac89121c8458e68f4d57e5e..488181a4cac16ec62e4efaddd3ecf12c5bd2fee2 100644 --- a/src/Element/ComponentElementBuilder.php +++ b/src/Element/ComponentElementBuilder.php @@ -125,10 +125,11 @@ class ComponentElementBuilder implements TrustedCallbackInterface { if (!$source_id) { return NULL; } + /* @todo Performance issue... if (!$this->sourcesManager->isApplicable($source_id, $source_contexts)) { - // Throw new \Exception("source not applicable");. - return NULL; - } + // Throw new \Exception("source not applicable");. + return NULL; + }*/ /** @var \Drupal\ui_patterns\SourceInterface $source */ $source = $this->sourcesManager->createInstance( $source_id,