>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3569245. --> Reported by: [dewalt](https://www.drupal.org/user/1825400) Related to !25 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>When taxonomy term with TVI configuration is deleted, links to the term aren't deleted from menu. </p> <h4 id="summary-steps-reproduce">Steps to reproduce</h4> <p>- Create taxonomy term<br> - Configure TVI setting on the term (may be not requred)<br> - Create menu item leading to the term page<br> - Delete the term</p> <h3 id="summary-proposed-resolution">Investigation</h3> <p>Generally on entity deletion links disappear. It happens in menu_link_content_entity_predelete() hook. Short logic:</p> <div class="codeblock"> <pre><span style="color: #000000"><span style="color: #0000BB">&lt;?php<br>&nbsp;&nbsp;&nbsp; $url </span><span style="color: #007700">= </span><span style="color: #0000BB">$entity</span><span style="color: #007700">-&gt;</span><span style="color: #0000BB">toUrl</span><span style="color: #007700">(</span><span style="color: #0000BB">$rel</span><span style="color: #007700">);<br>&nbsp;&nbsp;&nbsp; </span><span style="color: #0000BB">$route_parameters </span><span style="color: #007700">= </span><span style="color: #0000BB">$url</span><span style="color: #007700">-&gt;</span><span style="color: #0000BB">getRouteParameters</span><span style="color: #007700">();<br><br>&nbsp;&nbsp;&nbsp; </span><span style="color: #FF8000">// Delete all MenuLinkContent links that point to this entity route.<br>&nbsp;&nbsp;&nbsp; </span><span style="color: #0000BB">$result </span><span style="color: #007700">= </span><span style="color: #0000BB">$menu_link_manager</span><span style="color: #007700">-&gt;</span><span style="color: #0000BB">loadLinksByRoute</span><span style="color: #007700">(</span><span style="color: #0000BB">$url</span><span style="color: #007700">-&gt;</span><span style="color: #0000BB">getRouteName</span><span style="color: #007700">(), </span><span style="color: #0000BB">$route_parameters</span><span style="color: #007700">);<br>&nbsp;&nbsp;&nbsp; if (</span><span style="color: #0000BB">$result</span><span style="color: #007700">) {<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; foreach (</span><span style="color: #0000BB">$result </span><span style="color: #007700">as </span><span style="color: #0000BB">$id </span><span style="color: #007700">=&gt; </span><span style="color: #0000BB">$instance</span><span style="color: #007700">) {<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (</span><span style="color: #0000BB">$instance</span><span style="color: #007700">-&gt;</span><span style="color: #0000BB">isDeletable</span><span style="color: #007700">() &amp;&amp; </span><span style="color: #0000BB">str_starts_with</span><span style="color: #007700">(</span><span style="color: #0000BB">$id</span><span style="color: #007700">, </span><span style="color: #DD0000">'menu_link_content:'</span><span style="color: #007700">)) {<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; </span><span style="color: #0000BB">$instance</span><span style="color: #007700">-&gt;</span><span style="color: #0000BB">deleteLink</span><span style="color: #007700">();<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br>&nbsp;&nbsp;&nbsp; }<br></span><span style="color: #0000BB">?&gt;</span></span></pre></div> <p>The issue is that \Drupal\tvi\Enhancer\RouteEnhancer adds defaults "view_id" and "display_id" to term route and this route params goes to menu_tree table:</p> <pre>menu_name&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; | main<br>mlid&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; | 425<br>id&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; | menu_link_content:196a1904-e797-4a5e-bb24-3090221d170c&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>parent&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |<br>route_name&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; | entity.taxonomy_term.canonical<br>route_param_key | taxonomy_term=289&amp;display_id=page_1&amp;view_id=taxonomy_term</pre><p>The same time you see above that menu_link_content_entity_predelete() uses route params from entity URL template, which returns taxonomy_term=289 only.</p> <div class="codeblock"> <pre><span style="color: #000000"><span style="color: #0000BB">&lt;?php<br>&nbsp; </span><span style="color: #007700">if (!</span><span style="color: #0000BB">in_array</span><span style="color: #007700">(</span><span style="color: #0000BB">$rel</span><span style="color: #007700">, [</span><span style="color: #DD0000">'collection'</span><span style="color: #007700">, </span><span style="color: #DD0000">'add-page'</span><span style="color: #007700">, </span><span style="color: #DD0000">'add-form'</span><span style="color: #007700">], </span><span style="color: #0000BB">TRUE</span><span style="color: #007700">)) {<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; </span><span style="color: #FF8000">// The entity ID is needed as a route parameter.<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; </span><span style="color: #0000BB">$uri_route_parameters</span><span style="color: #007700">[</span><span style="color: #0000BB">$this</span><span style="color: #007700">-&gt;</span><span style="color: #0000BB">getEntityTypeId</span><span style="color: #007700">()] = </span><span style="color: #0000BB">$this</span><span style="color: #007700">-&gt;</span><span style="color: #0000BB">id</span><span style="color: #007700">();<br>&nbsp; }<br></span><span style="color: #0000BB">?&gt;</span></span></pre></div> <p>In this way there is mismatch between route params in menu tree and expecting route params in menu_link_content_entity_predelete() and the link isn't found for deletion.</p> <p>I haven't still found why all the route params are written to "menu_tree" table, I make a comment with ways to solve when find.</p> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>I'll add it in futher comments, but shortly:</p> <p>- Should "tvi_entity_predelete()" hook be implemented to take care about this?<br> OR<br> - Is it a bug in Drupal core? (Should core avoid extra route params in "menu_tree" or should extra params be resolved with $entity-&gt;url()?)<br> OR<br> - Should extra params "view_id" and "display_id" attached in other way on page render only? E.g. on KernelEvents::REQUEST or KernelEvents::CONTROLLER event?</p>