## Summary The `field_storage_add`, `field_storage_update`, `field_add`, and `field_update` MCP tools fail when passing `allowed_values` for `list_string` / `list_integer` / `list_float` fields. The error is: ``` The configuration property settings.allowed_values.0.label.0 doesn't exist. ``` ## Root Cause The MCP tool's input schema is built from Drupal's **config schema** (via `InputDefinition::fromConfigSchema()`), which describes the structured/serialized format: ```json {"allowed_values": [{"value": "red", "label": "Red"}, {"value": "green", "label": "Green"}]} ``` However, `FieldStorageConfig::create()` expects the **simplified API format**: ```php ["allowed_values" => ["red" => "Red", "green" => "Green"]] ``` When saving, `FieldStorageConfigStorage::mapToStorageRecord()` calls `ListItemBase::storageSettingsToConfigData()` which re-structures the already-structured input, producing invalid nested arrays that fail config schema validation. The same class of bug affects field instance settings (`field_add` / `field_update`) via `fieldSettingsFromConfigData()` — for example, entity_reference handler settings with structured config-schema format. ## Fix In all 4 tool files, pass incoming settings through the field type's `*FromConfigData()` static method before handing them to the entity API. This converts from config-schema format to API format generically for all field types: ### `FieldStorageAdd.php` (\~line 170) ```php if (!empty($settings)) { $class = $field_type_definitions[$field_type]['class']; $storage_values['settings'] = $class::storageSettingsFromConfigData($settings); } ``` ### `FieldStorageUpdate.php` (\~line 162) ```php if (!empty($settings)) { $field_type = $field_storage->getType(); $field_type_definitions = $this->fieldTypePluginManager->getDefinitions(); $class = $field_type_definitions[$field_type]['class']; $settings = $class::storageSettingsFromConfigData($settings); $current_settings = $field_storage->getSettings(); $merged_settings = array_merge($current_settings, $settings); $field_storage->setSettings($merged_settings); } ``` ### `FieldAdd.php` (\~line 191) ```php if (!empty($settings)) { $field_type = $field_storage->getType(); $field_type_definitions = $this->fieldTypePluginManager->getDefinitions(); $class = $field_type_definitions[$field_type]['class']; $field_values['settings'] = $class::fieldSettingsFromConfigData($settings); } ``` ### `FieldUpdate.php` (\~line 183) ```php if (!empty($settings)) { $field_type = $field->getType(); $field_type_definitions = $this->fieldTypePluginManager->getDefinitions(); $class = $field_type_definitions[$field_type]['class']; $settings = $class::fieldSettingsFromConfigData($settings); $current_settings = $field->getSettings(); $settings = $this->removeNullValues($settings); $merged_settings = array_merge($current_settings, $settings); $field->setSettings($merged_settings); } ``` All files are in: `src/Plugin/tool/Tool/` within the `tool_belt_entity` submodule. ## Why This Works Drupal's field type classes implement static methods that mirror what the config storage layer does on load: - `storageSettingsFromConfigData()` — converts config-schema format → API format for **storage** settings - `fieldSettingsFromConfigData()` — converts config-schema format → API format for **instance** settings For `ListItemBase` (parent of `ListStringItem`, `ListIntegerItem`, `ListFloatItem`), `storageSettingsFromConfigData()` internally calls `simplifyAllowedValues()` which transforms: ```php // Config schema format (input) [["value" => "red", "label" => "Red"], ["value" => "green", "label" => "Green"]] // API format (output) ["red" => "Red", "green" => "Green"] ``` For field types that don't need transformation (string, text_long, link, address, etc.), these methods are identity functions — they return the input unchanged. So the fix is safe for all field types. ## Testing After applying the fix, verified with the MCP tools: | Field type | Settings | Result | |------------|----------|--------| | `list_string` | `allowed_values: [{value: "red", label: "Red"}, ...]` | :white_check_mark: | | `list_integer` | `allowed_values: [{value: 1, label: "One"}, ...]` | :white_check_mark: | | `text_long` | (no settings) | :white_check_mark: | | `link` | (no settings) | :white_check_mark: | | `address` | (no settings) | :white_check_mark: | | `entity_reference` | `{target_type: "taxonomy_term"}` | :white_check_mark: | ## Affected Versions Any version of tool_belt that uses `InputDefinition::fromConfigSchema()` to build the settings input schema for field tools. ## Labels `bug`, `field-api`, `mcp-tools`