>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3355328. --> Reported by: [urvashi_vora](https://www.drupal.org/user/3617487) >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>FILE: ...odules/contrib/taxonomy_search_admin_form/src/TaxonomySearchInterface.php<br> -------------------------------------------------------------------------------<br> FOUND 15 ERRORS AFFECTING 11 LINES<br> -------------------------------------------------------------------------------<br> 6 | ERROR | [x] Doc comment short description must end with a full stop<br> 11 | ERROR | [x] Doc comment short description must end with a full stop<br> 12 | ERROR | [x] Whitespace found at end of line<br> 13 | ERROR | [x] Parameter comment must be on the next line<br> 13 | ERROR | [x] Parameter comment must end with a full stop<br> 14 | ERROR | [ ] Parameter comment must start with a capital letter<br> 14 | ERROR | [x] Parameter comment must be on the next line<br> 14 | ERROR | [x] Parameter comment must end with a full stop<br> 16 | ERROR | [ ] Description for the @return value is missing<br> 21 | ERROR | [x] Doc comment short description must end with a full stop<br> 22 | ERROR | [x] Whitespace found at end of line<br> 23 | ERROR | [ ] Description for the @return value must be on the next line<br> 23 | ERROR | [x] Whitespace found at end of line<br> 25 | ERROR | [x] Expected 1 blank line after function; 0 found<br> 26 | ERROR | [x] The closing brace for the interface must have an empty line<br> | | before it<br> -------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> -------------------------------------------------------------------------------</p> <p>FILE: .../modules/contrib/taxonomy_search_admin_form/src/TaxonomySearchManager.php<br> -------------------------------------------------------------------------------<br> FOUND 25 ERRORS AFFECTING 19 LINES<br> -------------------------------------------------------------------------------<br> 8 | ERROR | [x] Doc comment short description must end with a full stop<br> 12 | ERROR | [x] Doc comment short description must end with a full stop<br> 17 | ERROR | [x] Whitespace found at end of line<br> 19 | ERROR | [x] Doc comment short description must end with a full stop<br> 25 | ERROR | [ ] Missing short description in doc comment<br> 31 | ERROR | [x] Whitespace found at end of line<br> 33 | ERROR | [x] Doc comment short description must end with a full stop<br> 34 | ERROR | [x] Whitespace found at end of line<br> 35 | ERROR | [x] Parameter comment must be on the next line<br> 35 | ERROR | [x] Parameter comment must end with a full stop<br> 36 | ERROR | [ ] Parameter comment must start with a capital letter<br> 36 | ERROR | [x] Parameter comment must be on the next line<br> 36 | ERROR | [x] Parameter comment must end with a full stop<br> 38 | ERROR | [ ] Description for the @return value is missing<br> 47 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 47 | ERROR | [x] Object operator not indented correctly; expected 6 spaces<br> | | but found 4<br> 49 | ERROR | [x] Whitespace found at end of line<br> 51 | ERROR | [x] Doc comment short description must end with a full stop<br> 52 | ERROR | [x] Whitespace found at end of line<br> 53 | ERROR | [ ] Description for the @return value must be on the next line<br> 53 | ERROR | [x] Whitespace found at end of line<br> 57 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8<br> 57 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced<br> | | with use statements<br> 60 | ERROR | [x] Expected 1 blank line after function; 0 found<br> 61 | ERROR | [x] The closing brace for the class must have an empty line<br> | | before it<br> -------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 21 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> -------------------------------------------------------------------------------</p> <p>FILE: ...al10/web/modules/contrib/taxonomy_search_admin_form/src/Form/EditForm.php<br> -------------------------------------------------------------------------------<br> FOUND 66 ERRORS AND 4 WARNINGS AFFECTING 59 LINES<br> -------------------------------------------------------------------------------<br> 12 | ERROR | [x] Doc comment short description must end with a full stop<br> 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 16 | ERROR | [x] Doc comment short description must end with a full stop<br> 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 23 | ERROR | [x] Doc comment short description must end with a full stop<br> 25 | ERROR | [ ] Missing parameter comment<br> 25 | ERROR | [ ] Missing parameter name<br> 26 | ERROR | [x] Separate the @param and @return sections by a blank line.<br> 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 29 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8<br> 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 31 | ERROR | [x] Whitespace found at end of line<br> 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 33 | ERROR | [x] Doc comment short description must start with a capital<br> | | letter<br> 33 | ERROR | [x] Doc comment short description must end with a full stop<br> 35 | ERROR | [ ] Missing parameter comment<br> 35 | ERROR | [x] Data types in @param tags need to be fully namespaced<br> 37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 38 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8<br> 41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8<br> 48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 51 | ERROR | [x] Doc comment short description must end with a full stop<br> 52 | ERROR | [x] Whitespace found at end of line<br> 53 | ERROR | [ ] Missing parameter comment<br> 53 | ERROR | [x] Expected 1 spaces after parameter type; 14 found<br> 54 | ERROR | [ ] Missing parameter comment<br> 54 | ERROR | [x] Data types in @param tags need to be fully namespaced<br> 56 | ERROR | [ ] Description for the @return value is missing<br> 58 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 59 | ERROR | [x] Whitespace found at end of line<br> 60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8<br> 61 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8<br> 63 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8<br> 64 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12<br> 65 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8<br> 66 | ERROR | [x] Whitespace found at end of line<br> 67 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8<br> 72 | WARNING | [x] A comma should follow the last multiline array item.<br> | | Found: true<br> 72 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE"<br> | | but found "true"<br> 75 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8<br> 79 | WARNING | [x] A comma should follow the last multiline array item.<br> | | Found: true<br> 79 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE"<br> | | but found "true"<br> 82 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8<br> 85 | WARNING | [x] A comma should follow the last multiline array item.<br> | | Found: "Search"<br> 88 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8<br> 89 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 91 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 94 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 96 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8<br> 97 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8<br> 98 | ERROR | [x] Whitespace found at end of line<br> 99 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8<br> 101 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8<br> 102 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12<br> 102 | WARNING | [ ] \Drupal calls should be avoided in classes, use<br> | | dependency injection instead<br> 103 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12<br> 104 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8<br> 104 | ERROR | [x] Expected newline after closing brace<br> 105 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12<br> 106 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8<br> 108 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8<br> 109 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 109 | ERROR | [x] Expected 1 blank line after function; 0 found<br> 109 | ERROR | [x] Whitespace found at end of line<br> 110 | ERROR | [x] The closing brace for the class must have an empty line<br> | | before it<br> -------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 63 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> -------------------------------------------------------------------------------</p> <p>Time: 333ms; Memory: 10MB</p> <h4 id="summary-steps-reproduce">Steps to reproduce</h4> <p>Execute: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig taxonomy_search_admin_form/</p> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>Fix the issues reported for Drupal and DrupalPractice standards</p> <h3 id="summary-remaining-tasks">Remaining tasks</h3> <p>Patch Review and fix remaining issues:<br> FILE: .../modules/contrib/taxonomy_search_admin_form/src/TaxonomySearchManager.php<br> -------------------------------------------------------------------------------<br> FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE<br> -------------------------------------------------------------------------------<br> 65 | WARNING | Vocabulary::loadMultiple calls should be avoided in classes,<br> | | use dependency injection instead<br> -------------------------------------------------------------------------------</p> <p>FILE: ...al10/web/modules/contrib/taxonomy_search_admin_form/src/Form/EditForm.php<br> -------------------------------------------------------------------------------<br> FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE<br> -------------------------------------------------------------------------------<br> 109 | WARNING | \Drupal calls should be avoided in classes, use dependency<br> | | injection instead<br> -------------------------------------------------------------------------------</p> <p>Time: 486ms; Memory: 10MB</p>