>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3133815. --> Reported by: [cainaru](https://www.drupal.org/user/3071219) >>> <p>It looks like in midst of porting this module to Drupal 8, the condition for checking the entity type in the subquery for the views argument handler was missed (see <a href="https://git.drupalcode.org/project/taxonomy_entity_index/-/commit/4d25ccbb93d4252bf2d003057524a5ecefb879e5#4ac2132a2d92c0f263627dd74ec338aba00bf7f4_43_55">https://git.drupalcode.org/project/taxonomy_entity_index/-/commit/4d25ccbb93d4252bf2d003057524a5ecefb879e5#4ac2132a2d92c0f263627dd74ec338aba00bf7f4_43_55</a>) even though the same condition was refactored and preserved in the views filter handler (see <a href="https://git.drupalcode.org/project/taxonomy_entity_index/-/commit/4d25ccbb93d4252bf2d003057524a5ecefb879e5#aab10bf6f961fc073c57440a91c8634e9251720f_54_77">https://git.drupalcode.org/project/taxonomy_entity_index/-/commit/4d25ccbb93d4252bf2d003057524a5ecefb879e5#aab10bf6f961fc073c57440a91c8634e9251720f_54_77</a>). Without checking the entity type, the contextual filter picks up seemingly unrelated entities.</p> <p>Take the scenerio where media and content both have field_tags that use the Tags taxonomy. Also, where node:123 is tagged with your target term, and media:123 is not tagged with that term. If you have a view of all media using this term, media:123 will be included despite not being tagged with the term because 123 is an entity id in the subquery for the node (node:123) that is tagged with the term.</p> <p>I could replicate it in a vanilla site with the following steps:</p> <ul> <li>In simplytest.me, enable media and this module.</li> <li>Add the tags field to the image media.</li> <li>Configure module to index both content and media.</li> <li>Created a node with nid = 1 with a tag (with tid = 2).</li> <li>Created media with mid = 1 without a tag.</li> <li>Create a view of all media.</li> <li>Add the contextual filter "Taxonomy Entity Index: Has taxonomy term ID on Media (with depth and indexed in taxonomy_entity_index)", and set the depth to 1 or more.</li> <li>View should be empty with the argument of 2, but media:1 is shown even though it has no tag.</li> </ul> <p>Adding the below code to the argument handler (as in the case in <a href="https://git.drupalcode.org/project/taxonomy_entity_index/-/blob/8.x-1.x/src/Plugin/views/filter/TaxonomyEntityIndexTidDepth.php#L127">/src/Plugin/views/filter/TaxonomyEntityIndexTidDepth.php:127</a>) appears to resolve this issue:</p> <pre>&nbsp;&nbsp;&nbsp; if (isset($this-&gt;baseTableInfo['table']['entity type'])) {<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; $subquery-&gt;condition('entity_type', $this-&gt;baseTableInfo['table']['entity type']);<br>&nbsp;&nbsp;&nbsp; }</pre>