>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3327536. --> Reported by: [samitk](https://www.drupal.org/user/961934) >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>Getting following error/warnings</p> <p>FILE: /app/modules/contrib/tagclouds/README.txt<br> ----------------------------------------------------------------------<br> FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES<br> ----------------------------------------------------------------------<br> 3 | WARNING | Line exceeds 80 characters; contains 132 characters<br> 4 | WARNING | Line exceeds 80 characters; contains 172 characters<br> ----------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/tagclouds/config/install/tagclouds.settings.yml<br> --------------------------------------------------------------------------<br> FOUND 1 ERROR AFFECTING 1 LINE<br> --------------------------------------------------------------------------<br> 8 | ERROR | [x] Expected 1 newline at end of file; 0 found<br> --------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> --------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/tagclouds/config/schema/tagclouds.schema.yml<br> -----------------------------------------------------------------------<br> FOUND 1 ERROR AFFECTING 1 LINE<br> -----------------------------------------------------------------------<br> 20 | ERROR | [x] Expected 1 newline at end of file; 0 found<br> -----------------------------------------------------------------------<br> PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> -----------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/tagclouds/src/CloudBuilder.php<br> ----------------------------------------------------------------------------------------------------------------------<br> FOUND 56 ERRORS AND 5 WARNINGS AFFECTING 54 LINES<br> ----------------------------------------------------------------------------------------------------------------------<br> 14 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name<br> 38 | ERROR | [ ] Parameter $language_manager is not described in comment<br> 92 | ERROR | [x] Expected 3 space(s) before asterisk; 1 found<br> 92 | ERROR | [x] Doc comment short description must end with a full stop<br> 93 | ERROR | [x] Expected 3 space(s) before asterisk; 1 found<br> 94 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0<br> 95 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2<br> 96 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 97 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 98 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 99 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 100 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 101 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 103 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 111 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 112 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2<br> 113 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0<br> 115 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0<br> 115 | ERROR | [x] Missing function doc comment<br> 116 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2<br> 116 | WARNING | [ ] Unused variable $term.<br> 116 | WARNING | [ ] Node::load calls should be avoided in classes, use dependency injection instead<br> 117 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 118 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 119 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 120 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 121 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 122 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 124 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 132 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 133 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2<br> 134 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0<br> 136 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0<br> 137 | ERROR | [x] Doc comment short description must end with a full stop<br> 139 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0<br> 140 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2<br> 140 | WARNING | [ ] Unused variable $term.<br> 140 | WARNING | [ ] Node::load calls should be avoided in classes, use dependency injection instead<br> 141 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 142 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 143 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 144 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 145 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 147 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 152 | ERROR | [x] Expected 1 space after "=&gt;"; 2 found<br> 155 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 156 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2<br> 157 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0<br> 159 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0<br> 159 | ERROR | [x] Missing function doc comment<br> 160 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2<br> 161 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 162 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 163 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 164 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 165 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 167 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 172 | ERROR | [x] Expected 1 space after "=&gt;"; 2 found<br> 175 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4<br> 176 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2<br> 177 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0<br> ----------------------------------------------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 55 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ----------------------------------------------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/tagclouds/src/CloudBuilderInterface.php<br> ---------------------------------------------------------------------------------------------------------------------<br> FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES<br> ---------------------------------------------------------------------------------------------------------------------<br> 9 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name<br> 16 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces<br> 18 | ERROR | [x] Expected 1 blank line after function; 0 found<br> 19 | ERROR | [x] The closing brace for the interface must have an empty line before it<br> ---------------------------------------------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ---------------------------------------------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/tagclouds/src/Controller/TagcloudsListVocs.php<br> ----------------------------------------------------------------------------------------------------------<br> FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES<br> ----------------------------------------------------------------------------------------------------------<br> 68 | ERROR | [x] Data types in @throws tags need to be fully namespaced<br> 79 | WARNING | [ ] Vocabulary::load calls should be avoided in classes, use dependency injection instead<br> ----------------------------------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ----------------------------------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/tagclouds/src/Controller/TagcloudsPageChunk.php<br> ------------------------------------------------------------------------------------------------------------------------------<br> FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 6 LINES<br> ------------------------------------------------------------------------------------------------------------------------------<br> 7 | WARNING | [x] Unused use statement<br> 19 | ERROR | [ ] Missing short description in doc comment<br> 20 | ERROR | [x] Do not append variable name "$tagcloudTag" to the type declaration in a member variable comment<br> 25 | ERROR | [ ] Missing short description in doc comment<br> 26 | ERROR | [x] Do not append variable name "$tagcloudsCloudBuilder" to the type declaration in a member variable comment<br> 70 | WARNING | [ ] Vocabulary::loadMultiple calls should be avoided in classes, use dependency injection instead<br> ------------------------------------------------------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ------------------------------------------------------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/tagclouds/src/Form/TagcloudsAdminPage.php<br> ---------------------------------------------------------------------------------------------------------------------------------------------<br> FOUND 16 ERRORS AND 1 WARNING AFFECTING 17 LINES<br> ---------------------------------------------------------------------------------------------------------------------------------------------<br> 20 | ERROR | [ ] Missing @var tag in member variable comment<br> 23 | ERROR | [ ] Parameter $language_manager is not described in comment<br> 57 | ERROR | [x] Each index in a multi-line array must be on a new line<br> 58 | ERROR | [x] Each index in a multi-line array must be on a new line<br> 59 | WARNING | [x] A comma should follow the last multiline array item. Found: )<br> 70 | ERROR | [ ] The array declaration extends to column 119 (the limit is 80). The array content should be split up over multiple lines<br> 81 | ERROR | [x] Array indentation error, expected 6 spaces but found 5<br> 82 | ERROR | [x] Array indentation error, expected 6 spaces but found 5<br> 83 | ERROR | [x] Array indentation error, expected 6 spaces but found 5<br> 84 | ERROR | [x] Array indentation error, expected 6 spaces but found 5<br> 88 | ERROR | [x] Array indentation error, expected 6 spaces but found 5<br> 89 | ERROR | [x] Array indentation error, expected 6 spaces but found 5<br> 90 | ERROR | [x] Array indentation error, expected 6 spaces but found 5<br> 91 | ERROR | [x] Array indentation error, expected 6 spaces but found 5<br> 153 | ERROR | [x] Visibility must be declared on method "getEditableConfigNames"<br> 155 | ERROR | [x] Expected 1 blank line after function; 0 found<br> 156 | ERROR | [x] The closing brace for the class must have an empty line before it<br> ---------------------------------------------------------------------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 14 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ---------------------------------------------------------------------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/tagclouds/src/Plugin/Block/TagcloudsTermsBlock.php<br> ---------------------------------------------------------------------------------------------------------------------------------------------<br> FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES<br> ---------------------------------------------------------------------------------------------------------------------------------------------<br> 104 | ERROR | [x] Use null coalesce operator instead of ternary operator.<br> 105 | ERROR | [x] Use null coalesce operator instead of ternary operator.<br> 140 | WARNING | [ ] Vocabulary::load calls should be avoided in classes, use dependency injection instead<br> 164 | ERROR | [ ] The array declaration extends to column 116 (the limit is 80). The array content should be split up over multiple lines<br> ---------------------------------------------------------------------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ---------------------------------------------------------------------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/tagclouds/src/TagService.php<br> ---------------------------------------------------------------------------------------------------------------------------------------------<br> FOUND 3 ERRORS AND 3 WARNINGS AFFECTING 6 LINES<br> ---------------------------------------------------------------------------------------------------------------------------------------------<br> 13 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name<br> 62 | ERROR | [x] list(...) is forbidden, use [...] instead.<br> 94 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead<br> 113 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead<br> 153 | ERROR | [ ] The array declaration extends to column 153 (the limit is 80). The array content should be split up over multiple lines<br> 166 | ERROR | [ ] Missing parameter type<br> ---------------------------------------------------------------------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ---------------------------------------------------------------------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/tagclouds/src/TagServiceInterface.php<br> -----------------------------------------------------------------------------------------------------------------<br> FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES<br> -----------------------------------------------------------------------------------------------------------------<br> 9 | WARNING | The class short comment should describe what the class does and not simply repeat the class name<br> 38 | WARNING | Line exceeds 80 characters; contains 81 characters<br> -----------------------------------------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/tagclouds/tagclouds.libraries.yml<br> ----------------------------------------------------------------------<br> FOUND 1 ERROR AFFECTING 1 LINE<br> ----------------------------------------------------------------------<br> 5 | ERROR | [x] Expected 1 newline at end of file; 0 found<br> ----------------------------------------------------------------------<br> PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ----------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/tagclouds/tagclouds.module<br> --------------------------------------------------------------------------------------------------------------------------------------------<br> FOUND 6 ERRORS AND 7 WARNINGS AFFECTING 10 LINES<br> --------------------------------------------------------------------------------------------------------------------------------------------<br> 1 | ERROR | [x] Missing file doc comment<br> 28 | WARNING | [x] A comma should follow the last multiline array item. Found: NULL<br> 29 | WARNING | [x] A comma should follow the last multiline array item. Found: ]<br> 34 | WARNING | [x] A comma should follow the last multiline array item. Found: NULL<br> 35 | WARNING | [x] A comma should follow the last multiline array item. Found: ]<br> 36 | WARNING | [x] A comma should follow the last multiline array item. Found: ]<br> 42 | WARNING | [ ] Line exceeds 80 characters; contains 102 characters<br> 42 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph<br> 45 | ERROR | [ ] The array declaration extends to column 132 (the limit is 80). The array content should be split up over multiple lines<br> 45 | ERROR | [ ] The array declaration extends to column 200 (the limit is 80). The array content should be split up over multiple lines<br> 50 | WARNING | [ ] Line exceeds 80 characters; contains 108 characters<br> 50 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph<br> 53 | ERROR | [ ] The array declaration extends to column 143 (the limit is 80). The array content should be split up over multiple lines<br> --------------------------------------------------------------------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> --------------------------------------------------------------------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/tagclouds/tagclouds.permissions.yml<br> ----------------------------------------------------------------------<br> FOUND 1 ERROR AFFECTING 1 LINE<br> ----------------------------------------------------------------------<br> 4 | ERROR | [x] Expected 1 newline at end of file; 0 found<br> ----------------------------------------------------------------------<br> PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ----------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/tagclouds/tagclouds.services.yml<br> ----------------------------------------------------------------------<br> FOUND 1 ERROR AFFECTING 1 LINE<br> ----------------------------------------------------------------------<br> 7 | ERROR | [x] Expected 1 newline at end of file; 2 found<br> ----------------------------------------------------------------------<br> PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ----------------------------------------------------------------------</p> <p>Time: 702ms; Memory: 12MB</p> <h4 id="summary-steps-reproduce">Steps to reproduce</h4> <p>Steps to reproduce</p> <p>Run following command</p> <p>phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/tagclouds/</p> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>Above error/warnings need to be fixed</p>