WSOD after installing the module (#3580947) · Issues · project / system_account

WSOD after installing the module

>>> [!note] Migrated issue   Reported by: [avpaderno](https://www.drupal.org/user/55077) Related to !16 !15 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> After installing the module, a WSOD is shown. The full error message is the following one. <pre>The website encountered an unexpected error. Try again later. Error: Call to undefined method Drupal\Core\Session\UserSession::hasField() in Drupal\system_account\Hook\SystemAccountEntityHooks->userFormatNameAlter() (line 60 of modules/contrib/system_account/src/Hook/SystemAccountEntityHooks.php). Drupal\Core\Extension\ModuleHandler->alter() (Line: 178) Drupal\Core\Session\UserSession->getDisplayName() (Line: 163) Drupal\Core\Session\AccountProxy->getDisplayName() (Line: 336) Drupal\user\Hook\UserHooks->toolbar() call_user_func_array() (Line: 389) Drupal\Core\Extension\ModuleHandler->{closure:Drupal\Core\Extension\ModuleHandler::invokeAll():388}() (Line: 340) Drupal\Core\Extension\ModuleHandler->invokeAllWith() (Line: 388) Drupal\Core\Extension\ModuleHandler->invokeAll() (Line: 77) Drupal\toolbar\Element\Toolbar::preRenderToolbar() call_user_func_array() (Line: 107) Drupal\Core\Render\Renderer->doTrustedCallback() (Line: 910) Drupal\Core\Render\Renderer->doCallback() (Line: 441) Drupal\Core\Render\Renderer->doRender() (Line: 513) Drupal\Core\Render\Renderer->doRender() (Line: 230) Drupal\Core\Render\Renderer->render() (Line: 501) Drupal\Core\Template\TwigExtension->escapeFilter() (Line: 87) __TwigTemplate_ddc5abd7059ea5dea22fd4d841e2487f->doDisplay() (Line: 402) Twig\Template->yield() (Line: 386) Twig\Template->render() (Line: 51) Twig\TemplateWrapper->render() (Line: 35) Drupal\Core\Template\TwigThemeEngine->renderTemplate() (Line: 428) Drupal\Core\Theme\ThemeManager->render() (Line: 500) Drupal\Core\Render\Renderer->doRender() (Line: 230) Drupal\Core\Render\Renderer->render() (Line: 162) Drupal\Core\Render\MainContent\HtmlRenderer->{closure:Drupal\Core\Render\MainContent\HtmlRenderer::renderResponse():157}() (Line: 634) Drupal\Core\Render\Renderer::{closure:Drupal\Core\Render\Renderer::executeInRenderContext():634}() Fiber->start() (Line: 635) Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 157) Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse() (Line: 90) Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray() (Line: 246) Symfony\Component\EventDispatcher\EventDispatcher::{closure:Symfony\Component\EventDispatcher\EventDispatcher::optimizeListeners():241}() (Line: 206) Symfony\Component\EventDispatcher\EventDispatcher->callListeners() (Line: 56) Symfony\Component\EventDispatcher\EventDispatcher->dispatch() (Line: 188) Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76) Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53) Drupal\Core\StackMiddleware\Session->handle() (Line: 48) Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28) Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32) Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 118) Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 92) Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48) Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51) Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 53) Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 54) Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 745) Drupal\Core\DrupalKernel->handle() (Line: 19)</pre><h3 id="summary-proposed-resolution">Proposed resolution</h3> Change the code to load the full user object before checking the User entity has the field added by the module. <pre>  public function userFormatNameAlter(&$name, $account): void {     if ($account->getAccountName() == 'system_account') {       $user = User::load($account->id());       if ($user && $user->hasField('system_account') && $user->get('system_account')->value) {         $name = $this->configFactory->get('system_account.settings')           ->get('display_name');       }     }   }</pre>Checking the account name is not required to fix the issue described here, but since we are changing that code, we should also change it not to assume there is only a system account.

issue