Commit dba0d8ea authored by Adam Shepherd's avatar Adam Shepherd
Browse files

Issue #3228605 by omrmankar, AdamPS: Fix Drupal coding standard and Drupal Practice

parent b20c2bec
Loading
Loading
Loading
Loading
+4 −4
Changes for modules/symfony_mailer_bc/symfony_mailer_bc.api.php: 4 added lines, 4 removed lines.
Original line number Diff line number Diff line
@@ -13,8 +13,8 @@
 *
 * @param array $message
 *   A message array, as described in hook_mail_alter().
 * @param ?\Drupal\Core\Config\Entity\ConfigEntityInterface $entity
 *   Entity. @see \Drupal\symfony_mailer\EmailInterface::getEntity()
 * @param \Drupal\Core\Config\Entity\ConfigEntityInterface $entity
 *   (optional) Entity. @see \Drupal\symfony_mailer\EmailInterface::getEntity()
 *
 * @see \Drupal\Core\Mail\MailManagerInterface::mail()
 * @see \Drupal\symfony_mailer\EmailFactory
@@ -27,8 +27,8 @@ function hook_mailer_bc_alter(array &$message, ?ConfigEntityInterface $entity) {
 *
 * @param array $message
 *   A message array, as described in hook_mail_alter().
 * @param ?\Drupal\Core\Config\Entity\ConfigEntityInterface $entity
 *   Entity. @see \Drupal\symfony_mailer\EmailInterface::getEntity()
 * @param \Drupal\Core\Config\Entity\ConfigEntityInterface $entity
 *   (optional) Entity. @see \Drupal\symfony_mailer\EmailInterface::getEntity()
 */
function hook_mailer_bc_MODULE_alter(array &$message, ?ConfigEntityInterface $entity) {
}
+6 −0
Changes for modules/symfony_mailer_bc/symfony_mailer_bc.install: 6 added lines, 0 removed lines.
Original line number Diff line number Diff line
<?php

/**
 * @file
 * Install, update and uninstall functions for the Symfony Mailer
 * Back-compatibility module.
 */

/**
 * Implements hook_requirements().
 */
+5 −0
Changes for modules/symfony_mailer_bc/symfony_mailer_bc.module: 5 added lines, 0 removed lines.
Original line number Diff line number Diff line
<?php

/**
 * @file
 * Provides back-compatibility when sending emails with Symfony Mailer.
 */

use Drupal\Core\Form\FormStateInterface;

/**
+7 −8
Changes for src/BaseEmailInterface.php: 7 added lines, 8 removed lines.
Original line number Diff line number Diff line
@@ -2,10 +2,8 @@

namespace Drupal\symfony_mailer;

use Drupal\Component\Render\MarkupInterface;
use Symfony\Component\Mime\Address;
use Symfony\Component\Mime\Header\Headers;
use Symfony\Component\Mime\Part\DataPart;

/**
 * Defines an interface related to the Symfony Email object.
@@ -13,6 +11,7 @@ use Symfony\Component\Mime\Part\DataPart;
 * The functions are mostly identical, except that set accessors are explicitly
 * named, e.g. setSubject() instead of subject(). Exceptions:
 * - No 'returnPath': should only be set by the SMTP server.
 *
 *   @see https://www.postmastery.com/about-the-return-path-header/
 * - No 'date': defaults automatically, can still override via getHeaders() if
 *   needed.
@@ -36,7 +35,7 @@ interface BaseEmailInterface {
  /**
   * Gets the email subject.
   *
   * @return ?\Drupal\Component\Render\MarkupInterface|string $subject
   * @return \Drupal\Component\Render\MarkupInterface|string
   *   The email subject, or NULL if not set.
   */
  public function getSubject();
@@ -54,7 +53,7 @@ interface BaseEmailInterface {
  /**
   * Gets the sender address.
   *
   * @return ?\Symfony\Component\Mime\Address
   * @return \Symfony\Component\Mime\Address
   *  The sender address, or NULL if not set.
   */
  public function getSender(): ?Address;
@@ -234,7 +233,7 @@ interface BaseEmailInterface {
  /**
   * Gets the text body.
   *
   * @return ?string
   * @return string
   *   The text body, or NULL if not set.
   */
  public function getTextBody(): ?string;
@@ -245,8 +244,8 @@ interface BaseEmailInterface {
   * Valid: after rendering. Email builders should instead call
   * EmailInterface::setBody() or related functions before rendering.
   *
   * @param ?string $body
   *   The HTML body, or NULL to remove the HTML body.
   * @param string $body
   *   (optional) The HTML body, or NULL to remove the HTML body.
   *
   * @return $this
   */
@@ -257,7 +256,7 @@ interface BaseEmailInterface {
   *
   * Valid: after rendering.
   *
   * @return ?string
   * @return string
   *   The HTML body, or NULL if not set.
   */
  public function getHtmlBody(): ?string;
+0 −1
Changes for src/BaseEmailTrait.php: 0 added lines, 1 removed line.
Original line number Diff line number Diff line
@@ -3,7 +3,6 @@
namespace Drupal\symfony_mailer;

use Symfony\Component\Mime\Address;
use Symfony\Component\Mime\Email as SymfonyEmail;
use Symfony\Component\Mime\Header\Headers;

/**
Loading