Issue #3324951 by navneet0693: Unpublished Profile Tags are available for...

Issue #3324951 by navneet0693: Unpublished Profile Tags are available for selection in Profile form.

The tag field in the profile uses profile_tags vocabulary.

The terms on profile entity are fetched by https://github.com/goalgorilla/open_social/blob/main/modules/social_features/social_profile/src/SocialProfileTagService.php in functions https://github.com/goalgorilla/open_social/blob/main/modules/social_features/social_profile/src/SocialProfileTagService.php#L87 and https://github.com/goalgorilla/open_social/blob/main/modules/social_features/social_profile/src/SocialProfileTagService.php#L118

These functions internally call the function https://github.com/goalgorilla/open_social/blob/main/modules/social_features/social_profile/src/SocialProfileTagService.php#L222 which was not checking if the term is published or not.

This check is added in original class here: https://github.com/goalgorilla/open_social/blob/main/modules/social_features/social_tagging/src/SocialTaggingService.php#L291

So, we added the checks in SocialProfileTagService class as well.