Commit 3ebaacc7 authored by mathieso's avatar mathieso

More tests, new views, things.

parent 0184c695
...@@ -9,6 +9,8 @@ X - initial valuies of new config flags and shit. ...@@ -9,6 +9,8 @@ X - initial valuies of new config flags and shit.
? Trimmed date format ? Trimmed date format
Module updates
# History # History
All records owned by nobody? All records owned by nobody?
...@@ -17,13 +19,29 @@ Submission feedback - put JSON of eval and other things in history record. ...@@ -17,13 +19,29 @@ Submission feedback - put JSON of eval and other things in history record.
Remove JSON field from submission content type. Remove JSON field from submission content type.
Need a filter to remove students not in own classes.
Date range filter on reports.
# Permission
Grader can get to http://s1.localhost/admin/config/user-interface, does nothing.
What do graders see when there is no admin toolbar?
- search in admin toolbar.
# Suggestion # Suggestion
Confirm cancel Confirm cancel
# SUbmission delays - user confidence
# Submission delays - user confidence
When submit, can be slow, tell user that something is happening. When submit, can be slow, tell user that something is happening.
...@@ -49,6 +67,9 @@ Does the instructor views access plugin work? Make one for graders and admin too ...@@ -49,6 +67,9 @@ Does the instructor views access plugin work? Make one for graders and admin too
Add record selection thing? Add record selection thing?
# FiB
color change after shrink
# Exercises # Exercises
......
No preview for this file type
...@@ -442,7 +442,13 @@ skilling.admin.badges.add_badge: ...@@ -442,7 +442,13 @@ skilling.admin.badges.add_badge:
description: 'Add a new badge.' description: 'Add a new badge.'
weight: 60 weight: 60
# Skilling | Reflections
skilling.admin.reflections:
title: 'Reflections'
route_name: view.reflection_notes_for_authors.list
parent: system.admin.skilling
description: 'List reflection notes.'
weight: 70
# Skilling | FiBs and MCQs # Skilling | FiBs and MCQs
......
...@@ -1592,9 +1592,6 @@ function skilling_node_view_alter(array &$build, Drupal\Core\Entity\EntityInterf ...@@ -1592,9 +1592,6 @@ function skilling_node_view_alter(array &$build, Drupal\Core\Entity\EntityInterf
$build['#post_render'][] = 'skilling_node_rebuild_headers'; $build['#post_render'][] = 'skilling_node_rebuild_headers';
/** @var Node $node */ /** @var Node $node */
$node = $entity; $node = $entity;
// if ($node->bundle() === SkillingConstants::CALENDAR_CONTENT_TYPE) {
// skilling_add_planner_form($build, $entity, $display);
// }
if ($node->bundle() === SkillingConstants::NOTICE_CONTENT_TYPE) { if ($node->bundle() === SkillingConstants::NOTICE_CONTENT_TYPE) {
/** @var \Drupal\skilling\Notice $noticeService */ /** @var \Drupal\skilling\Notice $noticeService */
$noticeService = Drupal::service('skilling.notice'); $noticeService = Drupal::service('skilling.notice');
...@@ -1674,7 +1671,6 @@ function skilling_node_view_alter(array &$build, Drupal\Core\Entity\EntityInterf ...@@ -1674,7 +1671,6 @@ function skilling_node_view_alter(array &$build, Drupal\Core\Entity\EntityInterf
// $build['#cache']['max-age'] = 0; // $build['#cache']['max-age'] = 0;
// \Drupal::service('page_cache_kill_switch')->trigger(); // \Drupal::service('page_cache_kill_switch')->trigger();
} // Is exercise content type. } // Is exercise content type.
// } // End isStudent().
// For authors, reviewers, and admins. // For authors, reviewers, and admins.
if ($currentUser->isAuthor() || $currentUser->isAdministrator() || $currentUser->isReviewer()) { if ($currentUser->isAuthor() || $currentUser->isAdministrator() || $currentUser->isReviewer()) {
if ($entity->getEntityTypeId() === 'node') { if ($entity->getEntityTypeId() === 'node') {
......
This diff is collapsed.
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment