>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3601636. --> Reported by: [hydra](https://www.drupal.org/user/647364) Related to !4 >>> <p>This issue tracks the changes needed to make the GitLab CI pipeline pass on a clean checkout of the <code>1.x</code> branch. It covers three areas: PHPStan static analysis, PHPCS coding standards, and the unit test suite.</p> <h3>PHPStan (level 4)</h3> <p>The main source of errors was unsafe <code>new static()</code> in plugin <code>create()</code> factory methods. PHPStan flags this because <code>new static()</code> in a non-final class returns the wrong type for subclasses. The fix is to give each concrete leaf class its own <code>create()</code> using <code>new self()</code>, and to add <code>): static</code> or <code>): self</code> return types throughout.</p> <ul> <li>Remove <code>create()</code> from abstract base classes (<code>SitePluginBase</code>, <code>SiteWithContentBase</code>, <code>ContentSiteActionBase</code>); add concrete <code>create()</code> with <code>new self()</code> to every leaf class</li> <li>Add missing <code>): static</code> / <code>): self</code> return types to all remaining <code>create()</code> methods for consistency</li> <li>Narrow <code>applies()</code> return type from <code>?bool</code> to <code>bool</code> in final example plugins (valid covariant narrowing; PHPStan can now prove <code>null</code> is never returned)</li> <li>Move hidden-plugin removal from <code>getDefinitions()</code> into <code>alterDefinitions()</code>, which is the correct location for definition mutations and makes the behaviour unit-testable in isolation</li> <li>PHPStan baseline reduced from 477 original errors to 11 genuinely unfixable entries</li> </ul> <h3>Unit test suite</h3> <p>Several tests were broken or could not exercise the code they were supposed to test:</p> <ul> <li><strong>PHPUnit 11 compatibility:</strong> <code>withConsecutive()</code> was removed in PHPUnit 11. Replaced with <code>willReturnCallback</code> using a call counter.</li> <li><strong>By-reference reflection call:</strong> <code>ReflectionMethod::invoke($sut, $definitions)</code> does not pass by reference. Fixed by switching to <code>invokeArgs($sut, [&amp;amp;$definitions])</code>.</li> <li><strong>URL generator test mocks:</strong> The test was calling <code>getSetting()</code> directly on the <code>SiteProxyInterface</code> mock, but the production code calls <code>getSite()-&gt;getSetting()</code>. Fixed by wiring <code>getSite()</code> to return a <code>SiteInterface</code> mock. Also fixed: <code>Request::create('/')</code> uses host <code>localhost</code>, not the intended test host &mdash; requests now use <code>Request::create('https://host.example/')</code>. The <code>setContext</code> mock was a no-op so context restoration could not be verified &mdash; fixed by making the callback actually propagate the host change.</li> <li><strong>SitesServiceTest:</strong> <code>buildRouteMatchKey</code> calls <code>getRawParameters()-&gt;all()</code> and <code>getParameters()-&gt;all()</code>, but the route match mocks did not stub those methods. Added empty parameter bag stubs.</li> <li><strong>SitesServiceRouteMatchCacheTest:</strong> A scalar route parameter triggers the entity-upcast path, which calls <code>getStorage()-&gt;load()</code>. The <code>EntityTypeManagerInterface</code> mock was not set up for this, causing a fatal error. Fixed by mocking <code>getStorage('node')</code> returning a storage where <code>load()</code> returns <code>NULL</code>.</li> <li><strong>SiteSettingsInheritanceSubscriberTest:</strong> The test used <code>-&gt;with($this-&gt;callback(function (&amp;amp;$ignore) { $ignore[] = 'extra'; }))</code> to verify the alter hook call and simultaneously add a key to the ignore list. PHPUnit's <code>with()</code> constraint callbacks receive arguments by value, so the modification was silently dropped and <code>extra</code> was always inherited. Fixed by switching to <code>willReturnCallback(function (string $hook, array &amp;amp;$ignore): void { ... })</code>, which correctly passes <code>$ignore</code> by reference.</li> </ul> <p>All 22 unit tests pass after these changes.</p>