>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3542625. --> Reported by: [hosterholz](https://www.drupal.org/user/3652307) Related to !50 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>When updating sitemap but not drupal/core, the JavaScript cache-busting parameter remains the same (e.g. ?v=10.4.8). When updating drupal/core but not sitemap, the JavaScript cache-busting parameter changes.</p> <p><a href="https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Core/Asset/LibraryDiscoveryParser.php?ref_type=heads#L169">LibraryDiscoveryParser</a> applies the Drupal version to every library that uses <code>version: VERSION</code>. It does not use the modules version.</p> <p>See the note on <a href="https://www.drupal.org/docs/develop/creating-modules/adding-assets-css-js-to-a-drupal-module-via-librariesyml">Adding assets (CSS, JS) to a Drupal module via *.libraries.yml</a>:</p> <blockquote><p>Starting from Drupal 10.1.2, the version information within a library definition plays a critical role in generating a unique hash for aggregated files. Consequently, it is imperative that the "version" in a library definition is updated whenever a referenced CSS/JS file undergoes changes.</p> <p>Alternatively, <strong>if the version is omitted, the prior behavior will apply, where the content of referenced CSS/JS files is utilized in the hash.</strong></p> <p><strong>Incorrect usage of version information could lead to browser and edge cache invalidation issues.</strong></p> <p>See <a href="https://www.drupal.org/node/3301716/revisions/view/12744806/13230795">this update</a> on the <a href="https://www.drupal.org/node/3301716">related changelog</a>. </p></blockquote> <h4 id="summary-steps-reproduce">Steps to reproduce</h4> <p><strong>First case</strong></p> <ul> <li>Use sitemap 2.1, use drupal/core 10.4.8</li> <li>Disable JS preprocessing<br> <code>$config['system.performance']['js']['preprocess'] = FALSE;</code></li> <li>Go to /admin/config/search/sitemap</li> <li>Look at site's source code and see<br> <code>&lt;script src="/modules/contrib/sitemap/js/sitemap.admin.js?v=10.4.8"&gt;&lt;/script&gt;</code></li> <li>Update sitemap to 2.2</li> <li>Look at site's source code and see<br> <code>&lt;script src="/modules/contrib/sitemap/js/sitemap.admin.js?v=10.4.8"&gt;&lt;/script&gt;</code></li> </ul> <p><strong>Second case</strong></p> <ul> <li>Use sitemap 2.2, use drupal/core 10.4.7</li> <li>Disable JS preprocessing<br> <code>$config['system.performance']['js']['preprocess'] = FALSE;</code></li> <li>Go to /admin/config/search/sitemap</li> <li>Look at site's source code and see<br> <code>&lt;script src="/modules/contrib/sitemap/js/sitemap.admin.js?v=10.4.7"&gt;&lt;/script&gt;</code></li> <li>Update drupal/core to 10.4.8</li> <li>Look at site's source code and see<br> <code>&lt;script src="/modules/contrib/sitemap/js/sitemap.admin.js?v=10.4.8"&gt;&lt;/script&gt;</code></li> </ul> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>Remove <code>version: VERSION</code> from sitemap.libraries.yml</p> <h3 id="summary-remaining-tasks">Remaining tasks</h3> <ol> <li><del>Write a patch</del> - done by @hosterholz in #2</li> <li><del>Review and feedback</del> - done by @mparker17 in #4</li> <li><del>RTBC and feedback</del> - done by @mparker17 in #4</li> <li><del>Commit</del> - done by @mparker17 in #6</li> <li><del>Release</del> - released in <a href="https://www.drupal.org/project/sitemap/releases/8.x-2.3">sitemap-8.x-2.3</a></li> </ol> <h3 id="summary-ui-changes">User interface changes</h3> <p>None.</p> <h3 id="summary-api-changes">API changes</h3> <p>None.</p> <h3 id="summary-data-model-changes">Data model changes</h3> <p>None.</p>