Commit 0df8ac5b authored by gbyte.co's avatar gbyte.co

Clean up

parent 9c45e4e2
......@@ -25,7 +25,7 @@ content entity types including:
* ...
Contributed entity types like commerce products or media entities can be indexed
as well. On top of that custom links can be added to the sitemap.
as well. On top of that custom links and view pages can be added to the sitemap.
To learn about XML sitemaps, see https://en.wikipedia.org/wiki/Sitemaps.
......
......@@ -112,7 +112,7 @@ function simple_sitemap_entity_form_submit($form, FormStateInterface &$form_stat
// Deleting bundle settings for old bundle.
// See SimplesitemapEntitiesForm::submitForm().
// todo: This will not be necessary if "multiple variants pro bundle" is implemented.
// todo: Not necessary once https://www.drupal.org/project/simple_sitemap/issues/3014649 is implemented.
if (isset($form['simple_sitemap']['simple_sitemap_variant']['#default_value'])) {
$old_variant = $form['simple_sitemap']['simple_sitemap_variant']['#default_value'];
if ($old_variant !== $values['simple_sitemap_variant']) {
......
......@@ -165,7 +165,7 @@ class SimplesitemapEntitiesForm extends SimplesitemapFormBase {
// Deleting bundle settings for old bundle.
// See simple_sitemap.module::simple_sitemap_entity_form_submit().
// todo: This will not be necessary if "multiple variants pro bundle" is implemented.
// todo: Not necessary once https://www.drupal.org/project/simple_sitemap/issues/3014649 is implemented.
if (isset($form['simple_sitemap_entities']['entities'][$entity_type_id][$entity_type_id . '_settings'][$entity_type_id . '_simple_sitemap_variant']['#default_value'])) {
$old_variant = $form['simple_sitemap_entities']['entities'][$entity_type_id][$entity_type_id . '_settings'][$entity_type_id . '_simple_sitemap_variant']['#default_value'];
if ($old_variant !== $values[$entity_type_id . '_simple_sitemap_variant']) {
......
......@@ -55,7 +55,6 @@ trait BatchTrait {
* @param $context
* @throws \Drupal\Component\Plugin\Exception\PluginException
*
* @todo Make sure batch does not run at the same time as cron.
* @todo Variants into generateSitemap().
*/
public static function doBatchGenerateSitemap(&$context) {
......
......@@ -439,7 +439,6 @@ class Simplesitemap {
* @throws \Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException
* @throws \Drupal\Component\Plugin\Exception\PluginNotFoundException
*
* @todo: enableEntityType automatically
* @todo multiple variants
*/
public function setBundleSettings($entity_type_id, $bundle_name = NULL, $settings = ['index' => TRUE]) {
......@@ -788,7 +787,7 @@ class Simplesitemap {
*
* @return bool
*
* @todo multiple variants?
* @todo multiple variants
*/
public function bundleIsIndexed($entity_type_id, $bundle_name = NULL) {
$settings = $this->getBundleSettings($entity_type_id, $bundle_name);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment