Skip to content

GitLab

Commit 97aa077d authored by Pawel G's avatar Pawel G
Browse files

Fixing wrong language codes in custom url generation, fixing wrong date format... 

Fixing wrong language codes in custom url generation, fixing wrong date format in sitemap, improving duplicate prevention and annotating some code.
parent 0be51209
Hide whitespace changes
Inline Side-by-side
src/Batch.php
View file @ 97aa077d
......@@ -2,6 +2,9 @@
/**
* @file
* Contains \Drupal\simple_sitemap\Batch.
*
* Helper functions for the Drupal batch API.
* @see https://api.drupal.org/api/drupal/core!includes!form.inc/group/batch/8
*/
namespace Drupal\simple_sitemap;
......@@ -40,6 +43,9 @@ class Batch {
);
}
/**
* Starts the batch process depending on where it was requested from.
*/
public function start() {
batch_set($this->batch);
switch ($this->batch_info['from']) {
......@@ -62,6 +68,12 @@ class Batch {
}
}
/**
* Adds operations to the batch of type 'entity_types' or 'custom_paths'.
*
* @param string $type
* @param array $operations
*/
public function add_operations($type, $operations) {
switch ($type) {
case 'entity_types':
......@@ -81,10 +93,15 @@ class Batch {
}
}
/**
* Callback function called by the batch API when all operations are finished.
*
* @see https://api.drupal.org/api/drupal/core!includes!form.inc/group/batch/8
*/
public static function finish_batch($success, $results, $operations) {
if ($success) {
if (!empty($results) || is_null(db_query('SELECT MAX(id) FROM {simple_sitemap}')->fetchField())) {
SitemapGenerator::generate_sitemap($results);
SitemapGenerator::generate_sitemap($results['generate']);
}
drupal_set_message(t("The <a href='@url' target='_blank'>XML sitemap</a> has been regenerated for all languages.",
array('@url' => $GLOBALS['base_url'] . '/sitemap.xml')));
......@@ -94,30 +111,31 @@ class Batch {
}
/**
* Wrapper function for Drupal\Core\Url::fromRoute.
* Returns url data for every language.
* Batch callback function which generates urls to entity paths.
*
* @param $route_name
* @param $route_parameters
* @param $options
* @see https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Url.php/function/Url%3A%3AfromRoute/8
* @param object $query
* @param array $info
* @param array $batch_info
* @param array &$context
*
* @return array
* Returns an array containing the internal path, url objects for every language,
* url options and access information.
* @see https://api.drupal.org/api/drupal/core!includes!form.inc/group/batch/8
*/
public static function generate_bundle_urls($query, $info, $batch_info, &$context) {
static function generate_bundle_urls($query, $info, $batch_info, &$context) {
$languages = \Drupal::languageManager()->getLanguages();
$default_language_id = Simplesitemap::get_default_lang_id();
// Initializing batch.
if (empty($context['sandbox'])) {
self::initialize_batch($query->countQuery()->execute()->fetchField(), $context);
}
// Getting id field name from plugin info, if not defined assuming the name of the first field in the query to be the entity id field name.
$fields = $query->getFields();
if (isset($info['field_info']['entity_id']) && isset($fields[$info['field_info']['entity_id']])) {
$id_field = $info['field_info']['entity_id'];
}
else {
reset($fields);
$id_field = key($fields);
//todo: register error
}
// Getting the name of the route name field if any.
......@@ -125,31 +143,22 @@ class Batch {
$route_name_field = $info['field_info']['route_name'];
}
// Initializing batch.
if (empty($context['sandbox'])) {
$context['sandbox']['progress'] = 0;
$context['sandbox']['current_id'] = 0;
$context['sandbox']['max'] = $query->countQuery()
->execute()
->fetchField();
// Getting the name of the route parameter field if any.
if (!empty($info['field_info']['route_parameters'])) {
$route_params_field = $info['field_info']['route_parameters'];
}
// Creating a query limited to n=batch_process_limit entries.
$result = $query->condition($id_field, $context['sandbox']['current_id'], '>')
->orderBy($id_field)
->range(0, $batch_info['batch_process_limit'])
->execute()
->fetchAll();
$query
->condition($id_field, $context['sandbox']['current_id'], '>')
->orderBy($id_field);
if (!empty($batch_info['batch_process_limit']))
$query->range(0, $batch_info['batch_process_limit']);
$result = $query->execute()->fetchAll();
foreach ($result as $row) {
self::set_current_id($row->$id_field, $context);
$context['sandbox']['current_id'] = $row->$id_field;
$context['sandbox']['progress']++;
// Getting the name of the route parameter field if any.
if (!empty($info['field_info']['route_parameters'])) {
$route_params_field = $info['field_info']['route_parameters'];
}
// Setting route parameters if they exist in the database (menu links).
if (isset($route_params_field) && !empty($route_parameters = unserialize($row->$route_params_field))) {
$route_parameters = array(key($route_parameters) => $route_parameters[key($route_parameters)]);
......@@ -183,20 +192,13 @@ class Batch {
$url_object = Url::fromRoute($route_name, $route_parameters, $options);
$access = self::access($url_object, $batch_info['anonymous_user_account']);
if (!$access) {
if (!$url_object->access($batch_info['anonymous_user_account']))
continue;
}
// Do not include path if it already exists.
$path = $url_object->getInternalPath();
if ($batch_info['remove_duplicates']) {
foreach ($context['results'] as $result) {
if ($result['path'] == $path) {
continue 2;
}
}
}
if ($batch_info['remove_duplicates'] && self::path_processed($path, $context['results']['processed_paths']))
continue;
$urls = array();
foreach ($languages as $language) {
......@@ -209,80 +211,54 @@ class Batch {
->toString();
}
}
$context['results'][] = array(
$context['results']['generate'][] = array(
'path' => $path,
'urls' => $urls,
'options' => $url_object->getOptions(),
'lastmod' => !empty($info['field_info']['lastmod']) ? $row->{$info['field_info']['lastmod']} : NULL,
'lastmod' => !empty($info['field_info']['lastmod']) ? date_iso8601($row->{$info['field_info']['lastmod']}) : NULL,
'priority' => !empty($info['bundle_settings']['priority']) ? $info['bundle_settings']['priority'] : NULL,
);
}
// Providing progress info.
if ($context['sandbox']['progress'] != $context['sandbox']['max']) {
$context['finished'] = $context['sandbox']['progress'] / $context['sandbox']['max'];
// Adding processing message after finishing every part of the batch.
if (!empty($context['results'][$context['sandbox']['progress']]['path'])) {
$last_path = HTML::escape($context['results'][$context['sandbox']['progress']]['path']);
$context['message'] = t("Processing path @current out of @max: @path", array(
'@current' => $context['sandbox']['progress'],
'@max' => $context['sandbox']['max'],
'@path' => $last_path,
));
}
}
if (!empty($batch_info['max_links']) && count($context['results']) >= $batch_info['max_links']) {
$chunks = array_chunk($context['results'], $batch_info['max_links']);
foreach($chunks as $i => $chunk_links) {
if (count($chunk_links) == $batch_info['max_links']) {
SitemapGenerator::generate_sitemap($chunk_links);
$context['results'] = array_slice($context['results'], count($chunk_links));
}
}
}
self::set_progress_info($context, $batch_info);
self::process_segment($context, $batch_info);
}
/**
* Wrapper function for Drupal\Core\Url::fromUserInput.
* Returns url data for every language.
/**
* Batch function which generates urls to custom paths.
*
* @param $user_input
* @param $options
* @see https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Url.php/function/Url%3A%3AfromUserInput/8
* @param array $custom_paths
* @param array $batch_info
* @param array &$context
*
* @return array or FALSE
* Returns an array containing the internal path, url objects for every language,
* url options and access information. Returns FALSE if path does not exist.
* @see https://api.drupal.org/api/drupal/core!includes!form.inc/group/batch/8
*/
public static function generate_custom_urls($custom_paths, $batch_info, &$context) {
$languages = \Drupal::languageManager()->getLanguages();
$default_language_id = Simplesitemap::get_default_lang_id();
$options['absolute'] = TRUE;
// Initializing batch.
if (empty($context['sandbox'])) {
self::initialize_batch(count($custom_paths), $context);
}
foreach($custom_paths as $i => $custom_path) {
self::set_current_id($i, $context);
$user_input = $custom_path['path'][0] === '/' ? $custom_path['path'] : '/' . $custom_path['path'];
if (!\Drupal::service('path.validator')->isValid($custom_path['path'])) { //todo: Change to different function, as this also checks if current user has access. The user however varies depending if process was started from the web interface or via cron/drush.
self::register_error(self::PATH_DOES_NOT_EXIST_OR_NO_ACCESS, array('@faulty_path' => $custom_path['path']), 'warning');
continue;
}
$options = array('absolute' => TRUE, 'language' => $languages[$default_language_id]);
$url_object = Url::fromUserInput($user_input, $options);
$access = self::access($url_object, $batch_info['anonymous_user_account']);
if (!$access) {
if (!$url_object->access($batch_info['anonymous_user_account']))
continue;
}
// Do not include path if it already exists. //todo: test
$path = $url_object->getInternalPath();
foreach ($context['results'] as $result) {
if ($result['path'] == $path) {
continue 2;
}
}
if ($batch_info['remove_duplicates'] && self::path_processed($path, $context['results']['processed_paths']))
continue;
$urls = array();
foreach($languages as $language) {
......@@ -294,13 +270,67 @@ class Batch {
$urls[$language->getId()] = Url::fromUserInput($user_input, $options)->toString();
}
}
$context['results'][] = array(
$context['results']['generate'][] = array(
'path' => $path,
'urls' => $urls,
'options' => $url_object->getOptions(),
'priority' => !empty($custom_path['priority']) ? $custom_path['priority'] : NULL,
);
}
self::set_progress_info($context, $batch_info);
self::process_segment($context, $batch_info);
}
private static function path_processed($needle, &$path_pool) {
if (in_array($needle, $path_pool)) {
return TRUE;
}
$path_pool[] = $needle;
return FALSE;
}
private static function initialize_batch($max, &$context) {
$context['sandbox']['progress'] = 0;
$context['sandbox']['current_id'] = 0;
$context['sandbox']['max'] = $max;
$context['results']['generate'] = !empty($context['results']['generate']) ? $context['results']['generate'] : array();
$context['results']['processed_paths'] = !empty($context['results']['processed_paths']) ? $context['results']['processed_paths'] : array();
}
private static function set_current_id($id, &$context) {
$context['sandbox']['progress']++;
$context['sandbox']['current_id'] = $id;
}
private static function set_progress_info(&$context, $batch_info) {
if ($context['sandbox']['progress'] != $context['sandbox']['max']) {
// Providing progress info to the batch API.
$context['finished'] = $context['sandbox']['progress'] / $context['sandbox']['max'];
// Adding processing message after finishing every batch segment.
end($context['results']['generate']);
$last_key = key($context['results']['generate']);
if (!empty($context['results']['generate'][$last_key]['path'])) {
$context['message'] = t("Processing path @current out of @max: @path", array(
'@current' => $context['sandbox']['progress'],
'@max' => $context['sandbox']['max'],
'@path' => HTML::escape($context['results']['generate'][$last_key]['path']),
));
}
}
}
private static function process_segment(&$context, $batch_info) {
if (!empty($batch_info['max_links']) && count($context['results']['generate']) >= $batch_info['max_links']) {
$chunks = array_chunk($context['results']['generate'], $batch_info['max_links']);
foreach ($chunks as $i => $chunk_links) {
if (count($chunk_links) == $batch_info['max_links']) {
SitemapGenerator::generate_sitemap($chunk_links);
$context['results']['generate'] = array_slice($context['results']['generate'], count($chunk_links));
}
}
}
}
/**
......@@ -319,16 +349,4 @@ class Batch {
\Drupal::logger('simple_sitemap')->notice($message);
drupal_set_message($message, $type);
}
/**
* Checks if anonymous users have access to a given path.
*
* @param \Drupal\Core\Url object
*
* @return bool
* TRUE if anonymous users have access to path, FALSE if they do not.
*/
protected static function access($url_object, $account) {
return $url_object->access($account); //todo: Add error checking.
}
}
src/Form/SimplesitemapSettingsForm.php
View file @ 97aa077d
......@@ -72,7 +72,7 @@ class SimplesitemapSettingsForm extends ConfigFormBase {
$form['simple_sitemap_settings']['advanced']['remove_duplicates'] = array(
'#type' => 'checkbox',
'#title' => t('Remove duplicate links'),
'#description' => t('Uncheck this to significantly speed up the sitemap generation process on a huge site (>10 000 entities).'),
'#description' => t('Uncheck this to significantly speed up the sitemap generation process on a huge site (>20 000 entities).'),
'#default_value' => $sitemap->get_setting('remove_duplicates'),
);
......
src/SitemapGenerator.php
View file @ 97aa077d
......@@ -56,12 +56,7 @@ class SitemapGenerator {
}
/**
* Generates and returns the sitemap.
*
* @param int $max_links
* This number dictates how many sitemap chunks are to be created.
*
* @return array $sitemaps.
* Adds all operations to the batch and starts it.
*/
public function start_batch() {
$batch = new Batch($this->generating_from);
......@@ -71,7 +66,9 @@ class SitemapGenerator {
}
/**
* Generates custom internal paths.
* Returns the custom path generating operation.
*
* @return array $operation.
*/
private function batch_add_custom_paths() {
$link_generator = new CustomLinkGenerator();
......@@ -79,7 +76,10 @@ class SitemapGenerator {
}
/**
* Lets all simple sitemap plugins add their paths to the sitemap.
* Collects the entity path generating information from all simeple_sitemap
* plugins to be added to the batch.
*
* @return array $operations.
*/
private function batch_add_entity_type_paths() {
......@@ -104,12 +104,11 @@ class SitemapGenerator {
}
/**
* Generates and returns the sitemap.
*
* @param int $max_links
* This number dictates how many sitemap chunks are to be created.
* Wrapper method which takes links along with their options and then
* generates and saves the sitemap.
*
* @return array $sitemaps.
* @param array $links
* All links with their multilingual versions and settings.
*/
public static function generate_sitemap($links) {
Simplesitemap::save_sitemap(array(
......@@ -120,7 +119,7 @@ class SitemapGenerator {
}
/**
* Generates and returns the sitemap index.
* Generates and returns the sitemap index for all sitemap chunks.
*
* @param array $sitemap
* All sitemap chunks keyed by the chunk ID.
......@@ -151,7 +150,7 @@ class SitemapGenerator {
* Generates and returns a sitemap chunk.
*
* @param array $sitemap_links
* All links with their translation and settings.
* All links with their multilingual versions and settings.
*
* @return string sitemap chunk
*/
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment