Skip to content

GitLab

Commit 521b81b3 authored by Pawel G's avatar Pawel G
Browse files

Make custom link generation profit from batch mode and refactor Batch class

parent 439cbcaa
Hide whitespace changes
Inline Side-by-side
src/Batch/BatchUrlGenerator.php
View file @ 521b81b3
......@@ -98,100 +98,6 @@ class BatchUrlGenerator {
return $this;
}
/**
* @return bool
*/
protected function isBatch() {
return $this->batchInfo['from'] != 'nobatch';
}
/**
* @param $path
* @return bool
*/
protected function pathProcessed($path) {
$path_pool = isset($this->context['results']['processed_paths']) ? $this->context['results']['processed_paths'] : [];
if (in_array($path, $path_pool)) {
return TRUE;
}
$this->context['results']['processed_paths'][] = $path;
return FALSE;
}
/**
* @param $max
*/
protected function initializeBatch($max) {
if ($this->needsInitialization()) {
$this->context['results']['generate'] = !empty($this->context['results']['generate']) ? $this->context['results']['generate'] : [];
if ($this->isBatch()) {
$this->context['sandbox']['progress'] = 0;
$this->context['sandbox']['current_id'] = 0;
$this->context['sandbox']['max'] = $max;
$this->context['results']['processed_paths'] = !empty($this->context['results']['processed_paths'])
? $this->context['results']['processed_paths'] : [];
}
}
}
/**
* @return bool
*/
protected function needsInitialization() {
return empty($this->context['sandbox']);
}
/**
* @param $id
*/
protected function setCurrentId($id) {
if ($this->isBatch()) {
$this->context['sandbox']['progress']++;
$this->context['sandbox']['current_id'] = $id;
}
}
/**
*
*/
protected function processSegment() {
if ($this->isBatch()) {
$this->setProgressInfo();
}
if (!empty($this->batchInfo['max_links']) && count($this->context['results']['generate']) >= $this->batchInfo['max_links']) {
$chunks = array_chunk($this->context['results']['generate'], $this->batchInfo['max_links']);
foreach ($chunks as $i => $chunk_links) {
if (count($chunk_links) == $this->batchInfo['max_links']) {
$remove_sitemap = empty($this->context['results']['chunk_count']);
$this->sitemapGenerator->generateSitemap($chunk_links, $remove_sitemap);
$this->context['results']['chunk_count'] = !isset($this->context['results']['chunk_count'])
? 1 : $this->context['results']['chunk_count'] + 1;
$this->context['results']['generate'] = array_slice($this->context['results']['generate'], count($chunk_links));
}
}
}
}
/**
*
*/
protected function setProgressInfo() {
if ($this->context['sandbox']['progress'] != $this->context['sandbox']['max']) {
// Providing progress info to the batch API.
$this->context['finished'] = $this->context['sandbox']['progress'] / $this->context['sandbox']['max'];
// Adding processing message after finishing every batch segment.
end($this->context['results']['generate']);
$last_key = key($this->context['results']['generate']);
if (!empty($this->context['results']['generate'][$last_key]['path'])) {
$this->context['message'] = $this->t(self::PROCESSING_PATH_MESSAGE, [
'@current' => $this->context['sandbox']['progress'],
'@max' => $this->context['sandbox']['max'],
'@path' => HTML::escape($this->context['results']['generate'][$last_key]['path']),
]);
}
}
}
/**
* Batch callback function which generates urls to entity paths.
*
......@@ -199,85 +105,62 @@ class BatchUrlGenerator {
*/
public function generateBundleUrls($entity_info) {
$query = $this->entityQuery->get($entity_info['entity_type_name']);
if (!empty($entity_info['keys']['id'])) {
$query->sort($entity_info['keys']['id'], 'ASC');
}
if (!empty($entity_info['keys']['bundle'])) {
$query->condition($entity_info['keys']['bundle'], $entity_info['bundle_name']);
}
if (!empty($entity_info['keys']['status'])) {
$query->condition($entity_info['keys']['status'], 1);
}
$count_query = clone $query;
$this->initializeBatch($count_query->count()->execute());
// Creating a query limited to n=batch_process_limit entries.
if ($this->isBatch()) {
$query->range($this->context['sandbox']['progress'], $this->batchInfo['batch_process_limit']);
}
foreach ($this->getBatchIterationEntities($entity_info) as $entity_id => $entity) {
$results = $query->execute();
if (!empty($results)) {
$entities = $this->entityTypeManager->getStorage($entity_info['entity_type_name'])->loadMultiple($results);
$this->setCurrentId($entity_id);
$priority = NULL;
foreach ($entities as $entity_id => $entity) {
$this->setCurrentId($entity_id);
$priority = NULL;
// Overriding entity settings if it has been overridden on entity edit page...
if (isset($this->batchInfo['entity_types'][$entity_info['entity_type_name']][$entity_info['bundle_name']]['entities'][$entity_id]['index'])) {
// Overriding entity settings if it has been overridden on entity edit page...
if (isset($this->batchInfo['entity_types'][$entity_info['entity_type_name']][$entity_info['bundle_name']]['entities'][$entity_id]['index'])) {
// Skipping entity if it has been excluded on entity edit page.
if (!$this->batchInfo['entity_types'][$entity_info['entity_type_name']][$entity_info['bundle_name']]['entities'][$entity_id]['index']) {
continue;
}
// Otherwise overriding priority settings for this entity.
$priority = $this->batchInfo['entity_types'][$entity_info['entity_type_name']][$entity_info['bundle_name']]['entities'][$entity_id]['priority'];
}
// Skipping entity if it has been excluded on entity edit page.
if (!$this->batchInfo['entity_types'][$entity_info['entity_type_name']][$entity_info['bundle_name']]['entities'][$entity_id]['index']) {
switch ($entity_info['entity_type_name']) {
// Loading url object for menu links.
case 'menu_link_content':
if (!$entity->isEnabled()) {
continue;
}
// Otherwise overriding priority settings for this entity.
$priority = $this->batchInfo['entity_types'][$entity_info['entity_type_name']][$entity_info['bundle_name']]['entities'][$entity_id]['priority'];
}
$url_object = $entity->getUrlObject();
break;
switch ($entity_info['entity_type_name']) {
// Loading url object for menu links.
case 'menu_link_content':
if (!$entity->isEnabled()) {
continue;
}
$url_object = $entity->getUrlObject();
break;
// Loading url object for other entities.
default:
// todo: file entity type does not have a canonical url and breaks generation, hopefully fixed in https://www.drupal.org/node/2402533
$url_object = $entity->toUrl();
}
// Loading url object for other entities.
default:
// todo: file entity type does not have a canonical url and breaks generation, hopefully fixed in https://www.drupal.org/node/2402533
$url_object = $entity->toUrl();
}
// Do not include external paths.
if (!$url_object->isRouted()) {
continue;
}
// Do not include external paths.
if (!$url_object->isRouted()) {
continue;
}
// Do not include paths inaccessible to anonymous users.
if (!$url_object->access($this->anonUser)) {
continue;
}
// Do not include paths inaccessible to anonymous users.
if (!$url_object->access($this->anonUser)) {
continue;
}
// Do not include paths that have been already indexed.
$path = $url_object->getInternalPath();
if ($this->batchInfo['remove_duplicates'] && $this->pathProcessed($path)) {
continue;
}
// Do not include paths that have been already indexed.
$path = $url_object->getInternalPath();
if ($this->batchInfo['remove_duplicates'] && $this->pathProcessed($path)) {
continue;
}
$url_object->setOption('absolute', TRUE);
$url_object->setOption('absolute', TRUE);
$path_data = [
'path' => $path,
'entity_info' => ['entity_type' => $entity_info['entity_type_name'], 'id' => $entity_id],
'lastmod' => method_exists($entity, 'getChangedTime') ? date_iso8601($entity->getChangedTime()) : NULL,
'priority' => isset($priority) ? $priority : (isset($entity_info['bundle_settings']['priority']) ? $entity_info['bundle_settings']['priority'] : NULL),
];
$this->addUrlVariants($url_object, $path_data, $entity);
}
$path_data = [
'path' => $path,
'entity_info' => ['entity_type' => $entity_info['entity_type_name'], 'id' => $entity_id],
'lastmod' => method_exists($entity, 'getChangedTime') ? date_iso8601($entity->getChangedTime()) : NULL,
'priority' => isset($priority) ? $priority : (isset($entity_info['bundle_settings']['priority']) ? $entity_info['bundle_settings']['priority'] : NULL),
];
$this->addUrlVariants($url_object, $path_data, $entity);
}
$this->processSegment();
}
......@@ -289,7 +172,11 @@ class BatchUrlGenerator {
*/
public function generateCustomUrls($custom_paths) {
$this->initializeBatch(count($custom_paths));
$custom_paths = $this->getBatchIterationCustomPaths($custom_paths);
if ($this->needsInitialization()) {
$this->initializeBatch(count($custom_paths));
}
foreach ($custom_paths as $i => $custom_path) {
$this->setCurrentId($i);
......@@ -325,6 +212,74 @@ class BatchUrlGenerator {
$this->processSegment();
}
/**
* @return bool
*/
protected function isBatch() {
return $this->batchInfo['from'] != 'nobatch';
}
/**
* @param $path
* @return bool
*/
protected function pathProcessed($path) {
$path_pool = isset($this->context['results']['processed_paths']) ? $this->context['results']['processed_paths'] : [];
if (in_array($path, $path_pool)) {
return TRUE;
}
$this->context['results']['processed_paths'][] = $path;
return FALSE;
}
/**
* @param $entity_info
* @return mixed
*/
private function getBatchIterationEntities($entity_info) {
$query = $this->entityQuery->get($entity_info['entity_type_name']);
if (!empty($entity_info['keys']['id'])) {
$query->sort($entity_info['keys']['id'], 'ASC');
}
if (!empty($entity_info['keys']['bundle'])) {
$query->condition($entity_info['keys']['bundle'], $entity_info['bundle_name']);
}
if (!empty($entity_info['keys']['status'])) {
$query->condition($entity_info['keys']['status'], 1);
}
if ($this->needsInitialization()) {
$count_query = clone $query;
$this->initializeBatch($count_query->count()->execute());
}
if ($this->isBatch()) {
$query->range($this->context['sandbox']['progress'], $this->batchInfo['batch_process_limit']);
}
return $this->entityTypeManager
->getStorage($entity_info['entity_type_name'])
->loadMultiple($query->execute());
}
/**
* @param $custom_paths
* @return mixed
*/
private function getBatchIterationCustomPaths($custom_paths) {
if ($this->needsInitialization()) {
$this->initializeBatch(count($custom_paths));
}
if ($this->isBatch()) {
$custom_paths = array_slice($custom_paths, $this->context['sandbox']['progress'], $this->batchInfo['batch_process_limit']);
}
return $custom_paths;
}
/**
* @param $url_object
* @param $path_data
......
src/Logger.php
View file @ 521b81b3
......@@ -11,40 +11,81 @@ use Drupal\Core\StringTranslation\StringTranslationTrait;
*/
class Logger {
/*
* Can be debug/info/notice/warning/error.
*/
const LOG_SEVERITY_LEVEL_DEFAULT = 'notice';
/*
* Can be status/warning/error.
*/
const DISPLAY_MESSAGE_TYPE_DEFAULT = 'status';
use StringTranslationTrait;
/**
* @var \Psr\Log\LoggerInterface
*/
protected $logger;
/**
* @var \Drupal\Core\Session\AccountProxyInterface
*/
protected $currentUser;
/**
* @var string
*/
protected $message = '';
/**
* @var array
*/
protected $substitutions = [];
/**
* Logger constructor.
*
* @param $logger
* @param $current_user
*/
public function __construct($logger, $current_user) {
public function __construct(
LoggerInterface $logger,
AccountProxyInterface $current_user
) {
$this->logger = $logger;
$this->currentUser = $current_user;
}
/**
* Logs error and optionally displays it to the privileged user.
*
* @param $message
* Can be string or an array where the first value is the message string and
* the second value an array with arrays containing
* placeholder => replacement values for the message.
* @param string $display
* Message type (status/warning/error), if set, message is displayed to
* privileged user in addition to being logged.
*/
public function registerError($message, $display = NULL) {
$substitutions = isset($message[1]) && is_array($message[1]) ? $message[1] : [];
$message = is_array($message) ? $message[0] : $message;
$this->logger->notice(strtr($message, $substitutions));
if (!empty($display)
&& $this->currentUser->hasPermission('administer sitemap settings')) {
drupal_set_message($this->t($message, $substitutions), $display);
}
* @param array $substitutions
* @return $this
*/
public function m($message, $substitutions = []) {
$this->message = $message;
$this->substitutions = $substitutions;
return $this;
}
/**
* @param string $logSeverityLevel
* @return $this
*/
public function log($logSeverityLevel = self::LOG_SEVERITY_LEVEL_DEFAULT) {
$this->logger->$logSeverityLevel(strtr($this->message, $this->substitutions));
return $this;
}
/**
* @param string $displayMessageType
* @param string $permission
* @return $this
*/
public function display($displayMessageType = self::DISPLAY_MESSAGE_TYPE_DEFAULT, $permission = '') {
if (empty($permission) || $this->currentUser->hasPermission($permission)) {
drupal_set_message($this->t($this->message, $this->substitutions), $displayMessageType);
}
return $this;
}
}
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment