>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3492876. --> Reported by: [anairamzap](https://www.drupal.org/user/2302858) Related to !45 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>When updating to PHP 8.2 the following deprecation warnings are thrown when saving a shorthand entity:</p> <pre>Deprecated function: mb_convert_encoding(): Handling HTML entities via mbstring is deprecated; use htmlspecialchars, htmlentities, or mb_encode_numericentity/mb_decode_numericentity instead in Drupal\shorthand\Entity\ShorthandStory-&gt;preSave() (line 128 of /var/www/docroot/modules/contrib/shorthand/src/Entity/ShorthandStory.php)<br><br>#0 /var/www/docroot/core/includes/bootstrap.inc(166): _drupal_error_handler_real(8192, 'mb_convert_enco...', '/var/www/docroo...', 128)<br>#1 [internal function]: _drupal_error_handler(8192, 'mb_convert_enco...', '/var/www/docroo...', 128)<br>#2 /var/www/docroot/modules/contrib/shorthand/src/Entity/ShorthandStory.php(128): mb_convert_encoding('&lt;meta charset="...', 'HTML-ENTITIES', 'UTF-8')<br>#3 /var/www/docroot/core/lib/Drupal/Core/Entity/EntityStorageBase.php(528): Drupal\shorthand\Entity\ShorthandStory-&gt;preSave(Object(Drupal\shorthand\ShorthandStoryStorage))<br>#4 /var/www/docroot/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php(753): Drupal\Core\Entity\EntityStorageBase-&gt;doPreSave(Object(Drupal\shorthand\Entity\ShorthandStory))<br>#5 /var/www/docroot/core/lib/Drupal/Core/Entity/EntityStorageBase.php(483): Drupal\Core\Entity\ContentEntityStorageBase-&gt;doPreSave(Object(Drupal\shorthand\Entity\ShorthandStory))<br>#6 /var/www/docroot/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php(806): Drupal\Core\Entity\EntityStorageBase-&gt;save(Object(Drupal\shorthand\Entity\ShorthandStory))<br>#7 /var/www/docroot/core/lib/Drupal/Core/Entity/EntityBase.php(354): Drupal\Core\Entity\Sql\SqlContentEntityStorage-&gt;save(Object(Drupal\shorthand\Entity\ShorthandStory))<br>#8 /var/www/docroot/core/lib/Drupal/Core/Entity/EntityForm.php(293): Drupal\Core\Entity\EntityBase-&gt;save()<br>#9 /var/www/docroot/modules/contrib/shorthand/src/Form/ShorthandStoryForm.php(166): Drupal\Core\Entity\EntityForm-&gt;save(Array, Object(Drupal\Core\Form\FormState))<br>#10 [internal function]: Drupal\shorthand\Form\ShorthandStoryForm-&gt;save(Array, Object(Drupal\Core\Form\FormState))</pre><p>And then if creating a new Shorthand Story deleting the Thumbnail field:</p> <pre>Deprecated function: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in Drupal\shorthand\Entity\ShorthandStory-&gt;preSave() (line 175 of /var/www/docroot/modules/contrib/shorthand/src/Entity/ShorthandStory.php)<br><br>#0 /var/www/docroot/core/includes/bootstrap.inc(166): _drupal_error_handler_real(8192, 'str_replace(): ...', '/var/www/docroo...', 175)<br>#1 [internal function]: _drupal_error_handler(8192, 'str_replace(): ...', '/var/www/docroo...', 175)<br>#2 /var/www/docroot/modules/contrib/shorthand/src/Entity/ShorthandStory.php(175): str_replace('{Shorthand Loca...', 'https://local.m...', NULL)<br>#3 /var/www/docroot/core/lib/Drupal/Core/Entity/EntityStorageBase.php(528): Drupal\shorthand\Entity\ShorthandStory-&gt;preSave(Object(Drupal\shorthand\ShorthandStoryStorage))<br>#4 /var/www/docroot/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php(753): Drupal\Core\Entity\EntityStorageBase-&gt;doPreSave(Object(Drupal\shorthand\Entity\ShorthandStory))<br>#5 /var/www/docroot/core/lib/Drupal/Core/Entity/EntityStorageBase.php(483): Drupal\Core\Entity\ContentEntityStorageBase-&gt;doPreSave(Object(Drupal\shorthand\Entity\ShorthandStory))<br>#6 /var/www/docroot/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php(806): Drupal\Core\Entity\EntityStorageBase-&gt;save(Object(Drupal\shorthand\Entity\ShorthandStory))<br>#7 /var/www/docroot/core/lib/Drupal/Core/Entity/EntityBase.php(354): Drupal\Core\Entity\Sql\SqlContentEntityStorage-&gt;save(Object(Drupal\shorthand\Entity\ShorthandStory))<br>#8 /var/www/docroot/core/lib/Drupal/Core/Entity/EntityForm.php(293): Drupal\Core\Entity\EntityBase-&gt;save()<br>#9 /var/www/docroot/modules/contrib/shorthand/src/Form/ShorthandStoryForm.php(166): Drupal\Core\Entity\EntityForm-&gt;save(Array, Object(Drupal\Core\Form\FormState))<br>#10 [internal function]: Drupal\shorthand\Form\ShorthandStoryForm-&gt;save(Array, Object(Drupal\Core\Form\FormState))</pre><h4 id="summary-steps-reproduce">Steps to reproduce</h4> <p>For <strong>mb_convert_encoding deprecation</strong></p> <ol> <li>Update to PHP 8.2</li> <li>Go to create a shorthand entity</li> <li>Select a shorthand story from the dropdown</li> <li>Click on save</li> <li>Note the deprecation warning (also present in watchdog)</li> </ol> <p>For <strong>str_replace</strong></p> <ol> <li>Update to PHP 8.2</li> <li>Go to create a shorthand entity</li> <li>Select a shorthand story from the dropdown</li> <li>Clear the contents of the Thumbnail field</li> <li>Click on save</li> <li>Note the deprecation warning (also present in watchdog)</li> </ol> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p><a href="https://php.watch/versions/8.2/mbstring-qprint-base64-uuencode-html-entities-deprecated#html">https://php.watch/versions/8.2/mbstring-qprint-base64-uuencode-html-entities-deprecated#html</a> suggests replacing it with the <code>htmlspecialchars_decode()</code> and <code>htmlentities()</code> methods.</p> <p>I think we can do that for both the <code>head</code> and <code>body</code>.</p> <p>Then for the deprecation regarding <code>str_replace</code> is just a matter of making sure we are not trying to replace a NULL variable.</p>