Commit fcdff4c3 authored by Arti's avatar Arti Committed by Thomas Seidl
Browse files

Issue #3367647 by arti_parmar, drunken monkey: Fixed unused variables and properties left in code.

parent f97cc6f7

CHANGELOG.txt

+2 −0
Original line number Diff line number Diff line 
Search API 1.x, dev (xxxx-xx-xx):

---------------------------------

- #3367647 by arti_parmar, drunken monkey: Fixed unused variables and properties

  left in code.

- #3311004 by nsavitsky, drunken monkey: Fixed "All taxonomy term fields"

  contextual filter to include fields with custom IDs.

- #3320841 by weekbeforenext, drunken monkey: Fixed indexing of "Processed text"

modules/search_api_db/tests/fixtures/update/search-api-db-base.php

+1 −1
Original line number Diff line number Diff line
@@ -49,7 +49,7 @@ $connection->update('config') 
$configs['search_api.settings'] = Yaml::decode(file_get_contents(__DIR__ . '/../../../../../config/install/search_api.settings.yml'));

$configs['search_api_db.settings'] = Yaml::decode(file_get_contents(__DIR__ . '/../../../config/install/search_api_db.settings.yml'));

foreach ($configs as $name => $config) {

  $data = $connection->insert('config')

  $connection->insert('config')

    ->fields([

      'name' => $name,

      'data' => serialize($config),

src/Plugin/search_api/processor/Stemmer.php

+1 −1
Original line number Diff line number Diff line
@@ -208,7 +208,7 @@ class Stemmer extends FieldsProcessorPluginBase { 
    // In the absence of the tokenizer processor, this ensures split words.

    $words = preg_split('/[^\p{L}\p{N}]+/u', strip_tags($value), -1, PREG_SPLIT_NO_EMPTY);

    $stemmed = [];

    foreach ($words as $i => $word) {

    foreach ($words as $word) {

      // To optimize processing, store processed stems in a static array.

      if (!isset($this->stems[$word])) {

        $stem = new Porter2($word, $this->configuration['exceptions']);

src/Utility/FieldsHelper.php

+1 −19
Original line number Diff line number Diff line
@@ -70,24 +70,6 @@ class FieldsHelper implements FieldsHelperInterface { 
   */

  protected $themeSwitcher;



  /**

   * Cache for the field type mapping.

   *

   * @var array|null

   *

   * @see getFieldTypeMapping()

   */

  protected $fieldTypeMapping;



  /**

   * Cache for the fallback data type mapping per index.

   *

   * @var array

   *

   * @see getDataTypeFallbackMapping()

   */

  protected $dataTypeFallbackMapping = [];



  /**

   * Constructs a FieldsHelper object.

   *
@@ -198,7 +180,7 @@ class FieldsHelper implements FieldsHelperInterface { 


    $values = $this->extractFieldValues($data);



    foreach ($values as $i => $value) {

    foreach ($values as $value) {

      $field->addValue($value);

    }

    $field->setOriginalType($data->getDataDefinition()->getDataType());

tests/src/Kernel/Processor/RenderedItemTest.php

+1 −1
Original line number Diff line number Diff line
@@ -356,7 +356,7 @@ class RenderedItemTest extends ProcessorTestBase { 
    }



    // Verify that no field values were added.

    foreach ($items as $key => $item) {

    foreach ($items as $item) {

      $rendered_item = $item->getField('rendered_item');

      $this->assertEmpty($rendered_item->getValues(), 'No rendered_item field value added when disabled for content type.');

    }