Commit e8f62b59 authored by Jonathan Smith's avatar Jonathan Smith Committed by Jonathan Smith
Browse files

Issue #3176822 by jonathan1055: Fix @todo coding standard

parent 96e374df

scheduler.module

+2 −2
Changes for scheduler.module: 2 added lines, 2 removed lines.
Original line number Diff line number Diff line
@@ -521,7 +521,7 @@ function scheduler_node_presave(EntityInterface $node) { 
 */

function scheduler_node_insert(EntityInterface $node) {

  // Removed RULES code but keep the function. There may be code to add here.

  // @TODO remove this comment when done. JSS Sep 2016.

  // @todo remove this comment when done. JSS Sep 2016.

}



/**
@@ -531,7 +531,7 @@ function scheduler_node_update(EntityInterface $node) { 
  // Removed RULES code but keep the function. There may be code to add here.

  // This function is currently called by actions SetPublishingDate and

  // SetUnpublishingDate.

  // @TODO remove this comment when done. JSS Sep 2016.

  // @todo remove this comment when done. JSS Sep 2016.

}



/**

scheduler_rules_integration/scheduler_rules_integration.module

+1 −1
Changes for scheduler_rules_integration/scheduler_rules_integration.module: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -25,7 +25,7 @@ function scheduler_rules_integration_node_insert(EntityInterface $node) { 
  // Invoke the Rules events to indicate that a new node has been scheduled.

  $scheduler_manager = \Drupal::service('scheduler.manager');

  if (!empty($node->publish_on->value)) {

    // @todo: In 7.x we had the dates as parameters. These are available in Rules via node.publish_on.value so maybe we do not need the parms?

    // @todo In 7.x we had the dates as parameters. These are available in Rules via node.publish_on.value so maybe we do not need the parms?

    $event = new NewNodeIsScheduledForPublishingEvent($node);

    $scheduler_manager->dispatch($event, NewNodeIsScheduledForPublishingEvent::EVENT_NAME);

  }

scheduler_rules_integration/scheduler_rules_integration.rules_defaults.inc

+1 −1
Changes for scheduler_rules_integration/scheduler_rules_integration.rules_defaults.inc: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -11,7 +11,7 @@ 
 * This functions returns an array of rules configurations with the

 * configuration names as keys.

 *

 * @TODO Convert to 8.x, this is stil 7.x code

 * @todo Convert to 8.x, this is stil 7.x code

 */

function scheduler_rules_integration_default_rules_configuration() {

  // Define two reaction rules which will be displayed on the 'Rules' tab. These

src/SchedulerManager.php

+2 −2
Changes for src/SchedulerManager.php: 2 added lines, 2 removed lines.
Original line number Diff line number Diff line
@@ -191,7 +191,7 @@ class SchedulerManager { 
        // $node->setChangedTime($publish_on) will fail badly if an API call has

        // removed the date. Trap this as an exception here and give a

        // meaningful message.

        // @TODO This will now never be thrown due to the empty(publish_on)

        // @todo This will now never be thrown due to the empty(publish_on)

        // check above to cater for translations. Remove this exception?

        if (empty($node->publish_on->value)) {

          $field_definitions = $this->entityTypeManager->getFieldDefinitions('node', $node->getType());
@@ -376,7 +376,7 @@ class SchedulerManager { 
        // $node->setChangedTime($unpublish_on) will fail badly if an API call

        // has removed the date. Trap this as an exception here and give a

        // meaningful message.

        // @TODO This will now never be thrown due to the empty(unpublish_on)

        // @todo This will now never be thrown due to the empty(unpublish_on)

        // check above to cater for translations. Remove this exception?

        if (empty($unpublish_on)) {

          $field_definitions = $this->entityTypeManager->getFieldDefinitions('node', $node->getType());

tests/src/Functional/SchedulerApiTest.php

+1 −1
Changes for tests/src/Functional/SchedulerApiTest.php: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -16,7 +16,7 @@ class SchedulerApiTest extends SchedulerBrowserTestBase { 
   *

   * @var array

   *

   * @TODO 'menu_ui' is in the exported node.type definition, and 'path' is in

   * @todo 'menu_ui' is in the exported node.type definition, and 'path' is in

   * the entity_form_display. Could these be removed from the config files and

   * then not needed here?

   */