diff --git a/.cspell-project-words.txt b/.cspell-project-words.txt index 0bfa8cd3d61644dbcf36e964591ec2e49a59162a..30939606a2233d9c9af00c3689624924299ef45a 100644 --- a/.cspell-project-words.txt +++ b/.cspell-project-words.txt @@ -11,6 +11,8 @@ nomsg nolog drupalspoons backported +tnid +randomstring # Scheduler words timecheck @@ -27,3 +29,6 @@ Taximayne Vicenza Webisa Wenlock + +# Real words missing from dictionary +unrequired diff --git a/README.md b/README.md index 4c8d392d3feb8cbe93c947cb4e1c74d252c24697..a99898a46a5237adc790b0c717b687307da052b4 100644 --- a/README.md +++ b/README.md @@ -103,13 +103,11 @@ entities, Commerce Products and Taxonomy Terms are supported. * To get help with crontab jobs, see https://drupal.org/cron -[//]: # "This comment is correctly not rendered" -[//]: # (another comment style which is not shown on the page) - ## Maintainers -[//]: # "cSpell:disable " -[//]: # "Spellchecking is stopped from here. Do not want to add all these names into the project-words file" +[//]: # cSpell:disable +[//]: # Do not want to add all these names into the cspell-project-words file + Current maintainers: - [Pieter Frenssen](https://www.drupal.org/u/pfrenssen) 2014(6.x)-current - [Jonathan Smith](https://www.drupal.org/u/jonathan1055) 2013(6.x)-current diff --git a/drupalci.yml b/drupalci.yml index 0b0fd1d1c2fa19e808f71fd48e289e994ce13abc..724a9142aab25202dd234e47b5b5955b6d710f25 100644 --- a/drupalci.yml +++ b/drupalci.yml @@ -16,7 +16,7 @@ build: eslint: halt-on-fail: true phpcs: - # phpcs halt-on-fail:true gives a grey 'build successful' message but does not stop the job. + # phpcs halt-on-fail:true gives a gray 'build successful' message but does not stop the job. halt-on-fail: true phpstan: halt-on-fail: false diff --git a/js/scheduler_vertical_tabs.js b/js/scheduler_vertical_tabs.js index 9a3898667a7ffeb1ad1872d1303fd90f0049a659..1d46bc0fbb4037c957ffb2c6584234ce859dba63 100644 --- a/js/scheduler_vertical_tabs.js +++ b/js/scheduler_vertical_tabs.js @@ -15,29 +15,29 @@ // Provide summary when editing a node. $('details#edit-scheduler-settings', context).drupalSetSummary(function (context) { - var vals = []; + var values = []; if ($('#edit-publish-on-0-value-date').val()) { - vals.push(Drupal.t('Scheduled for publishing')); + values.push(Drupal.t('Scheduled for publishing')); } if ($('#edit-unpublish-on-0-value-date').val()) { - vals.push(Drupal.t('Scheduled for unpublishing')); + values.push(Drupal.t('Scheduled for unpublishing')); } - if (!vals.length) { - vals.push(Drupal.t('Not scheduled')); + if (!values.length) { + values.push(Drupal.t('Not scheduled')); } - return vals.join('<br/>'); + return values.join('<br/>'); }); // Provide summary during content type configuration. $('#edit-scheduler', context).drupalSetSummary(function (context) { - var vals = []; + var values = []; if ($('#edit-scheduler-publish-enable', context).is(':checked')) { - vals.push(Drupal.t('Publishing enabled')); + values.push(Drupal.t('Publishing enabled')); } if ($('#edit-scheduler-unpublish-enable', context).is(':checked')) { - vals.push(Drupal.t('Unpublishing enabled')); + values.push(Drupal.t('Unpublishing enabled')); } - return vals.join('<br/>'); + return values.join('<br/>'); }); } }; diff --git a/phpcs.xml b/phpcs.xml index 156d69aebc4fed4ef1824c6e8e7d4135ad228a36..b10897756252fc0b09b806f5908a6554c1c8787c 100644 --- a/phpcs.xml +++ b/phpcs.xml @@ -13,8 +13,8 @@ <rule ref="DrupalPractice"/> <!-- Check these file extensions --> - <!-- .md and .yml are not processed by phpcs --> - <arg name="extensions" value="php,module,inc,install,css"/> + <!-- .yml files are not processed by phpcs --> + <arg name="extensions" value="php,module,inc,install,css,md"/> <!-- Use 's' to print the full sniff name in the report. --> <arg value="s"/> diff --git a/src/Form/SchedulerAdminForm.php b/src/Form/SchedulerAdminForm.php index c4b20b0a9fedf0aa0aea7ac48f941cb27cf7badf..fd0b06adb3c87df097009f5359eded0d4303b3ab 100644 --- a/src/Form/SchedulerAdminForm.php +++ b/src/Form/SchedulerAdminForm.php @@ -107,12 +107,12 @@ class SchedulerAdminForm extends ConfigFormBase { // Some modules may not create a default entity type during installation // or the entity type definitions may have been deleted. This is not an // exception, but will cause an error if we do not stop this loop. - $message_parms = [ + $message_params = [ '%module' => $plugin->dependency(), '%plugin_label' => $plugin->label(), '%bundle_id' => $bundle_id, ]; - $this->logger('scheduler')->notice('No %bundle_id entity types returned by %module module for use in %plugin_label', $message_parms); + $this->logger('scheduler')->notice('No %bundle_id entity types returned by %module module for use in %plugin_label', $message_params); $links[] = ['title' => "-- $collection_label -- (" . $this->t('no entity types defined') . ')']; continue; }