From 05fe8db98bfcaef72c6d5bc5549e821243e2ac92 Mon Sep 17 00:00:00 2001
From: Gabe Carleton-Barnes <gabe@thinkshout.com>
Date: Sat, 21 Nov 2020 21:20:56 +0000
Subject: [PATCH] Don't iterate over empty string of field mappings.
---
.../src/Entity/SalesforceMapping.php | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/modules/salesforce_mapping/src/Entity/SalesforceMapping.php b/modules/salesforce_mapping/src/Entity/SalesforceMapping.php
index dc9d83d2..bfed29e6 100644
--- a/modules/salesforce_mapping/src/Entity/SalesforceMapping.php
+++ b/modules/salesforce_mapping/src/Entity/SalesforceMapping.php
@@ -477,11 +477,13 @@ class SalesforceMapping extends ConfigEntityBase implements SalesforceMappingInt
public function getFieldMappings() {
// @TODO #fieldMappingField
$fields = [];
- foreach ($this->field_mappings as $i => $field) {
- $fields[$i] = $this->fieldManager()->createInstance(
- $field['drupal_field_type'],
- $field + ['mapping' => $this]
- );
+ if (!empty($this->field_mappings)) {
+ foreach ($this->field_mappings as $i => $field) {
+ $fields[$i] = $this->fieldManager()->createInstance(
+ $field['drupal_field_type'],
+ $field + ['mapping' => $this]
+ );
+ }
}
return $fields;
}
--
GitLab