Commit ebc16006 authored by Andrew Siz's avatar Andrew Siz Committed by Tim Rohaly
Browse files

Issue #3136840 by AndrewsizZ: Replace assertions involving calls to empty()... 

Issue #3136840 by AndrewsizZ: Replace assertions involving calls to empty() with assertEmpty()/assertNotEmpty()/assertArrayNotHasKey()
parent 8dd1c082

tests/src/FunctionalJavascript/EventBundleTest.php

+1 −1
Original line number Diff line number Diff line
@@ -111,7 +111,7 @@ class EventBundleTest extends WebDriverTestBase { 
      // should be no bundles and the bundle select should be hidden.

      $bundles = \Drupal::service('entity_type.bundle.info')->getBundleInfo('node');

      $assert->pageTextNotContains('Restrict by type');

      $assert->assert(empty($bundles), 'Restrict by type field is not shown and there are no bundles.');

      $assert->assertEmpty($bundles, 'Restrict by type field is not shown and there are no bundles.');

    }



    // Save the Reaction Rule with event "rules_entity_insert:node--article".

tests/src/Kernel/RulesUiEmbedTest.php

+1 −1
Original line number Diff line number Diff line
@@ -49,7 +49,7 @@ class RulesUiEmbedTest extends RulesKernelTestBase { 
    $definition = $this->rulesUiManager->getDefinitions();

    $this->assertArrayHasKey('rules_test_ui_embed.settings_conditions', $definition);

    $this->assertInstanceOf(RulesUiDefinition::class, $definition['rules_test_ui_embed.settings_conditions']);

    $this->assertTrue(!empty($definition['rules_test_ui_embed.settings_conditions']->label));

    $this->assertNotEmpty($definition['rules_test_ui_embed.settings_conditions']->label);

    $this->assertEquals(RulesUiConfigHandler::class, $definition['rules_test_ui_embed.settings_conditions']->getClass());

  }