>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3585521. --> Reported by: [mably](https://www.drupal.org/user/3375160) Related to !55 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>The <code>NotificationRequiredCondition</code> plugin (id <code>purge_users:notification_required</code>, labeled <em>Users pre-notified only</em>) is supposed to allow purging only for users who have received the pre-deletion notification. Today it is too permissive: it does an <code>INNER JOIN</code> on <code>purge_users_notifications</code> without filtering on the <code>type</code> column, so any row satisfies the condition &mdash; including rows with <code>type = 'purge_users'</code> written by <code>UserManagementService::notifyUserToPurge()</code> right before deletion.</p> <p>The <code>purge_users_notifications</code> table carries two <code>type</code> values:</p> <ul> <li><code>'notification_users'</code> &mdash; written by <code>notifyUser()</code>, the <em>pre-deletion heads-up</em>.</li> <li><code>'purge_users'</code> &mdash; written by <code>notifyUserToPurge()</code>, the last-minute mail sent at deletion time.</li> </ul> <p>Only the first type represents a "pre-notification", so only it should satisfy the <em>Users pre-notified only</em> condition.</p> <p>For reference, the global path <code>PurgeUsersHelper::checkNotification()</code> introduced by MR !51 on <a href="https://www.drupal.org/project/purge_users/issues/3521201">#3521201</a> already filters <code>-&amp;gt;condition('pun.type', 'notification_users')</code>. The condition path should match.</p> <h4 id="summary-steps-reproduce">Steps to reproduce</h4> <ol> <li>Create a policy with the <em>Users pre-notified only</em> condition.</li> <li>Seed a user with only a <code>'purge_users'</code> row in <code>purge_users_notifications</code> (no <code>'notification_users'</code> row).</li> <li>Run the purge. Observe: the user is purged even though they were never pre-notified.</li> </ol> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>In <code>src/Plugin/Condition/NotificationRequiredCondition.php</code>, extend the <code>innerJoin</code> predicate:</p> <pre><pre>$query-&amp;gt;innerJoin(<br>&nbsp; 'purge_users_notifications',<br>&nbsp; 'pun',<br>&nbsp; 'pun.uid = u.uid AND pun.timestamp &amp;lt; :delay AND pun.type = :type',<br>&nbsp; [':delay' =&amp;gt; $notification_delay, ':type' =&amp;gt; 'notification_users']<br>);</pre></pre><h3 id="summary-remaining-tasks">Remaining tasks</h3> <ul> <li>Add the type filter to the inner join.</li> <li>Add kernel coverage for the condition's behavior across the four <code>type</code>-combinations (only <code>notification_users</code>, only <code>purge_users</code>, both, none).</li> </ul> <h3 id="summary-ui-changes">User interface changes</h3> <p>None.</p> <h3 id="summary-api-changes">API changes</h3> <p>None.</p> <h3 id="summary-data-model-changes">Data model changes</h3> <p>None.</p> <h3>Related</h3> <ul> <li><a href="https://www.drupal.org/project/purge_users/issues/3521201">#3521201</a> &mdash; global path introducing <code>checkNotification()</code> with the type filter.</li> <li><a href="https://www.drupal.org/project/purge_users/issues/3585503">#3585503</a> &mdash; auto-flagging users with unsendable emails (relies on consistent condition semantics).</li> </ul>