GitLab

this fixes a regression introduced in d8554cf433ddb0b665e05b143a28fac429196535

before this patch, redirection virtual hosts were created with a duplicate ServerName, which seems to be working, but is needlessly confusing

after this patch, the redirection vhosts are created only based on the aliases provided and not the site_url

this implies that to do generic redirections (e.g. for SSL) you may need to push your site_url in the aliases array. that has been done in SSL so that all hosts (ie. aliases and the site_url) are redirected to the site_url, which is not appropriate for regular vhosts (because it would mean a infinite redirection loop)

overwrite the port 80 config if redirection + ssl is enabled, regardless of whether or not the file already exists

if we don't do that, the file is never re-written once it's been written once: bad.

this is to avoid the possibility of Denial of Service attacks from the drupal admins: if someone were to create a symlink in files/ that would point to the parent sites/ directory, the recursive chmod that happen on verify would loop inifinitely (i saw one running for 1h)

do not flush privileges: it's not required when you use GRANT/REVOKE, and requires unnecessary permissions

this was failing because provision_path_unlink was checking the file existence (file_exists) before removing the symlink. in this case, the file really *didn't* exist because the link target was already removed.

instead of checking, we just try to delete the file, if it fails, it will return false anyways.

we do the same with rmdir while we're here.

also make sure we work on the trimmed file path

The init and exit hooks were expecting to only be running on "provision *" commands, i modified them to run on "provision-*" commands instead.

changed all instances of drush_backend_invoke and drush_invoke to match
the new command names.

valid

first, it's not necessarily available. second, we have proper failure
modes anyways, so this check isn't useful

this way we can have the "aegir mysql root" user to be a bit more
restricted in his actions

Revert "initialize mysql credentials from drush bootstrap so that we can work on non-verified sites easily"

Provision is managing the master database connection here, drush's db credentials are the details for the SITE, and will only be available at drush_bootstrap_drupal_site.

we need the master db connection from drush_bootstrap_drush already, and we will never ever ever be able to make use of drush' code in this regard because what we are doing is completely outside of the Drupal context.

This reverts commit 5439e6d01d32fd7351c404a6bf74c11a028ee8a4.

raise backup bootstrap level to configuration so we load the settings file and therefore be able to backup existing, non-verified sites for easier import into aegir

we do it the proper way, by using site_exists(), not site_installed()

This breaks site creation: the site_id and other parameters are no
longuer saved in the drushrc after this patch is applied.

This reverts commit 5e9df86344397f47030e31840e14fb3c93c69b11.

change variable names to be more consequential, better docs of _provision_drupal_create_directories()