>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3631701. --> Reported by: [gábor hojtsy](https://www.drupal.org/user/4166) Related to !86 >>> <h3>Problem/Motivation</h3> <p>A template of a language, from <code>drush potx --language=xx</code> or from a language of the extraction form, has a <code>Plural-Forms</code> header. Currently, <code>PoLanguage::fromSite()</code> builds the header from two sources:</p> <ul> <li>The number of plural forms is from core, <code>PluralFormulaInterface::getNumberOfPlurals()</code>. Core has this number for a language after the import of a translation file. For a language without an import, the number is always 2.</li> <li>The plural formula is from <code>PoLanguage::PLURAL_FORMS</code>, a list of 39 languages of the gettext library.</li> </ul> <p>Currently:</p> <ul> <li>81 of the 118 languages of localize.drupal.org are not in the list. Their templates have the placeholder <code>nplurals=INTEGER; plural=EXPRESSION;</code>.</li> <li>The key of Portuguese, Brazil in the list is <code>pt_BR</code>, but its language code in Drupal is <code>pt-br</code>. Its templates also have the placeholder.</li> <li>For 5 languages of the list, the plural formula is different from the plural formula of localize.drupal.org, so the templates do not match the translation files of these languages: Czech, Irish, Japanese, Korean and Turkish.</li> <li>For a language without an import, the number of plural forms of the header is 2 with any plural formula of the list. For Russian, the header has <code>nplurals=2</code> with a plural formula of 3 plural forms.</li> <li>The plural formula of a language on the site is not used. With l10n_pconfig, the language form sets the plural formula of each language, also of custom languages (<span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/potx/-/work_items/3028920" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/potx/-/work_items/3028920</a></span>), and the plural formula can be changed there.</li> <li>Each change of a language is a separate issue for the list: <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/potx/-/work_items/3404056" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/potx/-/work_items/3404056</a></span>, <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/potx/-/work_items/3525791" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/potx/-/work_items/3525791</a></span>, <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/potx/-/work_items/3525822" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/potx/-/work_items/3525822</a></span>, <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/potx/-/work_items/3427108" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/potx/-/work_items/3427108</a></span>, and <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/potx/-/work_items/3620865" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/potx/-/work_items/3620865</a></span> for more languages.</li> <li>It is not a good idea to maintain multiple lists of plural formulas, we already have localize.drupal.org and l10n_pconfig trying to keep them in sync, so potx should not have yet another list. l10n_pconfig has the plural formulas of all the languages of localize.drupal.org, with the same plural forms (<span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/l10n_pconfig/-/work_items/3312406" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/l10n_pconfig/-/work_items/3312406</a></span>).</li> </ul> <h3>Steps to reproduce</h3> <ol> <li>Add the Russian language, without the import of translations.</li> <li>Run <code>drush potx --language=ru</code>.</li> <li>The header of the template has <code>nplurals=2; plural=(n%10==1 &amp;&amp; n%100!=11 ? 0 : n%10&gt;=2 &amp;&amp; n%10&lt;=4 &amp;&amp; (n%100&lt;10 || n%100&gt;=20) ? 1 : 2);</code>. The plural formula has the plural forms 0, 1 and 2.</li> </ol> <h3>Proposed resolution</h3> <ul> <li>potx should use the plural formulas of l10n_pconfig, with the API of <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/l10n_pconfig/-/work_items/3274209" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/l10n_pconfig/-/work_items/3274209</a></span>: the plural formula of the language, or the default plural formula of its language code for a language without one:<br> <pre>$formula = $plural_formula-&gt;getPluralFormula($langcode) ?? $plural_formula-&gt;getDefaultPluralFormula($langcode);</pre></li> <li>A plural formula of l10n_pconfig has the number of plural forms, like <code>nplurals=2; plural=(n != 1);</code>. The header should have this plural formula without changes, and the number of plural forms of the header should not be from core.</li> <li>l10n_pconfig should be optional: an optional argument of the <code>Potx</code> service, and a suggestion in <code>composer.json</code>. Without l10n_pconfig, and for a language code without a plural formula in l10n_pconfig, the header should have the placeholder <code>nplurals=INTEGER; plural=EXPRESSION;</code>.</li> <li><code>PoLanguage::PLURAL_FORMS</code> should be removed.</li> </ul> <p>Changed for sites without l10n_pconfig: currently, the templates of the languages of the list have a plural formula. With the change, they have the placeholder.</p> <p>Not changed: the export of translations (<code>TranslationExporter</code>) uses the number of plural forms of core for the translations.</p> <h3>Remaining tasks</h3> <ul> <li>Merge request with tests. <code>TemplateLanguageTest</code> should check a language with a plural formula on the site, a language with the default plural formula, and the placeholder without l10n_pconfig. l10n_pconfig should be a development dependency for the tests.</li> <li>After the commit: close <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/potx/-/work_items/3620865" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/potx/-/work_items/3620865</a></span>, <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/potx/-/work_items/3404056" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/potx/-/work_items/3404056</a></span>, <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/potx/-/work_items/3525791" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/potx/-/work_items/3525791</a></span>, <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/potx/-/work_items/3525822" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/potx/-/work_items/3525822</a></span>, <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/potx/-/work_items/3427108" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/potx/-/work_items/3427108</a></span> and <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/potx/-/work_items/3028920" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/potx/-/work_items/3028920</a></span>. Their plural formulas are in l10n_pconfig. For Catalan, l10n_pconfig has <code>(n &gt; 1)</code>, the plural formula of localize.drupal.org.</li> </ul> <h3>User interface changes</h3> <p>None.</p> <h3>API changes</h3> <p>The <code>Potx</code> service has a new optional argument: the plural formula service of l10n_pconfig. <code>PoLanguage</code> is internal.</p> <h3>Data model changes</h3> <p>None.</p> <h3>LLM disclosure</h3> <p>LLM was used to find, diagnose, explain and fix this issue. With human review.</p>