>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3618662. --> Reported by: [mably](https://www.drupal.org/user/3375160) Related to !76 !75 >>> <h3>Problem/Motivation</h3> <p>The next-major lane is green, and that green rests on 18 test classes skipping themselves through DependencyWithoutDrupal12Trait, which proves nothing about those classes on Drupal 12. Fourteen of them boot consumers, whose ConsumerListBuilder overrides EntityListBuilder::getOperations() without the CacheableMetadata argument core 12 requires; it fatals during entity-type discovery and takes the class down with it.</p> <p>The lenient composer plugin gets a project past composer and the module installer. It cannot make its code run. So skipping was the only honest option available at the time, and it leaves 153 test methods unexercised against the core this module now claims to support.</p> <h3>Proposed resolution</h3> <p>Patch consumers on the next-major lane only, through `_COMPOSER_PATCHES_FILE` scoped to the `composer (next major)` job, so the current lane keeps installing released dependencies untouched. The patch entry points at the closed MR !29 on consumers #3592591, where the three-line fix already lives, rather than carrying its own copy: the entry is then deleted the day the upstream issue lands, and until then it names exactly what it is waiting for.</p> <p>Measured on the same job, before and after: passing test methods 283 to 381, skipped 153 to 55, fully-skipped classes 18 to 4. The composer log shows the patch applying against the released consumers 1.24.0, and ConsumerListBuilder appears nowhere in the test log afterwards.</p> <p>This does not make consumers Drupal 12 compatible for anyone installing it normally. Only upstream can do that, and reopening consumers #3592591 is the actual fix; this makes the lane tell the truth about pdv's own code in the meantime.</p> <h3>Remaining tasks</h3> <p>webform keeps its four skips. Three of its plugin managers override getGroupedDefinitions() without the argument the core 12 CategorizingPluginManagerTrait adds (Handler, Variant and Element), so a patch has to cover all three: fixing only the one the fatal names moves the fatal to the next manager to load. No issue is filed upstream for it yet.</p> <p>Also drops drupal/message's annotated entity types into the existing ignored deprecation family. That only surfaces once DormancyMessageTest actually runs on the lane: it passes its three tests and failed the job on those two deprecations alone, which are removed in drupal:13.0.0 and are not this module's to fix.</p> <h3>User interface changes</h3> <p>None.</p> <h3>API changes</h3> <p>None. CI configuration and test gating only.</p> <h3>Update: the same treatment for webform</h3> <p>The consumers half landed in !75. !76 on this issue does the same for webform, which is what lets <code>DependencyWithoutDrupal12Trait</code> be deleted outright instead of kept for webform's four classes. Five upstream changes are needed, each filed with a merge request so the entry points at the diff rather than carrying a copy:</p> <ul> <li><span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-1"><a href="https://www.drupal.org/project/webform/issues/3618362" title="Status: Active">#3618362: Align definitions of getSortedDefinitions and getGroupedDefinitions with core</a></span> and its !928, for the <code>CategorizingPluginManagerTrait</code> signature core 12 tightened.</li> <li><span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-8"><a href="https://www.drupal.org/project/webform/issues/3618665" title="Status: Needs review">#3618665: webform_submission.exporter injects plugin.manager.archiver, which Drupal 12 removes</a></span> and its !929, for the <code>plugin.manager.archiver</code> service core 12 removes. This one accounted for the entire remaining failure: 55 errors, every one of them this service.</li> <li><span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-4"><a href="https://www.drupal.org/project/webform/issues/3618674" title="Status: Postponed">#3618674: The removed $entity-&gt;original magic property is still used in five places, breaking Drupal 12</a></span> and its !930, for the <code>$entity-&gt;original</code> magic property core 12 removes.</li> <li><span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-4"><a href="https://www.drupal.org/project/webform/issues/3537314" title="Status: Postponed">#3537314: file_get_content_headers() is deprecated in 11.2.0</a></span> and its !658, for the <code>file_get_content_headers()</code> function core 12 removes.</li> <li><span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-1"><a href="https://www.drupal.org/project/webform/issues/3618696" title="Status: Active">#3618696: Commit transactions explicitly instead of letting them go out of scope</a></span> and its !931, for committing a Transaction by letting it go out of scope, deprecated in 11.5 and removed in 13.0.</li> </ul> <p><code>phpunit (next major)</code> now reports 436 passing, 0 failures, 0 errors, 0 skips and 0 deprecations against core 12.x-dev. Before !76 the same job reported 381 passing and 55 errors, so the two figures account for each other exactly.</p> <p>The Transaction one is a 13.0 removal rather than 12.0, so it never affected the Drupal 12 claim. It deliberately carries no ignore pattern, so the lane proves it instead of hiding it.</p> <p>Each patch entry stops working when its upstream change lands, because the patch then no longer applies and <code>composer (next major)</code> fails. When webform ships a release carrying these fixes, the follow-up is to drop the webform entries and raise the webform floor in <code>composer.json</code>, not to restore the skip trait.</p> <p>AI-Generated: Yes (Claude Code was used to help draft this issue summary and to write the changes. I reviewed them. The approach was validated on a throwaway pipeline before this issue was filed: the patch applied against released consumers and the lane went green with the fourteen classes running, and the before/after counts above are read off the two job logs.)</p>