>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3612106. --> Reported by: [slucero](https://www.drupal.org/user/1612534) Related to !201 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>The phpstan-drupal package update on 2026-07-14 introduced new lint rules that flag 32 pre-existing code patterns in Patternkit. The 9.1.x branch <a href="https://git.drupalcode.org/project/patternkit/-/jobs/10925973">passed PHPStan on 2026-07-13</a> and now <a href="https://git.drupalcode.org/project/patternkit/-/jobs/10952944">fails with 32 errors</a>. None of the violations were introduced by any recent code change to 9.1.x.</p> <p>This is a contributor-facing regression: any MR opened against 9.1.x will fail PHPStan CI until this issue is resolved.</p> <p>The phpstan-drupal package update introduced rules in the following categories:</p> <ul> <li><code>drupal.entityStoragePropertyAssignment</code> (17 occurrences): entity storage stored as a class property instead of resolved at call site</li> <li><code>drupal.entityStorageDirectInjection</code> (5 occurrences): entity storage injected directly instead of via EntityTypeManager</li> <li><code>method.deprecatedClass</code> / <code>classConstant.deprecatedClass</code> (14 occurrences): references to <code>ReusableBlockHooks</code>, deprecated in 9.1.2</li> <li><code>return.type</code> (4 occurrences): return type mismatches in <code>PatternUsageManager</code></li> <li><code>dependencySerializationTraitProperty.unsupportedReadOnlyProperty</code> (1 occurrence): <code>readonly</code> property incompatible with <code>DependencySerializationTrait</code></li> <li><code>dependencySerializationTraitProperty.unsupportedPrivateProperty</code> (1 occurrence): private property incompatible with <code>DependencySerializationTrait</code></li> <li><code>nonAbstractTestClass.NameNoSuffixTest</code> (1 occurrence): test base class name lacks a <code>Test</code> suffix and is not abstract</li> <li>Other (3 occurrences): <code>staticMethod.deprecated</code>, <code>globalDrupalDependencyInjection.useDependencyInjection</code>, <code>encapsedStringPart.nonString</code></li> </ul> <p>The affected files span the main module and the patternkit_usage_tracking submodule. All violations are pre-existing. The new rules expose long-standing patterns rather than any new code.</p> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>Each violation category requires individual assessment before deciding between an inline fix or a justified baseline entry.</p> <p>The recommended approach:</p> <ol> <li>Fix violations that are safe and low-risk to correct inline. The deprecated <code>ReusableBlockHooks</code> references and the test class naming issue are good candidates.</li> <li>Baseline violations where the fix requires architectural changes that are outside the scope of a CI hotfix. The <code>entityStoragePropertyAssignment</code> patterns across 17 locations fall into this category.</li> <li>Document the rationale for each baseline entry in the phpstan baseline file so future contributors understand why the suppression exists.</li> <li>Open follow-up issues for baselined violations that represent real improvement opportunities.</li> </ol> <p>This keeps the CI unblocked while avoiding untested architectural changes being bundled into a hotfix.</p> <h3 id="summary-remaining-tasks">Remaining tasks</h3> <ul> <li>Assess each of the 32 violations and decide: fix inline or baseline with rationale</li> <li>Update the phpstan baseline file</li> <li>Verify PHPStan CI passes on 9.1.x</li> <li>Open follow-up issues for any baselined violations that warrant separate tracking</li> <li>Link any follow-up issues to this issue</li> </ul> <h3 id="summary-ui-changes">User interface changes</h3> <p>None.</p> <h3 id="summary-introduced-terminology">Introduced terminology</h3> <p>None.</p> <h3 id="summary-api-changes">API changes</h3> <p>None.</p> <h3 id="summary-data-model-changes">Data model changes</h3> <p>None.</p> <h3 id="summary-release-notes">Release notes snippet</h3> <p>PHPStan CI now passes on 9.1.x after updating the phpstan baseline to account for new rules introduced by the phpstan-drupal package update. Violations safe to fix inline were corrected; remaining violations were baselined with documented rationale and tracked in follow-up issues.</p>