>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3604089. --> Reported by: [slucero](https://www.drupal.org/user/1612534) Related to !196 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>Drupal core 11.4 added a <code>YamlCacheCollector</code> parameter to the <code>LibraryDiscoveryParser</code> constructor as part of <a href="https://www.drupal.org/node/3486503">#3486503</a> (change record: <a href="https://www.drupal.org/node/3593451">#3593451</a>). The new parameter replaces some uses of <code>FileCache</code> with a persistent <code>cache.file_parsing</code> bin backed by <code>FileParsingCacheCollectorBase</code>.</p> <p><code>PatternLibraryParserBase</code> extends <code>LibraryDiscoveryParser</code> and passes arguments through to <code>parent::__construct()</code>. On Drupal 11.4, the parent constructor expects <code>YamlCacheCollector</code> as an additional parameter. Without it, the container falls back to a deprecated service lookup that triggers a <code>ServiceNotFoundException</code> for <code>libraries.parsing_cache</code> in environments where the container is not fully available (unit tests, early bootstrap).</p> <p>On Drupal 10, the <code>YamlCacheCollector</code> class does not exist. The parameter type hint, <code>parent::__construct()</code> call arity, service definition, and PHPStan configuration must all remain compatible with both Drupal 10.3+ and 11.4+.</p> <p>Three issues surface from this change:</p> <ol> <li>The parent class <code>LibraryDiscoveryParser</code> stores the application root as <code>$this-&gt;root</code> in Drupal 10 via manual assignment, but Drupal 11.4 changes how this property is declared. <code>PatternLibraryParserBase</code> subclasses reference <code>$this-&gt;root</code> throughout. To maintain cross-version compatibility, the child class must declare its own <code>protected string $root</code> property and assign it explicitly in the constructor body rather than relying on constructor promotion or the parent's property declaration. The native type must not appear on the constructor parameter itself, or PHP emits a fatal error ("Type must not be defined") when the child's property conflicts with the parent's declaration.</li> <li>The <code>patternkit.asset.library.parser.base</code> service definition must pass the <code>library.parsing_cache</code> service so <code>YamlCacheCollector</code> reaches <code>parent::__construct()</code> on Drupal 11.4. The service reference must use the optional prefix (<code>@?library.parsing_cache</code>) so the container injects <code>NULL</code> on Drupal 10 where the service does not exist.</li> <li>PHPStan suppressions with <code>reportUnmatched: false</code> are needed for the cross-version type errors (<code>YamlCacheCollector</code> class not found, extra constructor parameter count). Unit test factories must conditionally create <code>YamlCacheCollector</code> mocks using <code>class_exists()</code> guards, following the same pattern already established for <code>ComponentPluginManager</code>.</li> </ol> <h4 id="summary-steps-reproduce">Steps to reproduce</h4> <ol> <li>Install Patternkit on Drupal 11.4.</li> <li>Clear caches (<code>drush cr</code>).</li> <li>Observe a PHP fatal error in <code>PatternLibraryParserBase::__construct()</code> related to the <code>$root</code> property type conflict, or a <code>ServiceNotFoundException</code> for <code>libraries.parsing_cache</code>.</li> <li>Alternatively, run <code>phpunit tests/src/Unit/</code> on a Drupal 11.4 environment and observe multiple <code>ServiceNotFoundException</code> failures.</li> </ol> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>Update <code>PatternLibraryParserBase</code> and its service definition for cross-version compatibility with both Drupal 10.3+ and 11.4+.</p> <h4>Constructor changes</h4> <p><code>src/Asset/PatternLibraryParserBase.php</code>:</p> <ul> <li>Remove the native type from the <code>$root</code> constructor parameter to avoid the PHP fatal error when the parent's property declaration differs across core versions.</li> <li>Add an explicit <code>protected $root</code> property declaration (untyped, matching the parent) and assign it in the constructor body. This preserves the <code>$this-&gt;root</code> references used by parser subclasses, independent of how the parent class stores the application root.</li> <li>Add a nullable <code>?YamlCacheCollector $yaml_cache_collector = NULL</code> parameter and pass it through to <code>parent::__construct()</code>.</li> <li>Add the <code>@param</code> docblock entry for the new parameter.</li> </ul> <h4>Service definition</h4> <p><code>patternkit.services.yml</code>:</p> <ul> <li>Add <code>@?library.parsing_cache</code> (optional service reference) to the <code>patternkit.asset.library.parser.base</code> abstract service arguments, positioned before the existing optional <code>@?plugin.manager.sdc</code> argument. The <code>@?</code> prefix injects <code>NULL</code> on Drupal 10 where the service does not exist, matching the established pattern.</li> </ul> <h4>PHPStan cross-version suppressions</h4> <p><code>phpstan.neon</code>:</p> <ul> <li>Suppress the invalid type error for <code>YamlCacheCollector</code> on Drupal 10 where the class does not exist.</li> <li>Suppress the "invoked with 8 parameters" error for <code>parent::__construct()</code> which only accepts 7 parameters on Drupal 10.</li> <li>Use <code>reportUnmatched: false</code> on both suppressions so they do not cause failures when running PHPStan against Drupal 11.4 where the types are valid.</li> </ul> <h4>Unit test compatibility</h4> <p><code>tests/src/Unit/Asset/PatternLibraryParser/PatternLibraryParserTestBase.php</code>:</p> <ul> <li>Add a <code>$yamlCacheCollector</code> property with a <code>class_exists(YamlCacheCollector::class)</code> guard in <code>setUpParserDependencies()</code>, following the existing pattern used for <code>$componentPluginManager</code>.</li> <li>Pass the mock (or <code>NULL</code>) to both <code>getParserInstance()</code> and <code>getPartialMock()</code> factory methods.</li> </ul> <h3 id="summary-remaining-tasks">Remaining tasks</h3> <ul> <li>Review and test the merge request.</li> <li>CI validation on both Drupal 10 and 11.4.</li> </ul> <h3 id="summary-ui-changes">User interface changes</h3> <p>None.</p> <h3 id="summary-introduced-terminology">Introduced terminology</h3> <p>None.</p> <h3 id="summary-api-changes">API changes</h3> <p><code>PatternLibraryParserBase::__construct()</code> gains a new nullable <code>?YamlCacheCollector</code> parameter before the existing optional <code>$componentPluginManager</code> parameter. Any code that instantiates a <code>PatternLibraryParserBase</code> subclass directly (rather than through the service container) must pass the new argument. In practice, all parser instances are created via <code>services.yml</code> and this change is transparent.</p> <h3 id="summary-data-model-changes">Data model changes</h3> <p>None.</p> <h3 id="summary-release-notes">Release notes snippet</h3> <p>Patternkit is now compatible with Drupal 11.4. The <code>PatternLibraryParserBase</code> constructor has been updated to accept the new <code>YamlCacheCollector</code> service introduced in Drupal core 11.4 (<a href="https://www.drupal.org/node/3486503">#3486503</a>) while remaining backward compatible with Drupal 10.3+. Sites upgrading to Drupal 11.4 should update Patternkit to this release to avoid PHP fatal errors during cache rebuilds.</p>