>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3597150. --> Reported by: [slucero](https://www.drupal.org/user/1612534) >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>Patternkit currently supports Drupal 10.3 and Drupal 11. With the 9.2.0 release targeting Drupal 11 exclusively, maintaining Drupal 10 compatibility requires carrying several workarounds that add noise to the codebase, suppress static analysis warnings, and prevent adoption of cleaner Drupal 11 APIs.</p> <p>Known compatibility burdens:</p> <ul> <li><code>core_version_requirement: ^10.3 || ^11</code> in <code>patternkit.info.yml</code>; <code>^10 || ^11</code> in all submodule <code>.info.yml</code> files.</li> <li><code>drupal/core-recommended</code> and <code>drupal/core-dev</code> pinned to <code>^10.3 || ^11</code> in <code>composer.json</code>.</li> <li><code>symfony/polyfill-php84: ^1.31</code> in <code>composer.json</code> <code>require</code> &mdash; included to cover the PHP 8.4 compatibility gap in Drupal 10's Symfony version.</li> <li><code>\PDO::FETCH_ASSOC</code> passed to <code>fetchAll()</code> in <code>ValidityStampWriter</code> (three call sites) and <code>fetchField()</code> / <code>fetchAssoc()</code> calls elsewhere &mdash; superseded by the <code>Drupal\Core\Database\FetchAs</code> enum in Drupal 11; using the old form generates deprecation notices and requires <code>// @phpstan-ignore</code> suppressors.</li> <li><code>#[LegacyHook]</code> attributes on every procedural hook wrapper in <code>patternkit.module</code> &mdash; prevents duplicate execution when both a procedural function and an OOP <code>#[Hook]</code> class method are registered; unnecessary in Drupal 11.</li> <li><code>// @phpstan-ignore method.deprecated</code> in <code>PatternDiscoveryLoader</code> guarding a call deprecated in Drupal 10.</li> </ul> <p>A full module audit may surface additional workarounds not listed here.</p> <h4>Steps to reproduce</h4> <p>Not applicable. This is a planned cleanup task targeting the 9.2.0 release.</p> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <h4>Known changes</h4> <ol> <li>Update <code>core_version_requirement</code> to <code>^11</code> in <code>patternkit.info.yml</code> and all submodule <code>.info.yml</code> files.</li> <li>Update <code>composer.json</code> require-dev constraints for <code>drupal/core-recommended</code> and <code>drupal/core-dev</code> to <code>^11</code>.</li> <li>Remove <code>symfony/polyfill-php84</code> from <code>composer.json</code> <code>require</code> after confirming it is unused in module code.</li> <li>Replace <code>\PDO::FETCH_ASSOC</code> arguments and any remaining PDO-constant-based fetch calls with <code>FetchAs</code> enum equivalents.</li> <li>Convert <code>patternkit.module</code> hook wrappers to native <code>#[Hook]</code> attribute declarations on the OOP hook classes, removing the procedural functions and <code>#[LegacyHook]</code> bridge.</li> <li>Remove the <code>// @phpstan-ignore method.deprecated</code> suppressor in <code>PatternDiscoveryLoader</code> after the underlying call site is updated.</li> <li>Update the CI matrix to test against Drupal 11 only.</li> </ol> <h4>Open considerations</h4> <ul> <li><strong><code>patternkit.module</code> file fate</strong> &mdash; once procedural hooks are removed, the only remaining function is <code>patternkit_rebuild()</code>, which has no current OOP equivalent. Determine whether to move <code>hook_rebuild</code> to an OOP implementation and delete the file, or retain the file with only that function.</li> <li><strong><code>symfony/polyfill-php84</code> audit</strong> &mdash; confirm no module code directly depends on the polyfill before removing.</li> <li><strong>Drupal 11 minimum minor</strong> &mdash; evaluate whether targeting a specific Drupal 11 minor (e.g., <code>^11.1</code> or <code>^11.2</code>) is warranted to take advantage of APIs unavailable in 11.0, or whether <code>^11</code> is the correct floor.</li> <li><strong>PHPUnit suite audit</strong> &mdash; review the test suite for any Drupal 10-specific test coverage, skips, or version guards that can be removed or simplified.</li> <li><strong>Rector configuration and compliance</strong> &mdash; configure <code>rector/rector</code> and <code>palantirnet/drupal-rector</code> for the Drupal 11 target, run a full automated refactor pass, and address any findings that Rector flags but cannot auto-apply. Integrate Rector into the CI pipeline as an ongoing compliance gate.</li> <li><strong>Full module audit</strong> &mdash; conduct a systematic review of all module PHP, YAML, and configuration files for any remaining Drupal 10 workarounds, compatibility shims, or conditional logic not covered above.</li> </ul> <h3 id="summary-remaining-tasks">Remaining tasks</h3> <ul> <li>Conduct full module audit for additional Drupal 10 workarounds.</li> <li>Resolve open considerations above.</li> <li>Review and test the merge request.</li> <li>CI validation.</li> </ul> <h3 id="summary-ui-changes">User interface changes</h3> <p>None.</p> <h3 id="summary-introduced-terminology">Introduced terminology</h3> <p>None.</p> <h3 id="summary-api-changes">API changes</h3> <p>The <code>core_version_requirement</code> minimum is raised to <code>^11</code>. Sites running Drupal 10 must remain on the 9.1.x branch.</p> <h3 id="summary-data-model-changes">Data model changes</h3> <p>None.</p> <h3 id="summary-release-notes">Release notes snippet</h3> <p>Patternkit 9.2.0 drops support for Drupal 10. The minimum required Drupal core version is now 11.0.0. Sites running Drupal 10 should remain on the 9.1.x branch, which will continue to receive security coverage according to the project's support policy. As part of this change, procedural hook wrappers in <code>patternkit.module</code> are removed in favor of native Drupal 11 OOP hook declarations, and the database fetch API is updated to use the <code>FetchAs</code> enum introduced in Drupal 11.</p>