>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3339014. --> Reported by: [slucero](https://www.drupal.org/user/1612534) Related to !64 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>When a Patternkit block is rendered on a page, it attaches cache tags for the associated block entity and the pattern entity being referenced. This is intentional and correct since it describes the content being rendered and allows for it to be targeted when changes affecting it should invalidate associated cache entries. The issue comes in instead with these related entities being saved at the wrong time causing a premature invalidation of all associated cache entries.</p> <p>The current implementation of the Patternkit blocks saves these associated entities whenever the block form is submitted. This save triggers Drupal's default entity behaviors to invalidate the cache tags for those entities immediately. When used in Layout Builder, and likely other scenarios, this can result in the cache tags for a pattern and/or block being invalidated during the layout editing process before the changes to the layout are ever published. Since the pattern entity is also updated, any other pages that may render different blocks based on the same pattern entity would have their cache entries invalidated as well despite the specific revision they reference not being affected.</p> <p>As an example, suppose two Nodes exist. Each is using Layout Builder and has an overridden layout set for it containing the Patternkit Example pattern. At this point the rendered cache entries for each node contain cache tags for the separate Patternkit Block entities and the same Pattern entity.</p> <p>Assume now an editor edits the layout for Node 1, edits the content for the Patternkit Example block, and submits the form. They have not saved the layout yet, so no changes to the rendered content on the published Node would be visible yet. However, once the block form was submitted, a new revision of the Patternkit Block entity was created and saved which triggered invalidation of the rendered output of Node 1. The Patternkit Example Pattern entity was also saved despite there being no changes to reflect which results in the cache entries for both the rendered content of Node 1 and Node 2 being invalidated since both contain a block using that pattern.</p> <p>Ideally, in this scenario, no rendered output caches should have been invalidated until the complete layout was saved. At this point, only the rendered content for Node 1 should have been invalidated since there were no changes to the Pattern entity that should cause the content for Node 2 to change.</p> <h4 id="summary-steps-reproduce">Steps to reproduce</h4> <h5>Initial Setup</h5> <p>These steps are intended to test the initial setup for the test scenarios and confirm cache tags are represented as expected after initial content creation.</p> <ul> <li>Install the following modules: Patternkit, Patternkit Example, Layout Builder</li> <li><a href="https://www.drupal.org/docs/drupal-apis/render-api/cacheability-of-render-arrays#headers">Enable cache header output</a></li> <li>Enable Layout Builder with page-specific overrides on a content type</li> <li>Create and save a new page (Page 1)</li> <li>Edit the layout for this page and place a new "[Patternkit] Example" block</li> <li>Save the layout</li> <li>In an incognito window, navigate to Page 1 and view the cache headers: <ul> <li>Expect to see a cache miss and the following cache tags included: <ul> <li>"pattern:@patternkit/atoms/example/src/example"</li> <li>"patternkit_block:1" (The number may vary if this is not a fresh installation.)</li> <li>"patternkit_pattern:1" (The number may vary if this is not a fresh installation.)</li> </ul> </li> </ul> </li> <li>In the original window, create and save a new page (Page 2)</li> <li>Edit the layout for this page and place a new "[Patternkit] Example" block, saving the layout</li> <li>In an incognito window, navigate to Page 2 and inspect the cache headers: <ul> <li>Expect to see a cache miss and the following cache tags included: <ul> <li>"pattern:@patternkit/atoms/example/src/example"</li> <li>"patternkit_block:2" (The number may vary if this is not a fresh installation.)</li> <li>"patternkit_pattern:1" (The number may vary if this is not a fresh installation.)</li> </ul> </li> </ul> </li> </ul> <h5>Block Editiing</h5> <p>These steps are intended to verify the cache invalidation behavior during typical block editing processes.</p> <ul> <li>Edit the layout for Page 1</li> <li>Edit the example block already on the page</li> <li>Change some field content and submit the block form (Do not save the layout yet) <ul> <li><em>At this point, the changed content should be visible on the layout preview screen.</em></li> </ul> </li> <li><strong>In an incognito window,</strong> view the published version of Page 1: <ul> <li>Expect to see the unedited block content and a cache hit for the page</li> </ul> </li> <li>In the original tab, save the updated block layout. <ul> <li>Expect to see the changed content on the published view of Page 1</li> <li>Expect to see a cache miss for the page</li> </ul> </li> <li>In an incognito window, view the published view of Page 2: <ul> <li>Expect to see a cache hit for the page</li> </ul> </li> </ul> <h5>Pattern Updating</h5> <p>These steps should cover validation of caching behaviors when the underlying Patterns for these blocks are updated. Unfortunately, triggering the update process for a Pattern within a block isn't possible through the UI, so testing this only through the browser isn't currently possible. The hash for the pattern may be edited directly in the database which would enable the update process through the UI if this is an option in the testing environment. The following steps assume this or a similar change has been implemented to trigger the detection of an available pattern update for the "[Patternkit] Example" pattern.</p> <ul> <li>As an editor, edit the layout for Page 1</li> <li>Edit the example block placed on the page previously</li> <li>Expect to see a prompt to update the block to the latest version</li> <li>In a separate tab, edit the layout and block for Page 2</li> <li>Expect to see a prompt to update the block to the latest version</li> <li>In the original tab for Page 1, click the "Update pattern" button</li> <li>Submit the block form</li> <li>In a separate tab, view Page 1</li> <li>Expect to see a cache hit</li> <li>In the same tab, view Page 2</li> <li>Expect to see a cache hit</li> <li>In the original tab, save the layout for Page 1</li> <li>Expect to see a cache miss for Page 1</li> <li>View the published view of Page 2</li> <li>Expect to see a cache hit</li> <li>Edit the layout and example block for Page 2</li> <li>Expect to see a prompt to update the pattern</li> </ul> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>Mimic the update and save solution used by Inline Blocks provided by the Layout Builder module to serialize content updates in blocks and defer entity updates (and related cache invalidations) until the layout and entity are saved.</p> <h3 id="summary-remaining-tasks">Remaining tasks</h3> <h3 id="summary-ui-changes">User interface changes</h3> <p>None.</p> <h3 id="summary-api-changes">API changes</h3> <ul> <li>Patternkit Block config schema now includes a <code>block_serialized</code> string value to capture unsaved content changes to blocks</li> <li>Pattern name cache tags (like <code>pattern:@patternkit/atoms/example/src/example</code>) are only invalidated now when an existing pattern is updated <strong>and</strong> marked as the default revision</li> <li>Updates to patternkit blocks in Layout Builder are saved in the new <code>serialized_block</code> value until a layout is saved instead of being saved immediately when a block form is submitted</li> <li>New entity insert and update hooks use the new <code>PatternkitBlockEntityOperations</code> service to save patternkit block and pattern entity updates when an entity using a layout containing them is saved</li> <li>When a Pattern entity is updated through the block edit form, a new revision of it is saved and referenced from the updated block configuration. However, this new revision is not marked as the default revision until the layout is saved at which time the <code>PatternkitBlockEntityOperations</code> service resaves the Pattern entity as the default revision triggering invalidation of the related Pattern entity cache tags.</li> </ul> <h3 id="summary-data-model-changes">Data model changes</h3> <ul> <li>Patternkit Block config schema now includes a <code>block_serialized</code> string value to capture unsaved content changes to blocks</li> </ul>