Commit 34d606fa authored by Benji Fisher's avatar Benji Fisher Committed by Sascha Grossenbacher
Browse files

Issue #3293221 by Berdir, benjifisher, S_Bhandari, Ada Hernandez: D10:... 

Issue #3293221 by Berdir, benjifisher, S_Bhandari, Ada Hernandez: D10: ModuleHandler::getImplementations() deprecation
parent 0bb2e942

src/AliasUniquifier.php

+13 −1
Original line number Diff line number Diff line
@@ -119,7 +119,19 @@ class AliasUniquifier implements AliasUniquifierInterface { 
      $source,

      $langcode,

    ];

    if (method_exists($this->moduleHandler, 'invokeAllWith')) {

      $implementations = [];

      $this->moduleHandler->invokeAllWith(

        'pathauto_is_alias_reserved',

        function (callable $hook, string $module) use (&$implementations) {

          $implementations[] = $module;

        }

      );

    }

    else {

      // Use the deprecated getImplementations() for Drupal < 9.4.

      $implementations = $this->moduleHandler->getImplementations('pathauto_is_alias_reserved');

    }

    foreach ($implementations as $module) {



      $result = $this->moduleHandler->invoke($module, 'pathauto_is_alias_reserved', $args);

tests/src/FunctionalJavascript/PathautoUiTest.php

+6 −3
Original line number Diff line number Diff line
@@ -140,7 +140,8 @@ class PathautoUiTest extends WebDriverTestBase { 
    $session->getPage()->find('css', '.dropbutton-toggle > button')->press();

    $this->clickLink('Edit');

    $destination_query = ['query' => ['destination' => Url::fromRoute('entity.pathauto_pattern.collection')->toString()]];

    $this->assertSession()->addressEquals('/admin/config/search/path/patterns/page_pattern', $destination_query);

    $address = Url::fromRoute('entity.pathauto_pattern.edit_form', ['pathauto_pattern' => 'page_pattern'], [$destination_query]);

    $this->assertSession()->addressEquals($address);

    $this->assertSession()->fieldValueEquals('pattern', '[node:title]');

    $this->assertSession()->fieldValueEquals('label', 'Page pattern');

    $this->assertSession()->checkboxChecked('edit-status');
@@ -185,7 +186,8 @@ class PathautoUiTest extends WebDriverTestBase { 
    $this->drupalGet('/admin/config/search/path/patterns');

    $this->assertSession()->linkNotExists('Disable');

    $this->clickLink('Enable');

    $this->assertSession()->addressEquals('/admin/config/search/path/patterns/page_pattern/enable', $destination_query);

    $address = Url::fromRoute('entity.pathauto_pattern.enable', ['pathauto_pattern' => 'page_pattern'], [$destination_query]);

    $this->assertSession()->addressEquals($address);

    $this->submitForm([], 'Enable');

    $this->assertSession()->pageTextContains('Enabled pattern Test.');
@@ -197,7 +199,8 @@ class PathautoUiTest extends WebDriverTestBase { 
    $this->drupalGet('/admin/config/search/path/patterns');

    $session->getPage()->find('css', '.dropbutton-toggle > button')->press();

    $this->clickLink('Delete');

    $this->assertSession()->addressEquals('/admin/config/search/path/patterns/page_pattern/delete', $destination_query);

    $address = Url::fromRoute('entity.pathauto_pattern.delete_form', ['pathauto_pattern' => 'page_pattern'], [$destination_query]);

    $this->assertSession()->addressEquals($address);

    $this->assertSession()->pageTextContains('This action cannot be undone.');

    $this->submitForm([], 'Delete');

    $this->assertSession()->pageTextContains('The pathauto pattern Test has been deleted.');