Issue #3177867 by MegaChriz: Adding a 'Paragraphs' field to a Feed's mapping throws error

composer.json

@@ -17,6 +17,7 @@
     "drupal/block_field": "1.x-dev",
     "drupal/entity_browser": "2.x-dev",
     "drupal/entity_usage": "2.x-dev",
-    "drupal/search_api": "^1"
+    "drupal/search_api": "^1",
+    "drupal/feeds": "^3"
   }
 }

src/Feeds/Target/Paragraphs.php

@@ -104,18 +104,23 @@ class Paragraphs extends Text implements ConfigurableTargetInterface {
    * {@inheritdoc}
    */
   public function getSummary() {
-    $summary = $this->t('Not yet configured.');
+    $summary = parent::getSummary();
+
     $paragraphs_type_id = $this->configuration['paragraphs_type'];
     $paragraph_field_name = $this->configuration['paragraph_field'];
     if ($paragraphs_type_id && $paragraphs_type = $this->paragraphsTypeStorage->load($paragraphs_type_id)) {
       if ($paragraph_field_name && $paragraph_field = $this->fieldConfigStorage->load('paragraph.' . $paragraphs_type_id . '.' . $paragraph_field_name)) {
-        $summary = $this->t('Using the %field field on a %type paragraph.', [
+        $summary[] = $this->t('Using the %field field on a %type paragraph.', [
           '%field' => $paragraph_field->label(),
           '%type' => $paragraphs_type->label(),
         ]);
       }
     }
-    return $summary . '<br>' . parent::getSummary();
+    else {
+      $summary[] = $this->t('Not yet configured.');
+    }
+
+    return $summary;
   }
 
   /**

tests/src/Functional/Feeds/Target/ParagraphsTest.php

+<?php
+
+namespace Drupal\Tests\paragraphs\Functional\Feeds\Target;
+
+use Drupal\Tests\feeds\Functional\FeedsBrowserTestBase;
+use Drupal\Tests\paragraphs\FunctionalJavascript\ParagraphsTestBaseTrait;
+
+/**
+ * Tests the FeedsTarget plugin "paragraphs" in the UI.
+ *
+ * @group paragraphs
+ */
+class ParagraphsTest extends FeedsBrowserTestBase {
+
+  use ParagraphsTestBaseTrait;
+
+  /**
+   * Modules to enable.
+   *
+   * @var string[]
+   */
+  protected static $modules = [
+    'feeds',
+    'node',
+    'paragraphs',
+  ];
+
+  /**
+   * The feed type entity.
+   *
+   * @var \Drupal\feeds\Entity\FeedType
+   */
+  protected $feedType;
+
+  /**
+   * {@inheritdoc}
+   */
+  public function setUp(): void {
+    parent::setUp();
+
+    // Add a Paragraph field to the article content type.
+    $this->addParagraphsField('article', 'field_paragraphs', 'node');
+
+    $this->addParagraphsType('test_paragraph');
+    $this->addFieldtoParagraphType('test_paragraph', 'field_text', 'text');
+
+    // Create a feed type.
+    $this->feedType = $this->createFeedType();
+  }
+
+  /**
+   * Tests adding mapping to a paragraph field.
+   */
+  public function testAddMapping() {
+    $this->drupalGet('admin/structure/feeds/manage/' . $this->feedType->id() . '/mapping');
+    $edit = [
+      'add_target' => 'field_paragraphs',
+    ];
+    $this->submitForm($edit, 'Save');
+
+    // And try to configure it.
+    $edit = [];
+    $this->submitForm($edit, 'target-settings-2');
+
+    // Select paragraphs type.
+    $edit = [
+      'mappings[2][settings][paragraphs_type]' => 'test_paragraph',
+    ];
+    $this->submitForm($edit, 'target-save-2');
+
+    // Configure again to select field.
+    $edit = [];
+    $this->submitForm($edit, 'target-settings-2');
+
+    // Select paragraphs field.
+    $edit = [
+      'mappings[2][settings][paragraph_field]' => 'field_text',
+    ];
+    $this->submitForm($edit, 'target-save-2');
+
+    // Set a source and save mappings.
+    $edit = [
+      'mappings[2][map][value][select]' => 'content',
+    ];
+    $this->submitForm($edit, 'Save');
+
+    // Assert expected mapping configuration.
+    $this->feedType = $this->reloadEntity($this->feedType);
+    $saved_mappings = $this->feedType->getMappings();
+    $expected_mapping = [
+      'target' => 'field_paragraphs',
+      'map' => [
+        'value' => 'content',
+      ],
+      'settings' => [
+        'paragraphs_type' => 'test_paragraph',
+        'paragraph_field' => 'field_text',
+        'language' => '',
+        'format' => 'plain_text',
+      ],
+    ];
+    $this->assertEquals($expected_mapping, $saved_mappings[2]);
+  }
+
+}

tests/src/Kernel/Feeds/Target/ParagraphsTest.php

+<?php
+
+namespace Drupal\Tests\paragraphs\Kernel\Feeds\Target;
+
+use Drupal\node\Entity\Node;
+use Drupal\paragraphs\Entity\Paragraph;
+use Drupal\Tests\feeds\Kernel\FeedsKernelTestBase;
+use Drupal\Tests\paragraphs\FunctionalJavascript\ParagraphsTestBaseTrait;
+
+/**
+ * @coversDefaultClass \Drupal\paragraphs\Feeds\Target\Paragraphs
+ * @group paragraphs
+ */
+class ParagraphsTest extends FeedsKernelTestBase {
+
+  use ParagraphsTestBaseTrait;
+
+  /**
+   * Modules to enable.
+   *
+   * @var string[]
+   */
+  protected static $modules = [
+    'field',
+    'feeds',
+    'node',
+    'entity_reference_revisions',
+    'paragraphs',
+    'file',
+    'text',
+  ];
+
+  /**
+   * The feed type.
+   *
+   * @var \Drupal\feeds\FeedTypeInterface
+   */
+  protected $feedType;
+
+  /**
+   * {@inheritdoc}
+   */
+  public function setUp(): void {
+    parent::setUp();
+
+    $this->installEntitySchema('paragraph');
+
+    // Create feed type.
+    $this->feedType = $this->createFeedTypeForCsv([
+      'guid' => 'guid',
+      'title' => 'title',
+      'alpha' => 'alpha',
+    ]);
+
+    // Add a Paragraph field to the article content type.
+    $this->addParagraphsField('article', 'field_paragraphs', 'node');
+
+    $this->addParagraphsType('test_paragraph');
+    $this->addFieldtoParagraphType('test_paragraph', 'field_text', 'text');
+
+    drupal_flush_all_caches();
+  }
+
+  /**
+   * Tests importing from a timestamp.
+   */
+  public function testImportParagraph() {
+    $this->feedType->addMapping([
+      'target' => 'field_paragraphs',
+      'map' => ['value' => 'alpha'],
+      'settings' => [
+        'paragraphs_type' => 'test_paragraph',
+        'paragraph_field' => 'field_text',
+        'language' => '',
+        'format' => 'plain_text',
+      ],
+    ]);
+    $this->feedType->save();
+
+    // Import.
+    $feed = $this->createFeed($this->feedType->id(), [
+      'source' => $this->resourcesPath() . '/csv/content.csv',
+    ]);
+    $feed->import();
+
+    // Assert two created nodes with paragraphs.
+    $this->assertNodeCount(2);
+
+    $expected = [
+      1 => 'Lorem',
+      2 => 'Ut wisi',
+    ];
+    foreach ($expected as $nid => $value) {
+      // Load the node and then the paragraph.
+      $node = Node::load($nid);
+      $paragraph = Paragraph::load($node->field_paragraphs->target_id);
+
+      $this->assertEquals($value, $paragraph->field_text->value);
+    }
+  }
+
+}