>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3624520. --> Reported by: [mably](https://www.drupal.org/user/3375160) Related to !523 >>> <h3>The tests</h3> <p>Ten test classes read project files and assert something about the words in them, or test a script in <code>scripts/</code>. None of them exercises the module. They walk the whole project on every run, and they had accumulated to the point where the Unit suite spent 12,306 assertions and over three seconds on them.</p> <ul> <li><code>DocumentedSurfaceTest</code>, 21 tests: documentation prose rules.</li> <li><code>TranslationCheckTest</code>, 17 tests: the behaviour of <code>scripts/check-translations.inc</code>.</li> <li><code>MetricsTestCountingTest</code>, 6, and <code>MetricsWriteTest</code>, 2: the behaviour of <code>scripts/generate-metrics.inc</code>.</li> <li><code>CatalogTerminologyTest</code>, 6 tests: French wording.</li> <li><code>HouseVocabularyTest</code>, 3 tests: the word "memo", and where <code>@count</code> may appear.</li> <li><code>DocblockReferenceTest</code>, 2, and <code>DocblockNullabilityTest</code>, 1: docblock wording.</li> <li><code>ParameterNamingTest</code>, 1 test: a naming convention.</li> <li><code>TemplateTranslationsTest</code>, 1 test: that no shipped template carries a French HTML body.</li> </ul> <p>With them go <code>TranslationCheckTrait</code> and a README-scanning test in <code>OrchestraAuditTrailSubscriberTest</code>. The <code>translations</code> CI job already reports a missing translation, which is what most of these were circling.</p> <p>The Unit suite goes from 143 tests and 12,306 assertions to 93 and 2,513, and from 3.21 seconds to 0.78.</p> <h3>What stays</h3> <p>Ten classes that also read files are kept, because each states a rule about the code or about something a person hits rather than about prose: the WCAG contrast check, table captions, the initiator lookup cost, guarded row updates invalidating their caches, the absence of upgrade hooks, resolver priorities, shipped configuration enforced on its module, plugin families covered by the dependency walk, menu links rooting into admin, and no prebuilt logger channel being injected.</p> <p>Three tests inside those are dropped too, for asserting nothing a reader could reach: one that checked a table of stylesheets still names files that exist (the completeness guard beside it fails on the same rename), one about an empty <code>post_update.php</code> that nobody ships, and a positive control restating what the file collector already asserts.</p> <p>The two kept guards that matter most were checked by mutation rather than by reading: darkening a card color to <code>#9a9a9a</code> is reported as 2.81:1 against the 4.5:1 AA asks, and renaming a real <code>#caption</code> key is reported as a table with no caption.</p> <h3>Two French strings</h3> <p>Folded in because they are the same shape of problem, a catalog left behind by a rename. The capability-link doorway's status report line is titled <em>Orchestra request limits</em>, and its French still read <em>Limites de requetes de l'interaction Orchestra</em>. And <code>orchestra_views</code> rendered <em>the workflow's read access</em> as <em>la portee de consultation du workflow</em>, where <em>portee</em> is the scope word the ReadScope to ReadAccess rename retired and the other catalogs use <em>acces en lecture</em>.</p> <h3>User interface changes</h3> <p>A French site reads the same status report title as an English one, and the Views column description names read access the way the rest of the interface does.</p> <p>AI-Generated: Yes (Claude Code was used to help draft this issue summary and to write the code on the merge request. I reviewed and ran the work myself before posting it.)</p>