## Problem Two allow-failure jobs are red on every 6.0.x pipeline, for example on [pipeline 1044319](https://git.drupalcode.org/issue/o365-3622512/-/pipelines/1044319) of !66 and on the 6.0.x pipeline after that merge: - `upgrade status` (job 13590519) - `phpunit (next minor)` (job 13590516, Drupal 11.5.x-dev) None of the findings come from a recent merge request. They are deprecations in code that has been on 6.0.x since 6.0.0, plus the known Drupal 12 blockers. ## Findings | Finding | Where | Fixable now | |---|---|---| | `Request::get()` deprecated since Symfony 7.4, 9 calls | `modules/o365_sso/src/Controller/LoginCallbackController.php` 96, 97, 112; `src/AuthenticationService.php` 251, 263–266, 348 | Yes | | `o365_requirements()` without `#[LegacyRequirementsHook]` (deprecated in 11.3, removed in 13) | `o365.install` | Yes | | `module_set_weight()` deprecated in 11.5, 5 calls | `o365.install` (install + update 8002), `modules/o365_sso/o365_sso.install` (install + update 9001), `modules/o365_sso_user/o365_sso_user.install` | With a version guard only: the `ModuleWeight` service exists from 11.5 | | `@ConfigEntityType` annotation on `o365_connector` | `src/Entity/O365Connector.php` | No: the `ConfigEntityType` attribute exists only in Drupal 11 | | `@FieldType` annotation on `sharepoint_search_link` | `modules/o365_sharepoint_field/src/Plugin/Field/FieldType/SharePointSearchItem.php` | Only after raising `core_version_requirement` to `^10.3` (attribute added in 10.3) | | `@EntityType` annotation on `oauth2_client` | oauth2_client 4.2.0 itself | No: upstream | | `core_version_requirement: ^10.2 \|\| ^11` not Drupal 12 compatible, all info.yml files and `composer.json` | everywhere | No: blocked by `microsoft/microsoft-graph` 1.x needing Guzzle 7 while core 12 needs `guzzlehttp/psr7` ^3 | ## Proposed changes 1. Replace every `$request->get('name')` with `$request->query->get('name')`. All nine reads are OAuth callback and token parameters that only ever arrive in the query string. Drop the matching `ignoreErrors` entry from `phpstan.neon` in the same commit. 2. Add `#[LegacyRequirementsHook]` to `o365_requirements()`. PHP ignores an attribute whose class does not exist, so Drupal 10 keeps working without a guard. 3. Replace `module_set_weight()` with `DeprecationHelper::backwardsCompatibleCall(\Drupal::VERSION, '11.5.0', fn () => \Drupal::service(ModuleWeight::class)->set(...), fn () => module_set_weight(...))` at all five call sites, or decide to leave it until Drupal 10 support is dropped, which is what the comment in `phpstan.neon` currently says. Either way, update that comment. 4. Leave the annotation and Drupal 12 findings out of scope. The entity type attribute and the Drupal 12 constraint wait for the Drupal 10 drop and the Graph SDK upgrade; the `FieldType` attribute waits for a decision on `^10.3`. After 1 and 2 the `upgrade status` job only reports the Drupal 12 constraint, and the `phpunit (next minor)` job only reports the deprecations we cannot fix yet. ## Checklist - [ ] `Request::get()` replaced, phpstan ignore removed - [ ] `#[LegacyRequirementsHook]` added - [ ] Decision on `module_set_weight()` recorded in `phpstan.neon` - [ ] `ddev pipeline o365` green locally - [ ] Pipeline on the MR: only the known Drupal 12 and annotation findings remain