>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3300328. --> Reported by: [seanb](https://www.drupal.org/user/545912) >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>There are several issues reported regarding content moderation, translations and cron.<br> <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/node_revision_delete/-/work_items/3118464" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/node_revision_delete/-/work_items/3118464</a></span><br> <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/node_revision_delete/-/work_items/3262901" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/node_revision_delete/-/work_items/3262901</a></span><br> <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/node_revision_delete/-/work_items/3262899" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/node_revision_delete/-/work_items/3262899</a></span><br> <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/node_revision_delete/-/work_items/3127816" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/node_revision_delete/-/work_items/3127816</a></span><br> <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/node_revision_delete/-/work_items/3217675" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/node_revision_delete/-/work_items/3217675</a></span><br> <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/node_revision_delete/-/work_items/3197664" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/node_revision_delete/-/work_items/3197664</a></span><br> <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/node_revision_delete/-/work_items/3269165" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/node_revision_delete/-/work_items/3269165</a></span><br> <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/node_revision_delete/-/work_items/3268323" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/node_revision_delete/-/work_items/3268323</a></span></p> <p>Just found <a href="https://www.drupal.org/project/node_revision_limit">https://www.drupal.org/project/node_revision_limit</a> as well (mentioned in <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/node_revision_delete/-/work_items/3264977" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/node_revision_delete/-/work_items/3264977</a></span>), which made me think a bit.</p> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>What if we could do the following, to greatly simplify the module architecture:</p> <ol> <li>Query nids of a specific type with more revisions than the configured minimum (per language).</li> <li>Query nids of a specific type with at least 1 revision older than the configured minimum.</li> <li>Add nids that appear in both queries to a queue for processing.</li> </ol> <p>Within the queue worker we can have a more simple query that only needs to work for a single node, where we can do things like:</p> <ul> <li>Skip revision IDs newer than the published revision (or not).</li> <li>Skip the active revision ID.</li> <li>Skip revision IDs newer than the configured minimum.</li> <li>Figure out which revision IDs to keep respecting the configured minimum amount of revisions.</li> </ul> <p>The biggest problem with this approach is the /admin/config/content/node_revision_delete overview. This currently tries to show the exact amount of revisions that might be considered for deletion, although I'm not sure how accurate this is at the moment. </p> <p>We can probably not show specific amounts in that overview using this new approach. Personally, I would consider the candidate revisions count a "nice to have", if this helps to simplify the way the module works and makes it more robust and flexible (for example allow other modules to deny a revision to be deleted using a hook?).</p> <h3 id="summary-remaining-tasks">Remaining tasks</h3> <p>Discuss if the simpler architecture is something to consider for this module, or maybe this should be done in a new / different module.<br> The changes should at least be a new major version since this will definitely break existing API.</p> <h3 id="summary-ui-changes">User interface changes</h3> <p>We could keep most of the UI, but we can no longer show the amount of candidate revisions on /admin/config/content/node_revision_delete.</p> <h3 id="summary-api-changes">API changes</h3> <p>Not sure yet, but we could definitely reduce and simplify some of the API.</p> <h3 id="summary-data-model-changes">Data model changes</h3> <p>-</p>