>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #2167021. --> Reported by: [wim leers](https://www.drupal.org/user/99777) >>> <p>Because <span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-17"><a href="https://www.drupal.org/project/drupal/issues/2158771" title="Status: Closed (outdated)">#2158771: CSS hardening</a></span> was addressed and you're looking for feedback, I figured I'd spend 30 minutes on my Saturday morning to test it and provide that feedback. Unfortunately, I could not get Navbar to work because of the Modernizr/Underscore/Backbone library detection that was seemingly completely broken.</p> <p>That happens for various reasons:</p> <ol> <li> <blockquote>Libraries API can only detect versions on the non-minified file. So if you want to use the minified Backbone/Underscore/Modernizr, you must either download both the unminified (backbone.js) and the minified (backbone-min.js), or only download the minified and rename it to backbone.js. Otherwise Libraries API will fail.</blockquote> </li> <li>The instructions don't explain *at all* how to use the minified libraries. They assume you want poor front-end performance.</li> <li>At the same time, the instructions implicitly assumed you *did* download the minified libraries and then renamed them as if they weren't minified. If you did download the non-minified libraries as per the instructions, then the version detection wouldn't work!!!</li> <li>Incorrectly, though understandably, <code>navbar_libraries_info()</code> pretended it supported a "minified" variant, but it could never have worked, because it did not implement the required "variant callback". If no variant callback is enabled, then Libraries API &hellip; <em>just assumes that the variant is installed</em> (!!! WTF !!!). This makes sense when downloading packages (zip/tar.gz/&hellip;) that contain both the minified and unminified files, but this does not reflect reality. So, in fact, you should <em>always</em> implement the variant callback, but Navbar did not yet do this.</li> <li>To deal with this variant craziness, Navbar had lots of logic to deal with checking if the minified version actually existed or not (instead of letting Libraries API do this), leading to more code complexity and <code>$variants = variable_get('navbar_libraries_variants', array());</code> which was introduced recently. If we use Libraries API correctly (even though that's ridiculously complex), then we can just ask Libraries API whether the minified variant exists, and if so, we just use that. In other words: gone is that <code>navbar_libaries_variants</code> variable, instead you just remove (or rename) the minified JS file if you want to use the non-minified JS. Much simpler.</li> </ol> <p>So, I wanted to fix this once and for all (and then Edit module could use the same techniques). Unfortunately, the tests are so artificial that they don't really test real-world use cases, the docs are so theoretical that they're useless and all of the example modules listed at <a href="https://drupal.org/node/1570568">https://drupal.org/node/1570568</a> fall in either of two categories: A) they stopped using Libraries API (gee, I wonder why), B) they use Libraries API in the most simple way possible (that is often also incorrect): they don't support a minified "variant".<br> That's why I ended up doing deep debugging of the Libraries API module and reading its "docs" and "tests" in-depth.</p> <p>I'm probably forgetting about a significant percentage of frustration and misery, but I'm hopeful that the collective pain endured so far will have led us to this patch that will hopefully allow us to erased this part of our memories, to be happily forgotten, forever.</p> > Related issue: [Issue #2169507](https://www.drupal.org/node/2169507) > Related issue: [Issue #2171765](https://www.drupal.org/node/2171765)