>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3340749. --> Reported by: [samitk](https://www.drupal.org/user/961934) Related to !3 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>Getting following error/warnings.</p> <p>FILE: /var/www/html/modules/contrib/multi_domain_login/css/multi_domain_login.css<br> ---------------------------------------------------------------------------------<br> FOUND 28 ERRORS AFFECTING 25 LINES<br> ---------------------------------------------------------------------------------<br> 2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 5 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 6 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 10 | ERROR | [x] Blank lines are not allowed in class definitions<br> 11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 15 | ERROR | [x] Blank lines are not allowed in class definitions<br> 16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 36 | ERROR | [x] Expected 1 space after colon in style definition; 2 found<br> 40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 40 | ERROR | [x] Expected 1 space after colon in style definition; 2 found<br> 44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 44 | ERROR | [x] Expected 1 space after colon in style definition; 2 found<br> ---------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 28 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ---------------------------------------------------------------------------------</p> <p>FILE: /var/www/html/modules/contrib/multi_domain_login/multi_domain_login.info.yml<br> -----------------------------------------------------------------------------------------------------------<br> FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES<br> -----------------------------------------------------------------------------------------------------------<br> 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically<br> 8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"<br> 9 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"<br> -----------------------------------------------------------------------------------------------------------</p> <p>FILE: /var/www/html/modules/contrib/multi_domain_login/multi_domain_login.install<br> ---------------------------------------------------------------------------------<br> FOUND 1 ERROR AFFECTING 1 LINE<br> ---------------------------------------------------------------------------------<br> 1 | ERROR | [x] Missing file doc comment<br> ---------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ---------------------------------------------------------------------------------</p> <p>FILE: /var/www/html/modules/contrib/multi_domain_login/README.md<br> ----------------------------------------------------------------------<br> FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES<br> ----------------------------------------------------------------------<br> 3 | WARNING | Line exceeds 80 characters; contains 116 characters<br> 4 | WARNING | Line exceeds 80 characters; contains 116 characters<br> 10 | WARNING | Line exceeds 80 characters; contains 114 characters<br> 11 | WARNING | Line exceeds 80 characters; contains 86 characters<br> 13 | WARNING | Line exceeds 80 characters; contains 114 characters<br> 38 | WARNING | Line exceeds 80 characters; contains 104 characters<br> ----------------------------------------------------------------------</p> <p>FILE: /var/www/html/modules/contrib/multi_domain_login/multi_domain_login.module<br> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------<br> FOUND 13 ERRORS AND 3 WARNINGS AFFECTING 9 LINES<br> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------<br> 1 | ERROR | [x] Missing file doc comment<br> 31 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for<br> | | xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates."<br> 31 | ERROR | [x] Function comment short description must start with exactly one space<br> 32 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment<br> 32 | ERROR | [ ] Missing parameter comment<br> 32 | ERROR | [ ] Missing parameter type<br> 33 | ERROR | [ ] Missing parameter comment<br> 33 | ERROR | [ ] Missing parameter type<br> 34 | ERROR | [ ] Missing parameter comment<br> 34 | ERROR | [ ] Missing parameter type<br> 35 | ERROR | [ ] Missing parameter comment<br> 35 | ERROR | [ ] Missing parameter type<br> 36 | ERROR | [x] Separate the @param and @return sections by a blank line.<br> 36 | ERROR | [ ] Description for the @return value is missing<br> 44 | WARNING | [x] A comma should follow the last multiline array item. Found: ''<br> 45 | WARNING | [x] A comma should follow the last multiline array item. Found: ]<br> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------</p> <p>FILE: /var/www/html/modules/contrib/multi_domain_login/src/Form/MultiDomainLoginForm.php<br> ---------------------------------------------------------------------------------------------<br> FOUND 2 ERRORS AND 7 WARNINGS AFFECTING 9 LINES<br> ---------------------------------------------------------------------------------------------<br> 8 | ERROR | [x] Missing class doc comment<br> 36 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"<br> 43 | WARNING | [x] A comma should follow the last multiline array item. Found: ''<br> 50 | WARNING | [x] A comma should follow the last multiline array item. Found: )<br> 57 | WARNING | [x] A comma should follow the last multiline array item. Found: )<br> 64 | WARNING | [x] A comma should follow the last multiline array item. Found: )<br> 71 | WARNING | [x] A comma should follow the last multiline array item. Found: )<br> 77 | WARNING | [x] A comma should follow the last multiline array item. Found: )<br> 84 | WARNING | [x] A comma should follow the last multiline array item. Found: )<br> ---------------------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ---------------------------------------------------------------------------------------------</p> <p>FILE: /var/www/html/modules/contrib/multi_domain_login/src/Controller/MultiDomainLoginController.php<br> ---------------------------------------------------------------------------------------------------------------------------------------------<br> FOUND 24 ERRORS AND 22 WARNINGS AFFECTING 45 LINES<br> ---------------------------------------------------------------------------------------------------------------------------------------------<br> 8 | WARNING | [x] Unused use statement<br> 13 | WARNING | [x] Unused use statement<br> 15 | WARNING | [x] Unused use statement<br> 18 | WARNING | [x] Unused use statement<br> 19 | WARNING | [x] Unused use statement<br> 43 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters<br> 54 | ERROR | [x] Additional blank lines found at end of doc comment<br> 70 | ERROR | [x] Additional blank lines found at end of doc comment<br> 89 | ERROR | [x] You must use "/**" style comments for a function comment<br> 90 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead<br> 95 | ERROR | [x] Equals sign not aligned correctly; expected 1 space but found 2 spaces<br> 96 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements<br> 100 | ERROR | [x] Language constructs must be followed by a single space; expected 1 space but found "&middot;&middot;"<br> 103 | WARNING | [ ] Line exceeds 80 characters; contains 96 characters<br> 105 | ERROR | [x] You must use "/**" style comments for a function comment<br> 106 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead<br> 115 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements<br> 123 | ERROR | [x] You must use "/**" style comments for a function comment<br> 128 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead<br> 129 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead<br> 137 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses<br> 148 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"<br> 151 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters<br> 155 | WARNING | [x] There must be no blank line following an inline comment<br> 155 | WARNING | [ ] There must be no blank line following an inline comment<br> 165 | WARNING | [x] A comma should follow the last multiline array item. Found: $hash<br> 167 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"<br> 170 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters<br> 175 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead<br> 180 | ERROR | [x] Missing function doc comment<br> 197 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead<br> 200 | ERROR | [x] Expected 1 blank line after function; 3 found<br> 203 | ERROR | [ ] More than 2 empty lines are not allowed<br> 207 | ERROR | [ ] Description for the @return value is missing<br> 212 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead<br> 216 | ERROR | [x] Missing function doc comment<br> 219 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead<br> 234 | ERROR | [ ] The array declaration extends to column 121 (the limit is 80). The array content should be split up over multiple lines<br> 238 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead<br> 242 | ERROR | [ ] The array declaration extends to column 112 (the limit is 80). The array content should be split up over multiple lines<br> 245 | ERROR | [x] Use "elseif" in place of "else if"<br> 272 | ERROR | [x] Missing function doc comment<br> 279 | ERROR | [x] Missing function doc comment<br> 281 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead<br> 287 | ERROR | [x] Expected 1 blank line after function; 0 found<br> 288 | ERROR | [x] The closing brace for the class must have an empty line before it<br> ---------------------------------------------------------------------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 27 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ---------------------------------------------------------------------------------------------------------------------------------------------</p> <p>FILE: /var/www/html/modules/contrib/multi_domain_login/src/EventSubscriber/UserLoginSubscriber.php<br> -------------------------------------------------------------------------------------------------------------------------------------------<br> FOUND 13 ERRORS AND 1 WARNING AFFECTING 10 LINES<br> -------------------------------------------------------------------------------------------------------------------------------------------<br> 16 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name<br> 19 | ERROR | [x] The open comment tag must be the only content on the line<br> 19 | ERROR | [ ] Missing short description in doc comment<br> 19 | ERROR | [x] Do not append variable name "$languageManager" to the type declaration in a member variable comment<br> 22 | ERROR | [x] The open comment tag must be the only content on the line<br> 22 | ERROR | [ ] Missing short description in doc comment<br> 22 | ERROR | [x] Do not append variable name "$routeMatch" to the type declaration in a member variable comment<br> 25 | ERROR | [ ] Missing short description in doc comment<br> 26 | ERROR | [x] Do not append variable name "$requestStack" to the type declaration in a member variable comment<br> 30 | ERROR | [ ] Parameter $requestStack is not described in comment<br> 33 | ERROR | [ ] Missing parameter comment<br> 34 | ERROR | [ ] Missing parameter comment<br> 57 | ERROR | [x] Data types in @param tags need to be fully namespaced<br> 64 | ERROR | [ ] The array declaration extends to column 98 (the limit is 80). The array content should be split up over multiple lines<br> -------------------------------------------------------------------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> -------------------------------------------------------------------------------------------------------------------------------------------</p> <p>Time: 2.03 secs; Memory: 6MB</p> <h4 id="summary-steps-reproduce">Steps to reproduce</h4> <p>Run following command</p> <p>phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/multi_domain_login/</p> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>Above error/warnings need to be fixed.</p>