>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3626726. --> Reported by: [fgm](https://www.drupal.org/user/27985) Related to !54 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>On PHP 8.5, PHPStan reported two errors in <code>modules/mongodb_storage/tests/src/Kernel/QueueTest.php</code>, the only ones left in the <code>phpstan (max PHP version)</code> CI job after <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/mongodb/-/work_items/3542043" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/mongodb/-/work_items/3542043</a></span> and <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/mongodb/-/work_items/3458044" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/mongodb/-/work_items/3458044</a></span>:</p> <ul> <li><code>tearDown()</code> called <code>unset($this-&gt;queueFactory)</code>: "Cannot unset property ... because it might have hooks in a subclass" (<code>unset.possiblyHookedProperty</code>, from PHP 8.4 property hooks).</li> <li><code>$rm-&gt;setAccessible(TRUE)</code> is deprecated in PHP 8.5, and has had no effect since PHP 8.1.</li> </ul> <p>Fixing them showed the static analysis could go much further, and working through it surfaced several real defects, so the scope grew beyond those two lines. <span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-7"><a href="https://www.drupal.org/project/mongodb/issues/3626739" title="Status: Closed (fixed)">#3626739: Fix test flakiness</a></span> depends on this issue landing first.</p> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>Implemented in the MR:</p> <ul> <li>PHP 8.5: the two <code>QueueTest</code> errors above.</li> <li>Static analysis: PHPStan passes up to level 6, on Drupal 10 as on Drupal 11, and every PHP file declares strict types. The configuration moves to <code>phpstan.neon.dist</code>, which the CI templates detect. PHPMD annotations are dropped, PHPMD being obsolete.</li> <li>Development dependencies: <code>drupal/core-dev</code> and the CI templates provide PHPUnit, Prophecy and PHP_CodeSniffer, so each core version gets matching ones. Only Drush stays, as <code>^14 || ^13.8.0 || ^12.5.3</code>, since the module ships Drush commands. This lets the next major composer job resolve.</li> <li>Library version: <code>libraryApiVersion()</code> reports the installed <code>mongodb/mongodb</code> version. <code>countCollection()</code> is deprecated in 8.x-2.2 and removed from 8.x-2.3: see the <a href="https://www.drupal.org/node/3626883">change record</a>.</li> <li>Queues fed by other applications: in enterprise integration, other applications may insert items directly into a queue collection. <ul> <li>Claims now also match items without <code>expires</code>, and store a missing <code>created</code> once, from an ObjectId <code>_id</code> or else the claim time, so that releasing and claiming again never changes it.</li> <li><code>releaseItem()</code> and <code>deleteItem()</code> use the stored <code>_id</code>: they used to rebuild an ObjectId, which failed for any other <code>_id</code> type.</li> <li>The documents such producers must write are documented in <code>docs/modules/mongodb_storage.md</code>. The payload stays PHP-serialized.</li> </ul> </li> <li><code>releaseItem()</code> results: tests pin that it returns TRUE only for a claimed item, like core's <code>Memory</code> queue, and the docs compare it with other backends, following the comparison in <span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-1"><a href="https://www.drupal.org/project/mongodb/issues/3626967" title="Status: Active">#3626967: Evaluate implementing DelayableQueueInterface</a></span>.</li> <li>Queues accept any <code>TimeInterface</code> service, not only core's <code>Time</code> class.</li> <li>Watchdog: the overview filter uses the request session instead of writing <code>$_SESSION</code> directly, deprecated in Drupal 11.2 and unsupported in Drupal 12.</li> </ul> <h3 id="summary-remaining-tasks">Remaining tasks</h3> <ul> <li>Review and merge.</li> <li>The Drupal 12 items found on the way (PHPUnit attributes, <code>#[RunTestsInSeparateProcesses]</code>, <code>#[LegacyRequirementsHook]</code>, <code>RequirementSeverity</code>, <code>xpath()</code>) belong to <span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-7"><a href="https://www.drupal.org/project/mongodb/issues/3626729" title="Status: Closed (fixed)">#3626729: Drupal 12 pre-release compatibility</a></span>.</li> </ul> <h3 id="summary-ui-changes">User interface changes</h3> <p>None.</p> <h3 id="summary-api-changes">API changes</h3> <ul> <li><code>countCollection()</code> is deprecated.</li> <li><code>Item::fromDoc()</code> is marked <code>@internal</code>, and throws on a document lacking <code>_id</code>, <code>created</code> or <code>expires</code>. <code>Item::mongoId()</code> is new.</li> <li><code>Queue::claimItem()</code> returns <code>Item|false</code>, and <code>Queue</code> and <code>QueueFactory</code> take a <code>TimeInterface</code>.</li> </ul> <h3 id="summary-data-model-changes">Data model changes</h3> <p>None for items created by Drupal. Items from other producers get <code>created</code> and <code>expires</code> stored at their first claim.</p> <h3>AI disclosure</h3> <p>This issue and MR are prepared with AI assistance.</p>