>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #1822434. --> Reported by: [dsnopek](https://www.drupal.org/user/266527) >>> <p>The main focus of this patch, is to make the implementation of mixpanel_track() more Drupal-y - but it also fixes some small bugs in mixpanel_get_defaults(). If necessary, I can break that out into it's own patch - just let me know!</p> <p>In any case, here are the main un-Drupal-y things in the current implementation of mixpanel_track() which my patch fixes:</p> <ul> <li><strong>It calls "curl" on the command line.</strong> This won't work on Windows machines or UNIX-like ones without "curl". However, the standard Drupal way of making an HTTP request is drupal_http_request(), which the patch uses.</li> <li><strong>It depends on the "&amp;" shell operator to contact the Mixpanel API outside of the current request.</strong> Again, this will fail under Windows. In Drupal, the standard way to do this is on cron and in Drupal 7 this means the Queue API. My patch will use the <a href="http://drupal.org/project/drupal_queue">drupal_queue</a> module to defer API calls to cron if it's installed. The drupal_queue module is a backport of the Drupal 7 Queue API, so when we port mixpanel to Drupal 7, the same code will work without needing any module.</li> <li><strong>It directly gets $_SERVER['REMOTE_ADDR'] rather than using ip_address().</strong> This also means it won't work behind a proxy.</li> <li><strong>There is no logging in the case of a failed call to the API.</strong> My patch will log failed requests to watchdog().</li> </ul> <p>Additionally it makes the following small fixes to mixpanel_get_defaults():</p> <ul> <li>It makes the static cache dependent on the $account passed in. The current implement will return the first defaults generated even if subsequent calls to mixpanel_track() pass in a different $account.</li> <li>'mp_tag_name' was being set to $user-&gt;name rather than $account-&gt;name. So, it would use the current user regardless of what $account variable was passed in.</li> <li>It also sets the 'time' property (one of the magic mixpanel ones) so that the deferred calls sometimes made (per the above points) will have the appropriate time.</li> </ul> <p>Please let me know what you think!</p> <p>Best regards,<br> David.</p> >>> [!note] Pre-migration files - [mixpanel-track-drupaly.patch](https://www.drupal.org/files/mixpanel-track-drupaly.patch) >>>