From 0667e3fc1e769a2fd9fb7f5959b8f42dc5cba2ba Mon Sep 17 00:00:00 2001
From: Chris Burgess <chris@giantrobot.co.nz>
Date: Mon, 24 Mar 2025 18:43:51 +1300
Subject: [PATCH 1/3] Issue #3514818: Add langcode to translatable config
---
config/schema/migrate_visualize.schema.yml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/config/schema/migrate_visualize.schema.yml b/config/schema/migrate_visualize.schema.yml
index b451cc4..db5a2e5 100644
--- a/config/schema/migrate_visualize.schema.yml
+++ b/config/schema/migrate_visualize.schema.yml
@@ -4,4 +4,5 @@ migrate_visualize.settings:
mapping:
display_mode:
type: text
- label: 'The output mode to use'
+ label: 'Display mode'
+ langcode: en
--
GitLab
From c48f413ef215d3be6410ee5b76e388363232a84c Mon Sep 17 00:00:00 2001
From: Chris Burgess <chris@giantrobot.co.nz>
Date: Mon, 24 Mar 2025 18:52:24 +1300
Subject: [PATCH 2/3] Issue #3512080: Add safeId to cspell words
---
.cspell-project-words.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/.cspell-project-words.txt b/.cspell-project-words.txt
index 7675740..d845d49 100644
--- a/.cspell-project-words.txt
+++ b/.cspell-project-words.txt
@@ -9,4 +9,5 @@ penwidth
pseudofield
pseudofields
rankdir
+safeid
xurizaemon
--
GitLab
From 0d2ca41ad74a1e370316ca9dceed02b51341e93f Mon Sep 17 00:00:00 2001
From: Chris Burgess <chris@giantrobot.co.nz>
Date: Mon, 24 Mar 2025 19:01:35 +1300
Subject: [PATCH 3/3] Issue #3514818: PHPCS fixes
---
src/MigrateGraph.php | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/MigrateGraph.php b/src/MigrateGraph.php
index c7b4d4d..277dc92 100644
--- a/src/MigrateGraph.php
+++ b/src/MigrateGraph.php
@@ -84,11 +84,13 @@ class MigrateGraph {
/**
* Make graph IDs "safe" (for MermaidJS).
*
- * @param $id
+ * @param string $id
+ * An ID of a graph item.
*
- * @return array|string|string[]|null
+ * @return string
+ * An ID, safe for use with MermaidJS.
*/
- public function safeId($id) {
+ public function safeId(string $id) {
return preg_replace('/[^a-zA-Z0-9_]/', '_', $id);
}
@@ -299,7 +301,7 @@ class MigrateGraph {
* @param \Fhaculty\Graph\Vertex $additionalSourceVertex
* (Optional) An additional source vertex. Used for chained sub-processes.
*/
- protected function graphProcessPlugin(string $destinationPropertyName, MigrateProcessInterface $plugin, Vertex $destinationVertex, int $pipelineStepId, array $plugins, Vertex $additionalSourceVertex = NULL) {
+ protected function graphProcessPlugin(string $destinationPropertyName, MigrateProcessInterface $plugin, Vertex $destinationVertex, int $pipelineStepId, array $plugins, ?Vertex $additionalSourceVertex = NULL) {
$graph = $this->getGraph();
/** @var ProcessPluginBase $processPlugin */
--
GitLab