Commit 5e138a69 authored by Joshua Sedler's avatar Joshua Sedler 🤸🏼 Committed by Cyle Carlson
Browse files

Issue #3271002 by Grevil: Fix coding standards, add installation test and fix schema errors

parent 9babaaf8

config/schema/micon.schema.yml

+3 −0
Original line number Diff line number Diff line
@@ -19,3 +19,6 @@ micon.micon.*: 
    archive:

      type: sequence

      label: 'Archive'

      sequence:

        type: string

        label: 'Archive content'

micon_content_type/src/MiconContentTypeListBuilder.php

+1 −1
Original line number Diff line number Diff line
@@ -14,7 +14,7 @@ class MiconContentTypeListBuilder extends NodeTypeListBuilder { 
   * {@inheritdoc}

   */

  public function buildHeader() {

    $header['icon'] = t('Icon');

    $header['icon'] = $this->t('Icon');

    return $header + parent::buildHeader();

  }

micon_link/src/Plugin/Field/FieldWidget/MiconLinkWidgetTrait.php

+3 −3
Original line number Diff line number Diff line
@@ -73,13 +73,13 @@ trait MiconLinkWidgetTrait { 


    $item = $items[$delta];

    $options = $item->get('options')->getValue();

    $attributes = isset($options['attributes']) ? $options['attributes'] : [];

    $attributes = $options['attributes'] ?? [];



    $element['options']['attributes']['data-icon'] = [

      '#type' => 'micon',

      '#title' => $this->t('Icon'),

      '#id' => $id,

      '#default_value' => isset($attributes['data-icon']) ? $attributes['data-icon'] : $this->getSetting('icon'),

      '#default_value' => $attributes['data-icon'] ?? $this->getSetting('icon'),

      '#packages' => $this->getPackages(),

    ];
@@ -90,7 +90,7 @@ trait MiconLinkWidgetTrait { 
        'before' => $this->t('Before'),

        'after' => $this->t('After'),

      ],

      '#default_value' => isset($attributes['data-icon-position']) ? $attributes['data-icon-position'] : NULL,

      '#default_value' => $attributes['data-icon-position'] ?? NULL,

      '#states' => [

        'invisible' => [

          '#' . $id => ['value' => ''],

micon_local_task/src/Form/MiconLocalTaskConfigForm.php

+1 −1
Original line number Diff line number Diff line
@@ -6,7 +6,7 @@ use Drupal\Core\Form\ConfigFormBase; 
use Drupal\Core\Form\FormStateInterface;



/**

 * Class MiconLocalTaskConfigForm.

 * The class MiconLocalTaskConfigForm.

 *

 * @package Drupal\micon_local_task\Form

 */

micon_menu/src/MiconMenuLinkManager.php

+1 −1
Original line number Diff line number Diff line
@@ -18,7 +18,7 @@ class MiconMenuLinkManager extends MenuLinkManager { 
   *

   * @param array $definition

   *   The definition to be processed and modified by reference.

   * @param $plugin_id

   * @param string $plugin_id

   *   The ID of the plugin this definition is being used for.

   */

  protected function processDefinition(array &$definition, $plugin_id) {