Commit f646df07 authored by Damien McKenna's avatar Damien McKenna Committed by Damien McKenna
Browse files

Issue #3106870 by DamienMcKenna: Improve UX around OG "secure" meta tags

parent f3a8e3e8

CHANGELOG.txt

+1 −0
Original line number Diff line number Diff line
@@ -43,6 +43,7 @@ By DamienMcKenna: Minor code readability tweak. 
  create token arguments once per call.

#3001282 by maximpodorov, DamienMcKenna: Support hasAffectingChanges method of

  FieldItemList.

#3106870 by DamienMcKenna: Improve UX around OG "secure" meta tags.





Metatag 8.x-1.11, 2019-12-20

metatag_open_graph/src/Plugin/metatag/Tag/OgImageSecureUrl.php

+1 −1
Original line number Diff line number Diff line
@@ -10,7 +10,7 @@ use Drupal\metatag\Plugin\metatag\Tag\MetaPropertyBase; 
 * @MetatagTag(

 *   id = "og_image_secure_url",

 *   label = @Translation("Image Secure URL"),

 *   description = @Translation("The secure URL (HTTPS) of an image which should represent the content. The image must be at least 50px by 50px and have a maximum aspect ratio of 3:1. Supports PNG, JPEG and GIF formats. All 'http://' URLs will automatically be converted to 'https://'."),

 *   description = @Translation("The secure URL (HTTPS) of an image which should represent the content. The image must be at least 200 x 200 pixels in size; 600 x 316 pixels is a recommended minimum size, and for best results use an image least 1200 x 630 pixels in size. Supports PNG, JPEG and GIF formats."),

 *   name = "og:image:secure_url",

 *   group = "open_graph",

 *   weight = 11,

metatag_open_graph/src/Plugin/metatag/Tag/OgVideoSecureUrl.php

+1 −1
Original line number Diff line number Diff line
@@ -10,7 +10,7 @@ use Drupal\metatag\Plugin\metatag\Tag\MetaPropertyBase; 
 * @MetatagTag(

 *   id = "og_video_secure_url",

 *   label = @Translation("Video Secure URL"),

 *   description = @Translation("The secure URL (HTTPS) of an video which should represent the content. The video must be at least 50px by 50px and have a maximum aspect ratio of 3:1. Supports PNG, JPEG and GIF formats. All 'http://' URLs will automatically be converted to 'https://'."),

 *   description = @Translation("The secure URL (HTTPS) of an video which should represent the content."),

 *   name = "og:video:secure_url",

 *   group = "open_graph",

 *   weight = 11,

src/Plugin/metatag/Tag/MetaNameBase.php

+1 −1
Original line number Diff line number Diff line
@@ -286,7 +286,7 @@ abstract class MetaNameBase extends PluginBase { 


    // Optional handling for secure paths.

    if (!empty($this->secure)) {

      $form['#description'] .= ' ' . $this->t('Any links containing http:// will be converted to https://');

      $form['#description'] .= ' ' . $this->t('Any URLs which start with "http://" will be converted to "https://".');

    }



    return $form;