Commit b81b42aa authored by Jens Gerboth's avatar Jens Gerboth Committed by Damien McKenna
Browse files

Issue #3313273 by DamienMcKenna, jenger1965, wells, JesperN, othermachines,... 

Issue #3313273 by DamienMcKenna, jenger1965, wells, JesperN, othermachines, flocondetoile: Incorrect unserialization error logged.
parent e807dc86

CHANGELOG.txt

+2 −0
Original line number Diff line number Diff line
@@ -2,6 +2,8 @@ Metatag 8.x-1.x-dev, 2022-xx-xx 
-------------------------------

#3312950 by DamienMcKenna, nkraft: Warning: Undefined array key "href" in

  Drupal\metatag_favicons\Plugin\metatag\Tag\MaskIcon->output().

#3313273 by DamienMcKenna, jenger1965, wells, JesperN, othermachines,

  flocondetoile: Incorrect unserialization error logged.





Metatag 8.x-1.22, 2022-09-29

src/MetatagManager.php

+8 −6
Original line number Diff line number Diff line
@@ -411,6 +411,7 @@ class MetatagManager implements MetatagManagerInterface { 
      $serialized_value = $item->get('value')->getValue();

      if (!empty($serialized_value)) {

        $new_tags = unserialize($serialized_value);

        if ($new_tags !== FALSE) {

          if (!empty($new_tags)) {

            if (is_array($new_tags)) {

              $tags += $new_tags;
@@ -419,6 +420,7 @@ class MetatagManager implements MetatagManagerInterface { 
              $this->logger->error("This was expected to be an array but it is not: \n%value", ['%value' => print_r($new_tags, TRUE)]);

            }

          }

        }

        else {

          $this->logger->error("This could not be unserialized: \n%value", ['%value' => print_r($serialized_value, TRUE)]);

        }