Commit b79462f2 authored by git's avatar git Committed by Damien McKenna
Browse files

Issue #3189850 by cmod, DamienMcKenna, J-Lee: Undefined index: href in metatag_page_attachments().

parent 673491d6

CHANGELOG.txt

+2 −0
Original line number Diff line number Diff line
@@ -20,6 +20,8 @@ Metatag 8.x-1.x-dev, xxxx-xx-xx 
#3190808 by Wim Leers, DamienMcKenna: Do not run a "table exists" query for

  every migrated row of data (regardless of whether it's a metatag row or not!).

#3193523 by DamienMcKenna: Removed files accidentally committed.

#3189850 by cmod, DamienMcKenna, J-Lee: Undefined index: href in

  metatag_page_attachments().





Metatag 8.x-1.15, 2020-12-05

metatag.module

+11 −8
Original line number Diff line number Diff line
@@ -156,17 +156,20 @@ function metatag_page_attachments(array &$attachments) { 
      // Also add a HTTP header "Link:" for canonical URLs and shortlinks.

      // See HtmlResponseAttachmentsProcessor::processHtmlHeadLink() for the

      // implementation of the functionality in core.

      if (isset($item[0]['#attributes']['href'])) {

        if (in_array($item[1], ['canonical_url', 'shortlink'])) {

          $attributes = $item[0]['#attributes'];



          $href = '<' . Html::escape($attributes['href']) . '>';

          unset($attributes['href']);

        if ($param = HtmlResponseAttachmentsProcessor::formatHttpHeaderAttributes($attributes)) {

          $param = HtmlResponseAttachmentsProcessor::formatHttpHeaderAttributes($attributes);

          if (!empty($param)) {

            $href .= ';' . $param;

          }

          $head_links[] = $href;

        }

      }

    }



    // If any HTTP Header items were found, add them too.

    if (!empty($head_links)) {