Commit b1123a4c authored by Len Swaneveld's avatar Len Swaneveld Committed by Damien McKenna
Browse files

Issue #3110152 by DamienMcKenna, antongp, Lendude: testTagsArePresent() and... 

Issue #3110152 by DamienMcKenna, antongp, Lendude: testTagsArePresent() and testTagsInputOutput() methods of the MetatagTagsTestBase class do not loop through child classes $tags property.
parent 4484399c

CHANGELOG.txt

+3 −0
Original line number Diff line number Diff line
@@ -52,6 +52,9 @@ By DamienMcKenna: Minor code readability tweak. 
#3120947 by DamienMcKenna, quietone: Expand FieldInstanceTest classes to handle

  multiple bundles per entity type.

#3122683 by Neslee Canil Pinto: Capitalize the name of the module in .info file.

#3110152 by DamienMcKenna, antongp, Lendude: testTagsArePresent() and

  testTagsInputOutput() methods of the MetatagTagsTestBase class do not loop

  through child classes $tags property.





Metatag 8.x-1.11, 2019-12-20

metatag_open_graph/tests/src/Functional/MetatagOpenGraphTagsTest.php

+7 −6
Original line number Diff line number Diff line
@@ -31,12 +31,9 @@ class MetatagOpenGraphTagsTest extends MetatagTagsTestBase { 
    'og_determiner',

    'og_email',

    'og_fax_number',

    'og_image',

    'og_image_alt',

    'og_image_height',

    'og_image_secure_url',

    'og_image_type',

    'og_image_url',

    'og_image_width',

    'og_latitude',

    'og_locale',
@@ -52,13 +49,17 @@ class MetatagOpenGraphTagsTest extends MetatagTagsTestBase { 
    'og_title',

    'og_type',

    'og_updated_time',

    'og_url',

    'og_video',

    'og_video_height',

    'og_video_secure_url',

    'og_video_type',

    'og_video_width',

    'og_video_duration',

    // @todo Fix these.

    // 'og_image',

    // 'og_image_secure_url',

    // 'og_image_url',

    // 'og_url',

    // 'og_video',

    // 'og_video_secure_url',

  ];



  /**

metatag_open_graph_products/config/schema/metatag_open_graph_products.metatag_tag.schema.yml

+2 −2
Original line number Diff line number Diff line 
metatag.metatag_tag.og_price_amount:

metatag.metatag_tag.product_price_amount:

  type: label

  label: 'Open Graph Product: Price amount'

metatag.metatag_tag.og_price_currency:

metatag.metatag_tag.product_price_currency:

  type: label

  label: 'Open Graph Product: Price currency'

metatag_pinterest/tests/src/Functional/MetatagPinterestTagsTest.php

+5 −4
Original line number Diff line number Diff line
@@ -18,10 +18,11 @@ class MetatagPinterestTagsTest extends MetatagTagsTestBase { 
    'pinterest_description',

    'pinterest_id',

    'pinterest_media',

    'pinterest_nopin',

    'pinterest_nohover',

    'pinterest_nosearch',

    'pinterest_url',

    // @todo Fix these.

    // 'pinterest_nopin',

    // 'pinterest_nohover',

    // 'pinterest_nosearch',

  ];



  /**
@@ -46,7 +47,7 @@ class MetatagPinterestTagsTest extends MetatagTagsTestBase { 
   * Each of these meta tags has a different tag name vs its internal name.

   */

  protected function getTestTagName($tag_name) {

    if ($tag_name == ('pinterest_nopin' || 'pinterest_nohover' || 'pinterest_nosearch')) {

    if ($tag_name == 'pinterest_nopin' || $tag_name == 'pinterest_nohover' || $tag_name == 'pinterest_nosearch') {

      $tag_name = 'pinterest';

    }

    else {

metatag_twitter_cards/tests/src/Functional/MetatagTwitterCardsTagsTest.php

+7 −6
Original line number Diff line number Diff line
@@ -31,18 +31,12 @@ class MetatagTwitterCardsTagsTest extends MetatagTagsTestBase { 
    'twitter_cards_data2',

    'twitter_cards_description',

    'twitter_cards_donottrack',

    'twitter_cards_gallery_image0',

    'twitter_cards_gallery_image1',

    'twitter_cards_gallery_image2',

    'twitter_cards_gallery_image3',

    'twitter_cards_image',

    'twitter_cards_image_alt',

    'twitter_cards_image_height',

    'twitter_cards_image_width',

    'twitter_cards_label1',

    'twitter_cards_label2',

    'twitter_cards_page_url',

    'twitter_cards_player',

    'twitter_cards_player_height',

    'twitter_cards_player_stream',

    'twitter_cards_player_stream_content_type',
@@ -51,6 +45,13 @@ class MetatagTwitterCardsTagsTest extends MetatagTagsTestBase { 
    'twitter_cards_site_id',

    'twitter_cards_title',

    'twitter_cards_type',

    // @todo Fix test coverage for these tags.

    // 'twitter_cards_gallery_image0',

    // 'twitter_cards_gallery_image1',

    // 'twitter_cards_gallery_image2',

    // 'twitter_cards_gallery_image3',

    // 'twitter_cards_image',

    // 'twitter_cards_player',

  ];



  /**