Commit 3c00fd23 authored by Damien McKenna's avatar Damien McKenna Committed by Damien McKenna
Browse files

Issue #3123520 by DamienMcKenna, phenaproxima: Remove Schema.org Metatag dependency for D9.

parent 0939f830

CHANGELOG.txt

+2 −0
Original line number Diff line number Diff line 
Metatag 8.x-1.x-dev, xxxx-xx-xx

-------------------------------

#3123520 by DamienMcKenna, phenaproxima: Remove Schema.org Metatag dependency

  for D9.





Metatag 8.x-1.12, 2020-03-30

README.txt

+0 −24
Original line number Diff line number Diff line
@@ -312,30 +312,6 @@ There is also a command for generating meta tag groups: 
Again, this provides a guided process to create a new group.





Known issue with testing infrastructure

--------------------------------------------------------------------------------

Thanks to contributions from the community, the Metatag module has an extensive

collection of tests to ensure proposed changes avoid breaking the module.



Part of this includes a test that confirms the separate Schema.org Metatag

module suite continues to work. This test is specifically designed with the

drupal.org testing platform in mind. Projects which have their own testing

infrastructure might run into errors like the following:



`Fatal error: Class 'Drupal\Tests\schema_web_page\Functional\SchemaWebPageTest'

not found in SchemaMetatagTest.php on line 17`



To resolve this, add "schema_metatag" as a "require-dev" item in the project's

custom composer.json. This can be done by running the following in the

project's root:



  composer require --dev drupal/schema_metatag



This will update composer.json and composer.lock as well as download the

dependency. When `composer install` is run on a production deployment and the

`--no-dev` flag is provided it will skip installing the dev requirements.





Related modules

--------------------------------------------------------------------------------

Some modules are available that extend Metatag with additional or complimentary

composer.json

+1 −2
Original line number Diff line number Diff line
@@ -29,7 +29,6 @@ 
    "drupal/devel": "^2.0",

    "drupal/redirect": "^1.0",

    "drupal/restui": "^1.0",

    "drupal/page_manager": "^4.0",

    "drupal/schema_metatag": "^1.0"

    "drupal/page_manager": "^4.0"

  }

}

metatag.info.yml

+0 −1
Original line number Diff line number Diff line
@@ -12,4 +12,3 @@ test_dependencies: 
  - devel:devel

  - redirect:redirect

  - restui:restui
 
  - schema_metatag:schema_web_page

tests/src/Functional/SchemaMetatagTest.php

deleted100644 → 0
+0 −19
Original line number Diff line number Diff line 
<?php



namespace Drupal\Tests\metatag\Functional;



use Drupal\Tests\schema_web_page\Functional\SchemaWebPageTest;



/**

 * Wrapper to trigger one of the Schema.org Metatag module's tests.

 *

 * This will help avoid making changes to Metatag that trigger problems for

 * separate submodules.

 *

 * @see https://www.drupal.org/project/metatag/issues/2994979

 *

 * @group metatag

 */

class SchemaMetatagTest extends SchemaWebPageTest {

  // Just run the tests as-is.

}