Commit 200ca433 authored by Zoltan Attila Horvath's avatar Zoltan Attila Horvath Committed by Damien McKenna
Browse files

Issue #3158613 by huzooka, DamienMcKenna, Wim Leers: Metatag field instance... 

Issue #3158613 by huzooka, DamienMcKenna, Wim Leers: Metatag field instance migration source plugins report incorrect number of items.
parent 368021aa

CHANGELOG.txt

+2 −0
Original line number Diff line number Diff line
@@ -13,6 +13,8 @@ Metatag 8.x-1.x-dev, xxxx-xx-xx 
  (MetatagViewsTranslationForm).

#3134665 by Neslee Canil Pinto, rokzabukovec: Correct description of

  OgImageWidth.php file.

#3158613 by huzooka, DamienMcKenna, Wim Leers: Metatag field instance migration

  source plugins report incorrect number of items.





Metatag 8.x-1.13, 2020-04-21

src/Plugin/migrate/source/d6/NodewordsFieldInstance.php

+7 −0
Original line number Diff line number Diff line
@@ -111,4 +111,11 @@ class NodewordsFieldInstance extends DrupalSqlBase { 
    return $ids;

  }



  /**

   * {@inheritdoc}

   */

  public function count($refresh = FALSE) {

    return $this->initializeIterator()->count();

  }



}

src/Plugin/migrate/source/d7/MetatagFieldInstance.php

+7 −0
Original line number Diff line number Diff line
@@ -90,4 +90,11 @@ class MetatagFieldInstance extends DrupalSqlBase { 
    return $ids;

  }



  /**

   * {@inheritdoc}

   */

  public function count($refresh = FALSE) {

    return $this->initializeIterator()->count();

  }



}

tests/src/Kernel/Plugin/migrate/source/d6/NodewordsFieldInstanceTest.php

+0 −3
Original line number Diff line number Diff line
@@ -110,9 +110,6 @@ class NodewordsFieldInstanceTest extends MigrateSqlSourceTestBase { 
      ],

    ];



    // The source query has 3 rows, so hardcode this value so the test passes.

    // @todo This feels like cheating?

    $tests[0]['expected_count'] = 3;

    return $tests;

  }

tests/src/Kernel/Plugin/migrate/source/d7/MetatagFieldInstanceTest.php

+0 −3
Original line number Diff line number Diff line
@@ -105,9 +105,6 @@ class MetatagFieldInstanceTest extends MigrateSqlSourceTestBase { 
      ],

    ];



    // The source query has 3 rows, so hardcode this value so the test passes.

    // @todo This feels like cheating?

    $tests[0]['expected_count'] = 3;

    return $tests;

  }