Commit 1a70b673 authored by Damien McKenna's avatar Damien McKenna
Browse files

Issue #3072165 by vuil, DamienMcKenna: Coding standards improvements.

parent 4c6e2fd9

CHANGELOG.txt

+1 −0
Original line number Diff line number Diff line
@@ -29,6 +29,7 @@ Metatag 8.x-1.x-dev, xxxx-xx-xx 
  SchemaWebPageTest not found.

#3080314 by matteodem, DamienMcKenna: Load metatag defaults based on entity

  language.

#3072165 by vuil, DamienMcKenna: Coding standards improvements.





Metatag 8.x-1.10, 2019-08-29

metatag.module

+1 −1
Original line number Diff line number Diff line
@@ -416,7 +416,7 @@ function metatag_preprocess_html(&$variables) { 


  // Load the page title.

  if (!empty($attachments['#attached']['html_head'])) {

    foreach ($attachments['#attached']['html_head'] as $key => $attachment) {

    foreach ($attachments['#attached']['html_head'] as $attachment) {

      if (!empty($attachment[1]) && $attachment[1] == 'title') {

        // Empty head_title to avoid the site name and slogan to be appended to

        // the meta title.

metatag_views/src/Controller/MetatagViewsTranslationController.php

+2 −0
Original line number Diff line number Diff line
@@ -141,7 +141,9 @@ class MetatagViewsTranslationController extends ControllerBase { 
        '#links' => $operations,

        // Even if the mapper contains multiple language codes, the source

        // configuration can still be edited.

        // {@code}

        // '#access' => ($langcode == $original_langcode) || $operations_access,

        // {@endcode}

      ];

    }

src/MetatagDefaultsListBuilder.php

+2 −2
Original line number Diff line number Diff line
@@ -107,8 +107,8 @@ class MetatagDefaultsListBuilder extends ConfigEntityListBuilder { 
    }

    if (strpos($entity->id(), '__') !== FALSE) {

      $prefix .= '<div class="indentation"></div>';

      list($entity_label, $bundle_label) = explode(': ', $entity->get('label'));

      $inherits .= ', ' . $entity_label;

      $entity_label = explode(': ', $entity->get('label'));

      $inherits .= ', ' . $entity_label[0];

    }



    if (!empty($inherits)) {

src/Plugin/metatag/Tag/Title.php

+2 −0
Original line number Diff line number Diff line
@@ -24,6 +24,7 @@ class Title extends MetaNameBase { 
   *

   * @todo Override the existing title tag X-)

   */

  // {@code}

  // public function output() {

  //   if (empty($this->value)) {

  //     // If there is no value, we don't want a tag output.
@@ -39,5 +40,6 @@ class Title extends MetaNameBase { 
  //

  //   return $element;

  // }

  // {@endcode}



}