Remove duplicate "expand all menu items" checkbox introduced by core in Drupal 8.7
>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3133567. --> Reported by: [bkosborne](https://www.drupal.org/user/788032) >>> <p>Since Drupal 8.7, Drupal core has been providing a "expand all menu items" checkbox on its menu block: <span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-7"><a href="https://www.drupal.org/project/drupal/issues/2594425" title="Status: Closed (fixed)">#2594425: Add the option in system menu block to "Expand all items in this tree"</a></span>.</p> <p>This is essentially a duplicate of the "Expand all menu links" option that this module provides.</p> <p>The problem is that since this module's menu block extends from core's, both checkboxes appear, which is very confusing. Not only that, but it's impossible to actually enable the checkbox from core, because this module's block doesn't execute core's submit handler, so the config is never saved for that checkbox.</p> <p>If a goal of this module is to have core eventually adopt its functionality, this is good. This means core as already started doing this. Now the challenge is we need to remove the config option from this module and use core's. This is not so easy because the configs are named differently. Core uses config key "expand_all_items" and this module just uses "expand". So there would need to be a migration path to update config for all usages of this plugin to use the key provided by core. Yikes. Not really practical since block configs can be anywhere these days.</p> <p>Instead, we should at the very least hide this checkbox from core since it doesn't do anything.</p> > Related issue: [Issue #2594425](https://www.drupal.org/node/2594425) > Related issue: [Issue #3134036](https://www.drupal.org/node/3134036)
issue