SharedTempStore as session storage over DatabaseSessionStore (#3585861) · Issues · project / mcp_server

SharedTempStore as session storage over DatabaseSessionStore

>>> [!note] Migrated issue   Reported by: [mglaman](https://www.drupal.org/user/2416470) >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <code>DatabaseSessionStore</code> is the only <code>SessionStoreInterface</code> implementation in <code>mcp_server</code>. It requires a custom <code>mcp_session_queue</code> database table, manages its own <code>expires_at</code> column, and relies on <code>DbSessionManager::gc()</code> being called externally to delete expired rows. Sites that already run Drupal's key-value expiry system (used by <code>SharedTempStore</code>) gain nothing from this parallel infrastructure they pay for an extra table and manual GC wiring that Drupal's tempstore subsystem already provides for free. This is what we implemented, offering as a suggestion. <h3 id="summary-proposed-resolution">Proposed resolution</h3> Add a <code>SharedTempStoreSessionStore</code> class that implements <code>SessionStoreInterface</code> using Drupal's <code>SharedTempStoreFactory</code>. Drupal's tempstore layer handles expiry automatically via its own GC, so <code>gc()</code> becomes a no-op. No custom schema, no cron hook. PHP Create <code>src/Session/SharedTempStoreSessionStore.php</code>: <pre><pre><?php declare(strict_types=1); namespace Drupal\mcp_server\Session; use Drupal\Core\TempStore\SharedTempStore; use Drupal\Core\TempStore\SharedTempStoreFactory; use Drupal\Core\TempStore\TempStoreException; use Mcp\Server\Session\SessionStoreInterface; use Symfony\Component\Uid\Uuid; final readonly class SharedTempStoreSessionStore implements SessionStoreInterface {   private const string COLLECTION = 'mcp_sessions';   public function __construct(     private SharedTempStoreFactory $tempStoreFactory,   ) {}   public function exists(Uuid $id): bool {     return $this->read($id) !== FALSE;   }   public function read(Uuid $id): string|false {     return $this->store()->get($id->toRfc4122()) ?? FALSE;   }   public function write(Uuid $id, string $data): bool {     try {       $this->store()->set($id->toRfc4122(), $data);       return TRUE;     }     catch (TempStoreException) {       return FALSE;     }   }   public function destroy(Uuid $id): bool {     try {       $this->store()->delete($id->toRfc4122());       return TRUE;     }     catch (TempStoreException) {       return FALSE;     }   }   public function gc(): array {     return [];   }   private function store(): SharedTempStore {     return $this->tempStoreFactory->get(self::COLLECTION);   } } ?></pre></pre><h3 id="summary-api-changes">API changes</h3> <h3 id="summary-ai-usage">AI usage (if applicable)</h3> [X AI Assisted Issue This issue was generated with AI assistance, but was reviewed and refined by the creator. [ ] AI Assisted Code This code was mainly generated by a human, with AI autocompleting or parts AI generated, but under full human supervision. [ ] AI Generated Code This code was mainly generated by an AI with human guidance, and reviewed, tested, and refined by a human. [ ] Vibe Coded This code was generated by an AI and has only been functionally tested.

issue